0002425: Magic Guild doesn't teach garrisoned hero new spells after upgrading one - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0002425

VCMI

Mechanics - Objects

public

2016-03-12 14:45

2022-04-12 10:47

Reporter

Kantor

Assigned To

SXX

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

0.98g

Target Version

Fixed in Version

0.99

Summary

0002425: Magic Guild doesn't teach garrisoned hero new spells after upgrading one

Description

As description says, upgrading Magic Guild doesn't add any new spells, that hero can learn. Spells are added after revisiting town.

Tags

No tags attached.

Relationships

Notes
(0006475) SXX (administrator) 2016-03-13 07:12 edited on: 2016-03-13 07:13	So here is logic in CGameHandler::buildStructure to do this, but it's doesn't work because it's executed before NewStructures apply on gamestate. Also suppose there is no code to give new spells when library built in Tower.

(0006477) SXX (administrator) 2016-03-13 08:42	Fixed: https://github.com/vcmi/vcmi/commit/bee0c6d7052bb868ed5e29082aa302ef8d397d6c [^]

Issue History
Date Modified	Username	Field	Change
2016-03-12 14:45	Kantor	New Issue
2016-03-13 07:08	SXX	Assigned To	=> SXX
2016-03-13 07:08	SXX	Status	new => assigned
2016-03-13 07:12	SXX	Note Added: 0006475
2016-03-13 07:13	SXX	Note Edited: 0006475	View Revisions
2016-03-13 08:42	SXX	Note Added: 0006477
2016-03-13 08:42	SXX	Status	assigned => resolved
2016-03-13 08:42	SXX	Fixed in Version	=> 0.98g
2016-03-13 08:42	SXX	Resolution	open => fixed
2016-03-13 08:42	SXX	Fixed in Version	0.98g => 0.99
2022-04-12 10:47	Povelitel	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team