MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002425VCMIMechanics - Objectspublic2016-03-12 14:452022-04-12 10:47
ReporterKantor 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.98g 
Target VersionFixed in Version0.99 
Summary0002425: Magic Guild doesn't teach garrisoned hero new spells after upgrading one
DescriptionAs description says, upgrading Magic Guild doesn't add any new spells, that hero can learn. Spells are added after revisiting town.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-12 14:45KantorNew Issue
2016-03-13 07:08SXXAssigned To => SXX
2016-03-13 07:08SXXStatusnew => assigned
2016-03-13 07:12SXXNote Added: 0006475
2016-03-13 07:13SXXNote Edited: 0006475bug_revision_view_page.php?bugnote_id=6475#r3179
2016-03-13 08:42SXXNote Added: 0006477
2016-03-13 08:42SXXStatusassigned => resolved
2016-03-13 08:42SXXFixed in Version => 0.98g
2016-03-13 08:42SXXResolutionopen => fixed
2016-03-13 08:42SXXFixed in Version0.98g => 0.99
2022-04-12 10:47PovelitelStatusresolved => closed

Notes
(0006475)
SXX   
2016-03-13 07:12   
(edited on: 2016-03-13 07:13)
So here is logic in CGameHandler::buildStructure to do this, but it's doesn't work because it's executed before NewStructures apply on gamestate. Also suppose there is no code to give new spells when library built in Tower.
(0006477)
SXX   
2016-03-13 08:42   
Fixed:
https://github.com/vcmi/vcmi/commit/bee0c6d7052bb868ed5e29082aa302ef8d397d6c [^]