0001713: very long turn AI - SectorMap memory leak

Issue History
Date Modified	Username	Field	Change
2014-02-13 23:31	Povelitel	New Issue
2014-02-13 23:31	Povelitel	File Added: Paragon.h3m
2014-02-15 15:23	Povelitel	Note Added: 0004479
2014-02-15 17:07	Warmonger	Relationship added	related to 0001696
2014-02-15 17:08	Warmonger	Note Added: 0004480
2014-12-20 11:03	Warmonger	Note Added: 0005222
2014-12-20 11:03	Warmonger	Status	new => resolved
2014-12-20 11:03	Warmonger	Fixed in Version	=> 0.97
2014-12-20 11:03	Warmonger	Resolution	open => fixed
2014-12-20 11:03	Warmonger	Assigned To	=> Warmonger
2014-12-25 10:19	Povelitel	Note Added: 0005278
2014-12-25 10:20	Povelitel	Status	resolved => feedback
2014-12-25 10:20	Povelitel	Resolution	fixed => reopened
2015-01-04 22:56	Povelitel	Note Added: 0005314
2015-01-04 22:56	Povelitel	Status	feedback => assigned
2015-01-04 22:56	Povelitel	File Added: VCMI_Client_log.txt
2015-01-04 22:56	Povelitel	File Added: VCMI_Server_log.txt
2015-01-04 22:56	Povelitel	Note Edited: 0005314	View Revisions
2016-02-04 17:26	SXX	Assigned To	Warmonger => SXX
2016-02-04 17:27	SXX	Relationship added	related to 0002326
2016-02-25 06:52	SXX	Note Added: 0006454
2016-02-25 06:55	SXX	Note Added: 0006455
2016-08-10 23:23	SXX	Relationship added	related to 0002454
2016-08-11 08:24	SXX	Note Added: 0006549
2016-08-11 08:24	SXX	Assigned To	SXX => Warmonger
2016-08-11 08:24	SXX	Status	assigned => feedback
2016-08-11 08:25	SXX	Note Edited: 0006549	View Revisions
2016-08-11 08:28	SXX	Summary	very long turn AI => very long turn AI - SectorMap memory leak
2016-08-11 08:52	Warmonger	Note Added: 0006550
2016-08-11 08:52	Warmonger	Note Edited: 0006550	View Revisions
2016-08-11 09:28	SXX	Note Added: 0006551
2016-08-11 09:29	SXX	Note Edited: 0006551	View Revisions
2016-08-11 09:31	SXX	Note Edited: 0006551	View Revisions
2016-11-09 12:54	Povelitel	File Added: the mage yhne(normal).h3m
2016-11-09 12:55	Povelitel	Note Added: 0006893
2016-11-09 12:55	Povelitel	Status	feedback => assigned
2016-12-12 18:27	Warmonger	Note Added: 0006941
2016-12-12 18:29	Warmonger	Note Edited: 0006941	View Revisions
2016-12-12 18:31	Warmonger	Note Edited: 0006941	View Revisions
2016-12-12 19:00	Warmonger	Note Added: 0006942
2016-12-12 20:39	Warmonger	Note Added: 0006943
2016-12-12 20:39	Warmonger	Status	assigned => resolved
2016-12-12 20:39	Warmonger	Fixed in Version	0.97 => 1.next
2016-12-12 20:39	Warmonger	Resolution	reopened => fixed
2016-12-12 20:39	Warmonger	Severity	minor => major
2016-12-13 07:46	Povelitel	Note Added: 0006944
2022-04-12 11:18	Povelitel	Status	resolved => closed

Notes
(0004479) Povelitel (updater) 2014-02-15 15:23	Check somebody. In sod turn few second. Vcmi ~ 5 minute very strange

(0004480) Warmonger (administrator) 2014-02-15 17:08	Could improve when 0001696 is implemented.

(0005222) Warmonger (administrator) 2014-12-20 11:03	All "long AI turn" issues should be fixed in 0.97.

(0005278) Povelitel (updater) 2014-12-25 10:19	not really. this map is still long

(0005314) Povelitel (updater) 2015-01-04 22:56 edited on: 2015-01-04 22:56	and now game aborted. just closed. 1 day - end turn. 0.97b (add logs)

(0006454) SXX (administrator) 2016-02-25 06:52	This one is still slow as hell and problem is somewhere in sector map code.

(0006455) SXX (administrator) 2016-02-25 06:55	In SectorMap::exploreNewSector toVisit slowly growing to extreme size.

(0006549) SXX (administrator) 2016-08-11 08:24 edited on: 2016-08-11 08:25	@Warmonger can you please share you thoughts why exactly this one appear? Also how you wanted to fix it after having patrol in place? I'll be happy to work on this one and I now understand ideas behind SectorMap more or less, but I still wonder what solution you seen for this bug.

(0006550) Warmonger (administrator) 2016-08-11 08:52 edited on: 2016-08-11 08:52	With patrol implemented at pathfinder level AI finds tiles and objects beyond patrol radius inaccessible, so it shuld not process it at all. This can be the case on some maps where AI has fixed radius but knows entire map, for eg. via Skyship.

(0006551) SXX (administrator) 2016-08-11 09:28 edited on: 2016-08-11 09:31	Yep that's true, but sector map memory usage shouldn't grow until it's crash. Right? I just thought you checked the map and had ideas why it's stay in infinite loop.

(0006893) Povelitel (updater) 2016-11-09 12:55	add map, too memory leak

(0006941) Warmonger (administrator) 2016-12-12 18:27 edited on: 2016-12-12 18:31	On map Paragon Tan and Teal player give "bad allocation" error. They are allies, but to my suprise don't have acess to Skyship.

(0006942) Warmonger (administrator) 2016-12-12 19:00	I think I got it - retreiveTileN returns "unsigned char" and there are more than 255 sectors on the map.

(0006943) Warmonger (administrator) 2016-12-12 20:39	Fixed in https://github.com/vcmi/vcmi/commit/27ff9efd4bda45ae85896d99f695a7d485e02ea6 [^]

(0006944) Povelitel (updater) 2016-12-13 07:46	Very cool! It's my dream pass map Paragon on vcmi. Will test!