MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001713VCMIGUI - Adventure Mappublic2014-02-13 23:312022-04-12 11:18
ReporterPovelitel 
Assigned ToWarmonger 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.94e 
Target VersionFixed in Version1.next 
Summary0001713: very long turn AI - SectorMap memory leak
DescriptionImpossible play
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001696closed SXX AI heroes with set "patrol" property should not leave specified radius 
related to 0002326closed SXX AI turn takes really long when there is many completely blocked heroes 
related to 0002454closed SXX AI turn extremely slow when wandering 
Attached Files? Paragon.h3m (368,955) 2014-02-13 23:31
https://bugs.vcmi.eu/file_download.php?file_id=1704&type=bug
txt VCMI_Client_log.txt (4,163,855) 2015-01-04 22:56
https://bugs.vcmi.eu/file_download.php?file_id=2063&type=bug
txt VCMI_Server_log.txt (2,190,945) 2015-01-04 22:56
https://bugs.vcmi.eu/file_download.php?file_id=2064&type=bug
? the mage yhne(normal).h3m (352,929) 2016-11-09 12:54
https://bugs.vcmi.eu/file_download.php?file_id=2641&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-02-13 23:31PovelitelNew Issue
2014-02-13 23:31PovelitelFile Added: Paragon.h3m
2014-02-15 15:23PovelitelNote Added: 0004479
2014-02-15 17:07WarmongerRelationship addedrelated to 0001696
2014-02-15 17:08WarmongerNote Added: 0004480
2014-12-20 11:03WarmongerNote Added: 0005222
2014-12-20 11:03WarmongerStatusnew => resolved
2014-12-20 11:03WarmongerFixed in Version => 0.97
2014-12-20 11:03WarmongerResolutionopen => fixed
2014-12-20 11:03WarmongerAssigned To => Warmonger
2014-12-25 10:19PovelitelNote Added: 0005278
2014-12-25 10:20PovelitelStatusresolved => feedback
2014-12-25 10:20PovelitelResolutionfixed => reopened
2015-01-04 22:56PovelitelNote Added: 0005314
2015-01-04 22:56PovelitelStatusfeedback => assigned
2015-01-04 22:56PovelitelFile Added: VCMI_Client_log.txt
2015-01-04 22:56PovelitelFile Added: VCMI_Server_log.txt
2015-01-04 22:56PovelitelNote Edited: 0005314bug_revision_view_page.php?bugnote_id=5314#r2780
2016-02-04 17:26SXXAssigned ToWarmonger => SXX
2016-02-04 17:27SXXRelationship addedrelated to 0002326
2016-02-25 06:52SXXNote Added: 0006454
2016-02-25 06:55SXXNote Added: 0006455
2016-08-10 23:23SXXRelationship addedrelated to 0002454
2016-08-11 08:24SXXNote Added: 0006549
2016-08-11 08:24SXXAssigned ToSXX => Warmonger
2016-08-11 08:24SXXStatusassigned => feedback
2016-08-11 08:25SXXNote Edited: 0006549bug_revision_view_page.php?bugnote_id=6549#r3196
2016-08-11 08:28SXXSummaryvery long turn AI => very long turn AI - SectorMap memory leak
2016-08-11 08:52WarmongerNote Added: 0006550
2016-08-11 08:52WarmongerNote Edited: 0006550bug_revision_view_page.php?bugnote_id=6550#r3198
2016-08-11 09:28SXXNote Added: 0006551
2016-08-11 09:29SXXNote Edited: 0006551bug_revision_view_page.php?bugnote_id=6551#r3200
2016-08-11 09:31SXXNote Edited: 0006551bug_revision_view_page.php?bugnote_id=6551#r3201
2016-11-09 12:54PovelitelFile Added: the mage yhne(normal).h3m
2016-11-09 12:55PovelitelNote Added: 0006893
2016-11-09 12:55PovelitelStatusfeedback => assigned
2016-12-12 18:27WarmongerNote Added: 0006941
2016-12-12 18:29WarmongerNote Edited: 0006941bug_revision_view_page.php?bugnote_id=6941#r3314
2016-12-12 18:31WarmongerNote Edited: 0006941bug_revision_view_page.php?bugnote_id=6941#r3315
2016-12-12 19:00WarmongerNote Added: 0006942
2016-12-12 20:39WarmongerNote Added: 0006943
2016-12-12 20:39WarmongerStatusassigned => resolved
2016-12-12 20:39WarmongerFixed in Version0.97 => 1.next
2016-12-12 20:39WarmongerResolutionreopened => fixed
2016-12-12 20:39WarmongerSeverityminor => major
2016-12-13 07:46PovelitelNote Added: 0006944
2022-04-12 11:18PovelitelStatusresolved => closed

Notes
(0004479)
Povelitel   
2014-02-15 15:23   
Check somebody. In sod turn few second.

Vcmi ~ 5 minute

very strange
(0004480)
Warmonger   
2014-02-15 17:08   
Could improve when 0001696 is implemented.
(0005222)
Warmonger   
2014-12-20 11:03   
All "long AI turn" issues should be fixed in 0.97.
(0005278)
Povelitel   
2014-12-25 10:19   
not really. this map is still long
(0005314)
Povelitel   
2015-01-04 22:56   
and now game aborted. just closed. 1 day - end turn. 0.97b
(add logs)
(0006454)
SXX   
2016-02-25 06:52   
This one is still slow as hell and problem is somewhere in sector map code.
(0006455)
SXX   
2016-02-25 06:55   
In SectorMap::exploreNewSector toVisit slowly growing to extreme size.
(0006549)
SXX   
2016-08-11 08:24   
(edited on: 2016-08-11 08:25)
@Warmonger can you please share you thoughts why exactly this one appear?
Also how you wanted to fix it after having patrol in place?

I'll be happy to work on this one and I now understand ideas behind SectorMap more or less, but I still wonder what solution you seen for this bug.
(0006550)
Warmonger   
2016-08-11 08:52   
With patrol implemented at pathfinder level AI finds tiles and objects beyond patrol radius inaccessible, so it shuld not process it at all. This can be the case on some maps where AI has fixed radius but knows entire map, for eg. via Skyship.
(0006551)
SXX   
2016-08-11 09:28   
(edited on: 2016-08-11 09:31)
Yep that's true, but sector map memory usage shouldn't grow until it's crash. Right?
I just thought you checked the map and had ideas why it's stay in infinite loop.
(0006893)
Povelitel   
2016-11-09 12:55   
add map, too memory leak
(0006941)
Warmonger   
2016-12-12 18:27   
(edited on: 2016-12-12 18:31)
On map Paragon Tan and Teal player give "bad allocation" error. They are allies, but to my suprise don't have acess to Skyship.
(0006942)
Warmonger   
2016-12-12 19:00   
I think I got it - retreiveTileN returns "unsigned char" and there are more than 255 sectors on the map.
(0006943)
Warmonger   
2016-12-12 20:39   
Fixed in https://github.com/vcmi/vcmi/commit/27ff9efd4bda45ae85896d99f695a7d485e02ea6 [^]
(0006944)
Povelitel   
2016-12-13 07:46   
Very cool! It's my dream pass map Paragon on vcmi. Will test!