0001697: Starting options and initial options won't be deleted from memory - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001697

VCMI

Mechanics - Adventure Map

public

2014-02-09 16:17

2023-11-28 14:06

Reporter

beegee

Assigned To

SXX

Priority

normal

Severity

major

Reproducibility

have not tried

Status

resolved

Resolution

fixed

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001697: Starting options and initial options won't be deleted from memory

Description

Starting options and initial options won't be deleted from memory after CGamestate has been deleted. When that options won't be deleted, the campaign state information won't be freed from memory too. Campaign state contains crossover hero instances (with stack data and more) which won't be freed as well.

This point affects internal stuff of game engine and can't be tested by a tester.

Additional Information

Destructor of CGameState
//delete scenarioOps; //TODO: fix for loading ind delete
//delete initialOpts;

Tags

No tags attached.

Relationships

Notes
(0004458) Tow (developer) 2014-02-09 22:21	So it is. Deep copy of hero brings quite a number of other objects, like CHero, CCreate, CArtifact and whatever is reachable. Still, rather than fix these issues one by one (there's likely quite a number of various leaks) and bother with manual memory management, I would like to see a bigger update introducing smart pointers (with a a few rules to avoid cycles), so the issue will be properly gone for good. Still, this is blocked by the limitation of our serializer.

(0008872) Ivan (developer) 2023-11-28 14:06	Fixed in 1.4

Issue History
Date Modified	Username	Field	Change
2014-02-09 16:17	beegee	New Issue
2014-02-09 16:22	beegee	Summary	for Developers: Starting options and initial options won't be deleted from memory => Starting options and initial options won't be deleted from memory
2014-02-09 16:22	beegee	Description Updated	View Revisions
2014-02-09 22:21	Tow	Note Added: 0004458
2016-08-28 03:49	SXX	Assigned To	=> SXX
2016-08-28 03:49	SXX	Status	new => assigned
2023-11-28 14:06	Ivan	Note Added: 0008872
2023-11-28 14:06	Ivan	Status	assigned => resolved
2023-11-28 14:06	Ivan	Resolution	open => fixed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team