0001237: Game crashed when i try load game

(0003496)
Tow (developer)
2013-04-20 11:43

Could you provide the savegame that causes VCMI to crash?

(0003504)
Hardy (reporter)
2013-04-21 17:26

Same crash here :( I open the file "VCMI_client.exe" and it crash, can't open the game.

Windows XP with VCMI v0.92

(0003505)
Tow (developer)
2013-04-21 18:09

@Hardy
Could you provide the savegame that causes VCMI to crash?
(particularly, both the *.vcgm1 and *.vsgm1 files)

This issue may have been fixed, but I'd like to confirm that it is indeed that one.

(0003517)
Hardy (reporter)
2013-04-23 16:01

It crashed on the intro "3DO", so there aren't the savegame.

here is my image I has captured
http://i.upanh.com/rtvujm [^]

(0003526)
Tow (developer)
2013-04-25 17:01

The link you provided does not work for me.
If it crashed on starting, the apparently it is a different issue. I believe the author meant crash on loading a saved game, not opening the client.

(0003560)
Zamolxis (viewer)
2013-05-27 10:11

@Hardy: I can't open the image, but I did experience a crash at start in the beginning due to a conflict in directory structure/content (based on the error I got in client). I deleted completely the "config" and "Mods" directories, and re-copied them from the release package, and then it was all fine.

@Draqun/Tow: I had a one-time crash at load after the following actions: started game in 800x (default) resolution, opened map, saved, changed resolution, main menu > load game, trying to load the game I just saved. I couldn't force a crash as the client window was frozen as well; and I couldn't reproduce it afterwards, so I'm not sure if it's related. If it happens again I'll take screenshots and give more details (if I identify a pattern).

(0003569)
Zamolxis (viewer)
2013-05-27 14:23
edited on: 2013-05-27 14:25

@Tow: I'm adding screenshot + save + logs from another crash at load. This time I didn't change the resolution before, but behavior was the same: everything including the client froze (blurred out), so I couldn't even access the client to force a crashdump.

It's only second occurrence, and I can't reproduce it, so it seems quite random.

(0003589)
Zamolxis (viewer)
2013-05-29 08:44
edited on: 2013-05-29 09:06

I think I found this one. It's not related to resolution or any game action (so I need to change 0001097 back). It's the following:
- Open game & save
- Load game > Single Scenario : if the you try to load the first game in the list (usually the one you just saved in my case), the game crashes.

In my case the above is now always reproducible. But I'm attaching new screenshot & crashdump just in case (you can delete them if irrelevant)

NOTE: You HAVE TO first save, then load (not just load at start) to reproduce. I guess saving changes something in the settings or file structure, which then triggers the bug when you try to load. Perhaps the fact that the newly saved game is placed on top of the menu list, but maybe the move is not correctly logged somewhere else...?

EDIT: If relevant at all, my Maps folder has only the VCMI_Tests_2012 map, and my Saved games list is pretty small and only has saves of this map. Let me know if you need any other details if you cannot reproduce.

(0003601)
Tow (developer)
2013-05-30 12:17

I believe the scenario here is:
1) Save a game as a new file
2) Load the same game without restarting VCMI

Issue is with the filesystem. In CClient::loadGame we have:

auto clientSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::CLIENT_SAVEGAME));
auto controlServerSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::SERVER_SAVEGAME));

The second line fails even the file is present. Apparently filesystem is not updated and doesn't notice that a new file appeared. (I am puzzled though, why it works with the client save file?)

(0003602)
Ivan (developer)
2013-05-30 14:57

Yes. All FS data is static and initialized on startup. Originally needed to solve case-sensivity mismatches on Linux.

Client savegame works because of CResourceHandler::get()->createResource() call (or something similar).
Probably similar call to create entry for server savegame is missing.

Possible problem - server savegame file will be created by both client and server (as part of this call) and removing file creation may break FS. Not sure what's the best approach here.

(0003603)
Tow (developer)
2013-05-30 15:08

We certainly don't want to create both resources on both client and server.

Can we have some method allowing us to force FileSystem to rescan a particular location for new files? Then we could just call it with location localPath + "Games/" before attempting loading the game.

(0003604)
Ivan (developer)
2013-05-30 15:48

Full update may not be trivial with current structure (map that contains data from all loaders).

More precise check for server savegame somewhere in loading should be easy though. Will fix.

(0003605)
Ivan (developer)
2013-05-30 16:26

Should be fixed, rev 3396

Issue History
Date Modified	Username	Field	Change
2013-03-10 15:08	Draqun	New Issue
2013-03-10 15:08	Draqun	File Added: VCMI_client.exe_crashinfo.dmp
2013-04-20 11:43	Tow	Note Added: 0003496
2013-04-20 11:43	Tow	Assigned To	=> Tow
2013-04-20 11:43	Tow	Status	new => feedback
2013-04-21 17:26	Hardy	Note Added: 0003504
2013-04-21 18:09	Tow	Note Added: 0003505
2013-04-23 16:01	Hardy	Note Added: 0003517
2013-04-25 17:01	Tow	Note Added: 0003526
2013-05-27 10:11	Zamolxis	Note Added: 0003560
2013-05-27 14:23	Zamolxis	Note Added: 0003569
2013-05-27 14:23	Zamolxis	Summary	Game Crashed => Game crashed when i try load game
2013-05-27 14:25	Zamolxis	Note Edited: 0003569	View Revisions
2013-05-27 14:26	Zamolxis	File Added: 2013-05-27_CrashAtLoad.jpg
2013-05-27 14:27	Zamolxis	File Added: 2013-05-27_CrashAtLoad-save+logs.7z
2013-05-29 08:44	Zamolxis	Note Added: 0003589
2013-05-29 08:45	Zamolxis	Reproducibility	sometimes => always
2013-05-29 08:45	Zamolxis	Status	feedback => confirmed
2013-05-29 08:45	Zamolxis	File Added: 2013-05-29_CrashAtLoad.jpg
2013-05-29 08:45	Zamolxis	File Added: 2013-05-29_CrashAtLoad.7z
2013-05-29 08:55	Zamolxis	Status	confirmed => feedback
2013-05-29 09:00	Zamolxis	Note Edited: 0003589	View Revisions
2013-05-29 09:06	Zamolxis	Note Edited: 0003589	View Revisions
2013-05-30 12:17	Tow	Note Added: 0003601
2013-05-30 12:17	Tow	Assigned To	Tow => Ivan
2013-05-30 12:17	Tow	Status	feedback => assigned
2013-05-30 14:57	Ivan	Note Added: 0003602
2013-05-30 15:08	Tow	Note Added: 0003603
2013-05-30 15:48	Ivan	Note Added: 0003604
2013-05-30 16:26	Ivan	Note Added: 0003605
2013-05-30 16:26	Ivan	Status	assigned => resolved
2013-05-30 16:26	Ivan	Fixed in Version	=> 0.93
2013-05-30 16:26	Ivan	Resolution	open => fixed
2014-05-30 17:43	beegee	Status	resolved => closed

Notes
(0003496) Tow (developer) 2013-04-20 11:43	Could you provide the savegame that causes VCMI to crash?

(0003504) Hardy (reporter) 2013-04-21 17:26	Same crash here :( I open the file "VCMI_client.exe" and it crash, can't open the game. Windows XP with VCMI v0.92

(0003505) Tow (developer) 2013-04-21 18:09	@Hardy Could you provide the savegame that causes VCMI to crash? (particularly, both the .vcgm1 and .vsgm1 files) This issue may have been fixed, but I'd like to confirm that it is indeed that one.

(0003517) Hardy (reporter) 2013-04-23 16:01	It crashed on the intro "3DO", so there aren't the savegame. here is my image I has captured http://i.upanh.com/rtvujm [^]

(0003526) Tow (developer) 2013-04-25 17:01	The link you provided does not work for me. If it crashed on starting, the apparently it is a different issue. I believe the author meant crash on loading a saved game, not opening the client.

(0003560) Zamolxis (viewer) 2013-05-27 10:11	@Hardy: I can't open the image, but I did experience a crash at start in the beginning due to a conflict in directory structure/content (based on the error I got in client). I deleted completely the "config" and "Mods" directories, and re-copied them from the release package, and then it was all fine. @Draqun/Tow: I had a one-time crash at load after the following actions: started game in 800x (default) resolution, opened map, saved, changed resolution, main menu > load game, trying to load the game I just saved. I couldn't force a crash as the client window was frozen as well; and I couldn't reproduce it afterwards, so I'm not sure if it's related. If it happens again I'll take screenshots and give more details (if I identify a pattern).

(0003569) Zamolxis (viewer) 2013-05-27 14:23 edited on: 2013-05-27 14:25	@Tow: I'm adding screenshot + save + logs from another crash at load. This time I didn't change the resolution before, but behavior was the same: everything including the client froze (blurred out), so I couldn't even access the client to force a crashdump. It's only second occurrence, and I can't reproduce it, so it seems quite random.

(0003589) Zamolxis (viewer) 2013-05-29 08:44 edited on: 2013-05-29 09:06	I think I found this one. It's not related to resolution or any game action (so I need to change 0001097 back). It's the following: - Open game & save - Load game > Single Scenario : if the you try to load the first game in the list (usually the one you just saved in my case), the game crashes. In my case the above is now always reproducible. But I'm attaching new screenshot & crashdump just in case (you can delete them if irrelevant) NOTE: You HAVE TO first save, then load (not just load at start) to reproduce. I guess saving changes something in the settings or file structure, which then triggers the bug when you try to load. Perhaps the fact that the newly saved game is placed on top of the menu list, but maybe the move is not correctly logged somewhere else...? EDIT: If relevant at all, my Maps folder has only the VCMI_Tests_2012 map, and my Saved games list is pretty small and only has saves of this map. Let me know if you need any other details if you cannot reproduce.

(0003601) Tow (developer) 2013-05-30 12:17	I believe the scenario here is: 1) Save a game as a new file 2) Load the same game without restarting VCMI Issue is with the filesystem. In CClient::loadGame we have: auto clientSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::CLIENT_SAVEGAME)); auto controlServerSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::SERVER_SAVEGAME)); The second line fails even the file is present. Apparently filesystem is not updated and doesn't notice that a new file appeared. (I am puzzled though, why it works with the client save file?)

(0003602) Ivan (developer) 2013-05-30 14:57	Yes. All FS data is static and initialized on startup. Originally needed to solve case-sensivity mismatches on Linux. Client savegame works because of CResourceHandler::get()->createResource() call (or something similar). Probably similar call to create entry for server savegame is missing. Possible problem - server savegame file will be created by both client and server (as part of this call) and removing file creation may break FS. Not sure what's the best approach here.

(0003603) Tow (developer) 2013-05-30 15:08	We certainly don't want to create both resources on both client and server. Can we have some method allowing us to force FileSystem to rescan a particular location for new files? Then we could just call it with location localPath + "Games/" before attempting loading the game.

(0003604) Ivan (developer) 2013-05-30 15:48	Full update may not be trivial with current structure (map that contains data from all loaders). More precise check for server savegame somewhere in loading should be easy though. Will fix.

(0003605) Ivan (developer) 2013-05-30 16:26	Should be fixed, rev 3396

Relationships