MantisBT - VCMI
View Issue Details
0001237VCMIMechanics - Otherpublic2013-03-10 15:082014-05-30 17:43
Draqun 
Ivan 
normalcrashalways
closedfixed 
WindowsWindows 77601
0.92 
0.93 
0001237: Game crashed when i try load game
Game crashed when i try load game. I enclose game dump.
No tags attached.
? VCMI_client.exe_crashinfo.dmp (1,387,251) 2013-03-10 15:08
https://bugs.vcmi.eu/file_download.php?file_id=1229&type=bug
jpg 2013-05-27_CrashAtLoad.jpg (134,683) 2013-05-27 14:26
https://bugs.vcmi.eu/file_download.php?file_id=1273&type=bug
jpg

7z 2013-05-27_CrashAtLoad-save+logs.7z (165,219) 2013-05-27 14:27
https://bugs.vcmi.eu/file_download.php?file_id=1274&type=bug
jpg 2013-05-29_CrashAtLoad.jpg (106,313) 2013-05-29 08:45
https://bugs.vcmi.eu/file_download.php?file_id=1280&type=bug
jpg

7z 2013-05-29_CrashAtLoad.7z (187,014) 2013-05-29 08:45
https://bugs.vcmi.eu/file_download.php?file_id=1281&type=bug
Issue History
2013-03-10 15:08DraqunNew Issue
2013-03-10 15:08DraqunFile Added: VCMI_client.exe_crashinfo.dmp
2013-04-20 11:43TowNote Added: 0003496
2013-04-20 11:43TowAssigned To => Tow
2013-04-20 11:43TowStatusnew => feedback
2013-04-21 17:26HardyNote Added: 0003504
2013-04-21 18:09TowNote Added: 0003505
2013-04-23 16:01HardyNote Added: 0003517
2013-04-25 17:01TowNote Added: 0003526
2013-05-27 10:11ZamolxisNote Added: 0003560
2013-05-27 14:23ZamolxisNote Added: 0003569
2013-05-27 14:23ZamolxisSummaryGame Crashed => Game crashed when i try load game
2013-05-27 14:25ZamolxisNote Edited: 0003569bug_revision_view_page.php?bugnote_id=3569#r2205
2013-05-27 14:26ZamolxisFile Added: 2013-05-27_CrashAtLoad.jpg
2013-05-27 14:27ZamolxisFile Added: 2013-05-27_CrashAtLoad-save+logs.7z
2013-05-29 08:44ZamolxisNote Added: 0003589
2013-05-29 08:45ZamolxisReproducibilitysometimes => always
2013-05-29 08:45ZamolxisStatusfeedback => confirmed
2013-05-29 08:45ZamolxisFile Added: 2013-05-29_CrashAtLoad.jpg
2013-05-29 08:45ZamolxisFile Added: 2013-05-29_CrashAtLoad.7z
2013-05-29 08:55ZamolxisStatusconfirmed => feedback
2013-05-29 09:00ZamolxisNote Edited: 0003589bug_revision_view_page.php?bugnote_id=3589#r2215
2013-05-29 09:06ZamolxisNote Edited: 0003589bug_revision_view_page.php?bugnote_id=3589#r2216
2013-05-30 12:17TowNote Added: 0003601
2013-05-30 12:17TowAssigned ToTow => Ivan
2013-05-30 12:17TowStatusfeedback => assigned
2013-05-30 14:57IvanNote Added: 0003602
2013-05-30 15:08TowNote Added: 0003603
2013-05-30 15:48IvanNote Added: 0003604
2013-05-30 16:26IvanNote Added: 0003605
2013-05-30 16:26IvanStatusassigned => resolved
2013-05-30 16:26IvanFixed in Version => 0.93
2013-05-30 16:26IvanResolutionopen => fixed
2014-05-30 17:43beegeeStatusresolved => closed

Notes
(0003496)
Tow   
2013-04-20 11:43   
Could you provide the savegame that causes VCMI to crash?
(0003504)
Hardy   
2013-04-21 17:26   
Same crash here :( I open the file "VCMI_client.exe" and it crash, can't open the game.

Windows XP with VCMI v0.92
(0003505)
Tow   
2013-04-21 18:09   
@Hardy
Could you provide the savegame that causes VCMI to crash?
(particularly, both the *.vcgm1 and *.vsgm1 files)

This issue may have been fixed, but I'd like to confirm that it is indeed that one.
(0003517)
Hardy   
2013-04-23 16:01   
It crashed on the intro "3DO", so there aren't the savegame.

here is my image I has captured
http://i.upanh.com/rtvujm [^]
(0003526)
Tow   
2013-04-25 17:01   
The link you provided does not work for me.
If it crashed on starting, the apparently it is a different issue. I believe the author meant crash on loading a saved game, not opening the client.
(0003560)
Zamolxis   
2013-05-27 10:11   
@Hardy: I can't open the image, but I did experience a crash at start in the beginning due to a conflict in directory structure/content (based on the error I got in client). I deleted completely the "config" and "Mods" directories, and re-copied them from the release package, and then it was all fine.

@Draqun/Tow: I had a one-time crash at load after the following actions: started game in 800x (default) resolution, opened map, saved, changed resolution, main menu > load game, trying to load the game I just saved. I couldn't force a crash as the client window was frozen as well; and I couldn't reproduce it afterwards, so I'm not sure if it's related. If it happens again I'll take screenshots and give more details (if I identify a pattern).
(0003569)
Zamolxis   
2013-05-27 14:23   
(edited on: 2013-05-27 14:25)
@Tow: I'm adding screenshot + save + logs from another crash at load. This time I didn't change the resolution before, but behavior was the same: everything including the client froze (blurred out), so I couldn't even access the client to force a crashdump.

It's only second occurrence, and I can't reproduce it, so it seems quite random.

(0003589)
Zamolxis   
2013-05-29 08:44   
(edited on: 2013-05-29 09:06)
I think I found this one. It's not related to resolution or any game action (so I need to change 0001097 back). It's the following:
- Open game & save
- Load game > Single Scenario : if the you try to load the first game in the list (usually the one you just saved in my case), the game crashes.

In my case the above is now always reproducible. But I'm attaching new screenshot & crashdump just in case (you can delete them if irrelevant)

NOTE: You HAVE TO first save, then load (not just load at start) to reproduce. I guess saving changes something in the settings or file structure, which then triggers the bug when you try to load. Perhaps the fact that the newly saved game is placed on top of the menu list, but maybe the move is not correctly logged somewhere else...?

EDIT: If relevant at all, my Maps folder has only the VCMI_Tests_2012 map, and my Saved games list is pretty small and only has saves of this map. Let me know if you need any other details if you cannot reproduce.

(0003601)
Tow   
2013-05-30 12:17   
I believe the scenario here is:
1) Save a game as a new file
2) Load the same game without restarting VCMI

Issue is with the filesystem. In CClient::loadGame we have:

auto clientSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::CLIENT_SAVEGAME));
auto controlServerSaveName = CResourceHandler::get()->getResourceName(ResourceID(fname, EResType::SERVER_SAVEGAME));

The second line fails even the file is present. Apparently filesystem is not updated and doesn't notice that a new file appeared. (I am puzzled though, why it works with the client save file?)
(0003602)
Ivan   
2013-05-30 14:57   
Yes. All FS data is static and initialized on startup. Originally needed to solve case-sensivity mismatches on Linux.

Client savegame works because of CResourceHandler::get()->createResource() call (or something similar).
Probably similar call to create entry for server savegame is missing.

Possible problem - server savegame file will be created by both client and server (as part of this call) and removing file creation may break FS. Not sure what's the best approach here.
(0003603)
Tow   
2013-05-30 15:08   
We certainly don't want to create both resources on both client and server.

Can we have some method allowing us to force FileSystem to rescan a particular location for new files? Then we could just call it with location localPath + "Games/" before attempting loading the game.
(0003604)
Ivan   
2013-05-30 15:48   
Full update may not be trivial with current structure (map that contains data from all loaders).

More precise check for server savegame somewhere in loading should be easy though. Will fix.
(0003605)
Ivan   
2013-05-30 16:26   
Should be fixed, rev 3396