0001154: Random crash when AI tries to recruit hero

(0003227)
beegee (developer)
2012-12-04 19:10

For me it looks like that 0001149 is not related to this mantis call. More on this in 0001149.
I couldn't confirm this bug. AI can create as many heroes as it wants to have:)

(0003233)
Warmonger (administrator)
2012-12-05 17:37
edited on: 2012-12-05 17:38

For me it crashes especially on large maps, which may be caused by two reasons I can think of:

1. Race condition - map is processed slower than on small maps
2. Not enough heroes avaliable to recruit.

Check attached map.

(0003244)
Ivan (developer)
2012-12-12 13:45
edited on: 2012-12-12 14:09

I think I got this (or similar) issue 1-2 times without "help" from AI on the first day of game.

Sometimes starting heroes army is out of sync with server. So far happened only with lvl-1 creature specialists and only when hero in options was set to random.

Will try to reproduce it but it occurs quite rarely for me.

EDIT:
Wow. Logging in CGHeroInstance::initArmy() shows that client and server give completely different armies. Will try to fix.

(0003245)
Ivan (developer)
2012-12-12 14:56

I definitely fixed out of sync issue. And I may have fixed original bug - please check.

(0003248)
Warmonger (administrator)
2012-12-12 17:36

Yeah, it work great now :)

Issue History
Date Modified	Username	Field	Change
2012-12-01 08:38	Warmonger	New Issue
2012-12-01 08:38	Warmonger	Status	new => assigned
2012-12-01 08:38	Warmonger	Assigned To	=> beegee
2012-12-01 08:39	Warmonger	Relationship added	related to 0001149
2012-12-04 19:10	beegee	Note Added: 0003227
2012-12-05 17:37	Warmonger	Note Added: 0003233
2012-12-05 17:38	Warmonger	File Added: CoTD 252x252 001.h3m
2012-12-05 17:38	Warmonger	Note Edited: 0003233	View Revisions
2012-12-12 13:45	Ivan	Note Added: 0003244
2012-12-12 14:09	Ivan	Note Edited: 0003244	View Revisions
2012-12-12 14:09	Ivan	Assigned To	beegee => Ivan
2012-12-12 14:56	Ivan	Note Added: 0003245
2012-12-12 14:56	Ivan	Status	assigned => feedback
2012-12-12 17:36	Warmonger	Note Added: 0003248
2012-12-12 17:36	Warmonger	Status	feedback => assigned
2012-12-12 17:36	Warmonger	Status	assigned => resolved
2012-12-12 17:36	Warmonger	Fixed in Version	=> 0.91
2012-12-12 17:36	Warmonger	Resolution	open => fixed
2014-05-30 17:41	beegee	Status	resolved => closed

Notes
(0003227) beegee (developer) 2012-12-04 19:10	For me it looks like that 0001149 is not related to this mantis call. More on this in 0001149. I couldn't confirm this bug. AI can create as many heroes as it wants to have:)

(0003233) Warmonger (administrator) 2012-12-05 17:37 edited on: 2012-12-05 17:38	For me it crashes especially on large maps, which may be caused by two reasons I can think of: 1. Race condition - map is processed slower than on small maps 2. Not enough heroes avaliable to recruit. Check attached map.

(0003244) Ivan (developer) 2012-12-12 13:45 edited on: 2012-12-12 14:09	I think I got this (or similar) issue 1-2 times without "help" from AI on the first day of game. Sometimes starting heroes army is out of sync with server. So far happened only with lvl-1 creature specialists and only when hero in options was set to random. Will try to reproduce it but it occurs quite rarely for me. EDIT: Wow. Logging in CGHeroInstance::initArmy() shows that client and server give completely different armies. Will try to fix.

(0003245) Ivan (developer) 2012-12-12 14:56	I definitely fixed out of sync issue. And I may have fixed original bug - please check.

(0003248) Warmonger (administrator) 2012-12-12 17:36	Yeah, it work great now :)