0000629: Cann't compile VCMI [trunk r1834]

(0001414)
ruppertus (reporter)
2010-11-17 21:42

I've reproduced that VCMI can't be compiled under linux [trunk r1865].

CAdvmapInterface.cpp:841: warning: taking address of temporary
CAdvmapInterface.cpp: In member function ‘virtual void CAdvMapInt::show(SDL_Surface*)’:
CAdvmapInterface.cpp:1403: warning: suggest parentheses around ‘&&’ within ‘||’
CAdvmapInterface.cpp: In member function ‘void CAdvMapInt::tileHovered(const int3&)’:
CAdvmapInterface.cpp:2006: warning: unused variable ‘shipyard’
CXX vcmiclient-CAnimation.o
CAnimation.cpp: In constructor ‘CDefFile::CDefFile(std::string)’:
CAnimation.cpp:335: error: no matching function for call to ‘max(unsigned int, size_t)’
make[1]: *** [vcmiclient-CAnimation.o] Error 1
make: *** [all-recursive] Error 1

(0001423)
Ivan (developer)
2010-11-18 13:36

Strange. That part worked fine for me. Try rev 1866 - should be fixed now.

(0001451)
Zamolxis (viewer)
2010-11-22 17:33
edited on: 2010-11-22 17:38

@o01eg/Ivan: is this still an issue or can we move it to Resolved?

(0001454)
o01eg (reporter)
2010-11-22 19:23

Nothing changed (r1867, media-video/ffmpeg-0.6):
  CXX vcmiclient-CVideoHandler.o
In file included from /usr/include/libavutil/avutil.h:81,
                 from /usr/include/libavcodec/avcodec.h:30,
                 from /usr/include/libavformat/avformat.h:56,
                 from ../hch/CVideoHandler.cpp:561:
/usr/include/libavutil/common.h: In function ‘int32_t av_clipl_int32(int64_t)’:
/usr/include/libavutil/common.h:154: error: ‘UINT64_C’ was not declared in this scope
../hch/CVideoHandler.cpp: In member function ‘bool CVideoPlayer::nextFrame()’:
../hch/CVideoHandler.cpp:785: warning: ‘int avcodec_decode_video(AVCodecContext*, AVFrame*, int*, const uint8_t*, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:3452)
../hch/CVideoHandler.cpp:786: warning: ‘int avcodec_decode_video(AVCodecContext*, AVFrame*, int*, const uint8_t*, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:3452)
make[1]: *** [vcmiclient-CVideoHandler.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/tmp/vcmi/client'
make: *** [all-recursive] Error 1

(0001455)
Ivan (developer)
2010-11-22 22:16

I've fixed only error from note by ruppertus (it completely separate) - but original problem is still here

(0001457)
o01eg (reporter)
2010-11-23 03:19

Did you try to add -D__STDC_CONSTANT_MACROS into CXXFLAGS? When I do this vcmi compiles without this error.

(0001471)
Ivan (developer)
2011-01-01 20:33

Fixed in rev 1907

Issue History
Date Modified	Username	Field	Change
2010-10-31 08:42	o01eg	New Issue
2010-11-06 20:31	Warmonger	Relationship added	related to 0000630
2010-11-17 21:42	ruppertus	Note Added: 0001414
2010-11-18 13:36	Ivan	Note Added: 0001423
2010-11-22 17:33	Zamolxis	Note Added: 0001451
2010-11-22 17:33	Zamolxis	Assigned To	=> Zamolxis
2010-11-22 17:33	Zamolxis	Status	new => feedback
2010-11-22 17:38	Zamolxis	Note Edited: 0001451	View Revisions
2010-11-22 17:39	Zamolxis	Status	feedback => assigned
2010-11-22 17:39	Zamolxis	Assigned To	Zamolxis => Ivan
2010-11-22 19:23	o01eg	Note Added: 0001454
2010-11-22 22:16	Ivan	Note Added: 0001455
2010-11-22 22:17	Ivan	Assigned To	Ivan =>
2010-11-22 22:17	Ivan	Status	assigned => new
2010-11-23 03:19	o01eg	Note Added: 0001457
2011-01-01 20:33	Ivan	Note Added: 0001471
2011-01-01 20:33	Ivan	Status	new => resolved
2011-01-01 20:33	Ivan	Fixed in Version	=> 0.89
2011-01-01 20:33	Ivan	Resolution	open => fixed
2011-01-01 20:33	Ivan	Assigned To	=> Ivan
2011-05-31 01:06	Zamolxis	Status	resolved => closed

Notes
(0001414) ruppertus (reporter) 2010-11-17 21:42	I've reproduced that VCMI can't be compiled under linux [trunk r1865]. CAdvmapInterface.cpp:841: warning: taking address of temporary CAdvmapInterface.cpp: In member function ‘virtual void CAdvMapInt::show(SDL_Surface)’: CAdvmapInterface.cpp:1403: warning: suggest parentheses around ‘&&’ within ‘\|\|’ CAdvmapInterface.cpp: In member function ‘void CAdvMapInt::tileHovered(const int3&)’: CAdvmapInterface.cpp:2006: warning: unused variable ‘shipyard’ CXX vcmiclient-CAnimation.o CAnimation.cpp: In constructor ‘CDefFile::CDefFile(std::string)’: CAnimation.cpp:335: error: no matching function for call to ‘max(unsigned int, size_t)’ make[1]: [vcmiclient-CAnimation.o] Error 1 make: * [all-recursive] Error 1

(0001423) Ivan (developer) 2010-11-18 13:36	Strange. That part worked fine for me. Try rev 1866 - should be fixed now.

(0001451) Zamolxis (viewer) 2010-11-22 17:33 edited on: 2010-11-22 17:38	@o01eg/Ivan: is this still an issue or can we move it to Resolved?

(0001454) o01eg (reporter) 2010-11-22 19:23	Nothing changed (r1867, media-video/ffmpeg-0.6): CXX vcmiclient-CVideoHandler.o In file included from /usr/include/libavutil/avutil.h:81, from /usr/include/libavcodec/avcodec.h:30, from /usr/include/libavformat/avformat.h:56, from ../hch/CVideoHandler.cpp:561: /usr/include/libavutil/common.h: In function ‘int32_t av_clipl_int32(int64_t)’: /usr/include/libavutil/common.h:154: error: ‘UINT64_C’ was not declared in this scope ../hch/CVideoHandler.cpp: In member function ‘bool CVideoPlayer::nextFrame()’: ../hch/CVideoHandler.cpp:785: warning: ‘int avcodec_decode_video(AVCodecContext, AVFrame, int, const uint8_t, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:3452) ../hch/CVideoHandler.cpp:786: warning: ‘int avcodec_decode_video(AVCodecContext, AVFrame, int, const uint8_t, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:3452) make[1]: * [vcmiclient-CVideoHandler.o] Error 1 make[1]: * Waiting for unfinished jobs.... make[1]: Leaving directory `/tmp/vcmi/client' make: *** [all-recursive] Error 1

(0001455) Ivan (developer) 2010-11-22 22:16	I've fixed only error from note by ruppertus (it completely separate) - but original problem is still here

(0001457) o01eg (reporter) 2010-11-23 03:19	Did you try to add -D__STDC_CONSTANT_MACROS into CXXFLAGS? When I do this vcmi compiles without this error.

(0001471) Ivan (developer) 2011-01-01 20:33	Fixed in rev 1907