0000568: Crash after battle and/or after visiting Learning Stone

(0001234)
Boulie (reporter)
2010-07-29 11:38
edited on: 2010-07-29 11:52

just to clarify. I played it few times later and everything was ok, also I've made some test with exp in pandora's box and it was ok, too.
So maybe it is only coincidence that it happened during checking Ivan's rev.

EDIT: One more thing. Take a look in txt log at
"System message: Server encountered a problem: There is no stack on 58 tile (no attack)!" it was during comp turn and champions attack. It happened 2 times.
It is more lass connected with http://bugs.vcmi.eu/view.php?id=560. [^]
When I played this battle in MP, I had same situation I attack 2-hex stack with 2-hex stack and attack wasn't possible cause unit couldn't be placed in right position.
"System message: Server encountered a problem: We cannot move this stack to its destination Champions"

It is included in VCMI_client_log no.2 from crashes 0000559: http://bugs.vcmi.eu/file_download.php?file_id=501&type=bug [^]

EDIT2:
And maybe, computer during champions attack, attacked AA from back. But I'm not sure about that. And I don't know if after the crash happened during battle it could be possible to choose skills and go into hero's screen? Crash handler appears in background.

(0001235)
Boulie (reporter)
2010-07-29 12:32
edited on: 2010-07-29 12:55

Added new note cause this is kind of new situation in this case.
Game always crashes if I get into learning stone, in the moment when new sec skill screen should appear.
Load added game, take Gerwulf and go into learning stone near castle
(added screenshot, crash dump files and saved game in MP)

EDIT: I've just added also the map, cause on other maps there is no such a problem.
Run the map in SP and go to learning stone.

(0001245)
Zamolxis (viewer)
2010-07-29 18:09

I updated the Summary, because following the above it seems the bug is more about visiting the Learning Stone (or are they 2 different crash bugs?... hopefully the dumps can clarify).

(0001246)
Ivan (developer)
2010-07-29 19:11
edited on: 2010-07-29 20:44

According to logs these are different crashes:

1)after selecting secondary skills
all levelups have been applied, server crashed after sending message SetSelection
Can't find anything more in the logs. Can someone look for useful info in crash dumps? Don't see a way to use them without Visual Studio

2) learning stone crash
Server crashed during level-up.
This one is weird. I have crash only with savegame - new game on this map is fine.
Crash occurs on changing primary skills - (assert failure on NetPacksLib.cpp:61)
Game can't find bonus representing hero primary skills

Possible serialization issue: values of primary skills in loaded save game are 0-0-1-1 while on 2nd screenshot we see 0-4-1-1

(0001247)
Tow (developer)
2010-07-30 12:01

1)
Dump is meaningless, since there is only client dump not the server one. According to the logs there should be both, so please look for VCMI_server.exe_crashinfo.dmp

2)
Same here (client says it crashes cause server crashed) but this time there is no trace of server crashdump, it must have died silently. Most likely it was that failed assertion.

(0001248)
Ivan (developer)
2010-07-30 12:24

>> Most likely it was that failed assertion.
It was.
You can see that error line on 2nd screenshot:
NetPacksLib.cpp:61 - assert(skill);
skill is pointer to bonus with hero primary skill. Which was not found for some reason

(0001249)
Tow (developer)
2010-07-30 12:28

@Ivan
1)
Server didn't crash after sending SetSelection. Look in logs for "Disaster happened". It crashed in the battle handling thread after sendind resultsApplied I guess. The connection-handling thread was probably still running for some time, before whole server died.
Very strange.

(0001250)
Tow (developer)
2010-07-30 13:05

2)
It's not serialization issue, it must be some kind of desync between server and client. On client we have correct values of primskills. On server for some reasons that base primskill bonuses are lost. That leads both to crash and defected save file (when saving, gamestate is taken from server only). The question is, when and why that bonuses get erased from the list.

(0001252)
majaczek (reporter)
2010-07-30 13:29

maybe a hero with 0 Attack or 0 Defense?
if so, it makes sense that not affecting bonus was removed

(0001253)
Tow (developer)
2010-07-30 13:54

Hero with 0 Attack has bonus of value 0.

(0001254)
majaczek (reporter)
2010-07-30 16:48

but bonus handler could filter the bonus due to teoretical meaning nothing, because it doesn't know elsewhere is needed?

(0001361)
Warmonger (administrator)
2010-10-27 09:05

Most likely fixed in r1827

(0001363)
Tow (developer)
2010-10-27 13:27

This issue doesn't have anything to do with r1827 (especially since problem is from 0.81d), however since it's old and not reproducible I'll close it for now.

Issue History
Date Modified	Username	Field	Change
2010-07-29 07:54	Boulie	New Issue
2010-07-29 07:54	Boulie	Status	new => assigned
2010-07-29 07:54	Boulie	Assigned To	=> Tow dragon
2010-07-29 07:54	Boulie	File Added: crash after gaining sec skills.jpg
2010-07-29 07:54	Boulie	File Added: crash after gaining sec skills.zip
2010-07-29 11:01	Tow dragon	Assigned To	Tow dragon => Ivan
2010-07-29 11:38	Boulie	Note Added: 0001234
2010-07-29 11:46	Boulie	Note Edited: 0001234	View Revisions
2010-07-29 11:47	Boulie	Note Edited: 0001234	View Revisions
2010-07-29 11:48	Boulie	Note Edited: 0001234	View Revisions
2010-07-29 11:52	Boulie	Note Edited: 0001234	View Revisions
2010-07-29 12:32	Boulie	Note Added: 0001235
2010-07-29 12:32	Boulie	Note Edited: 0001235	View Revisions
2010-07-29 12:32	Boulie	File Added: crash after get into learning stone.jpg
2010-07-29 12:32	Boulie	File Added: crash after get into learning stone.zip
2010-07-29 12:32	Boulie	File Added: games MP.zip
2010-07-29 12:55	Boulie	Note Edited: 0001235	View Revisions
2010-07-29 12:55	Boulie	File Added: Insanity LH.h3m
2010-07-29 18:09	Zamolxis	Note Added: 0001245
2010-07-29 18:09	Zamolxis	Summary	Crash after battle => Crash after battle and/or after visiting Learning Stone
2010-07-29 19:11	Ivan	Note Added: 0001246
2010-07-29 19:11	Ivan	Note Edited: 0001246	View Revisions
2010-07-29 20:40	Ivan	Note Edited: 0001246	View Revisions
2010-07-29 20:44	Ivan	Note Edited: 0001246	View Revisions
2010-07-30 08:57	Ivan	Assigned To	Ivan =>
2010-07-30 08:58	Ivan	Status	assigned => new
2010-07-30 12:01	Tow	Note Added: 0001247
2010-07-30 12:24	Ivan	Note Added: 0001248
2010-07-30 12:28	Tow	Note Added: 0001249
2010-07-30 13:05	Tow	Note Added: 0001250
2010-07-30 13:29	majaczek	Note Added: 0001252
2010-07-30 13:54	Tow	Note Added: 0001253
2010-07-30 16:48	majaczek	Note Added: 0001254
2010-10-26 14:03	Warmonger	Relationship added	has duplicate 0000628
2010-10-27 09:05	Warmonger	Note Added: 0001361
2010-10-27 09:05	Warmonger	Status	new => resolved
2010-10-27 09:05	Warmonger	Fixed in Version	=> 0.89
2010-10-27 09:05	Warmonger	Resolution	open => fixed
2010-10-27 09:05	Warmonger	Assigned To	=> Warmonger
2010-10-27 13:25	Tow	Relationship deleted	has duplicate 0000628
2010-10-27 13:27	Tow	Note Added: 0001363
2010-10-27 13:27	Tow	Assigned To	Warmonger => Tow
2010-10-27 13:27	Tow	Status	resolved => closed
2010-10-27 13:27	Tow	Resolution	fixed => unable to reproduce
2010-10-27 13:27	Tow	Fixed in Version	0.89 =>

Notes
(0001234) Boulie (reporter) 2010-07-29 11:38 edited on: 2010-07-29 11:52	just to clarify. I played it few times later and everything was ok, also I've made some test with exp in pandora's box and it was ok, too. So maybe it is only coincidence that it happened during checking Ivan's rev. EDIT: One more thing. Take a look in txt log at "System message: Server encountered a problem: There is no stack on 58 tile (no attack)!" it was during comp turn and champions attack. It happened 2 times. It is more lass connected with http://bugs.vcmi.eu/view.php?id=560. [^] When I played this battle in MP, I had same situation I attack 2-hex stack with 2-hex stack and attack wasn't possible cause unit couldn't be placed in right position. "System message: Server encountered a problem: We cannot move this stack to its destination Champions" It is included in VCMI_client_log no.2 from crashes 0000559: http://bugs.vcmi.eu/file_download.php?file_id=501&type=bug [^] EDIT2: And maybe, computer during champions attack, attacked AA from back. But I'm not sure about that. And I don't know if after the crash happened during battle it could be possible to choose skills and go into hero's screen? Crash handler appears in background.

(0001235) Boulie (reporter) 2010-07-29 12:32 edited on: 2010-07-29 12:55	Added new note cause this is kind of new situation in this case. Game always crashes if I get into learning stone, in the moment when new sec skill screen should appear. Load added game, take Gerwulf and go into learning stone near castle (added screenshot, crash dump files and saved game in MP) EDIT: I've just added also the map, cause on other maps there is no such a problem. Run the map in SP and go to learning stone.

(0001245) Zamolxis (viewer) 2010-07-29 18:09	I updated the Summary, because following the above it seems the bug is more about visiting the Learning Stone (or are they 2 different crash bugs?... hopefully the dumps can clarify).

(0001246) Ivan (developer) 2010-07-29 19:11 edited on: 2010-07-29 20:44	According to logs these are different crashes: 1)after selecting secondary skills all levelups have been applied, server crashed after sending message SetSelection Can't find anything more in the logs. Can someone look for useful info in crash dumps? Don't see a way to use them without Visual Studio 2) learning stone crash Server crashed during level-up. This one is weird. I have crash only with savegame - new game on this map is fine. Crash occurs on changing primary skills - (assert failure on NetPacksLib.cpp:61) Game can't find bonus representing hero primary skills Possible serialization issue: values of primary skills in loaded save game are 0-0-1-1 while on 2nd screenshot we see 0-4-1-1

(0001247) Tow (developer) 2010-07-30 12:01	1) Dump is meaningless, since there is only client dump not the server one. According to the logs there should be both, so please look for VCMI_server.exe_crashinfo.dmp 2) Same here (client says it crashes cause server crashed) but this time there is no trace of server crashdump, it must have died silently. Most likely it was that failed assertion.

(0001248) Ivan (developer) 2010-07-30 12:24	>> Most likely it was that failed assertion. It was. You can see that error line on 2nd screenshot: NetPacksLib.cpp:61 - assert(skill); skill is pointer to bonus with hero primary skill. Which was not found for some reason

(0001249) Tow (developer) 2010-07-30 12:28	@Ivan 1) Server didn't crash after sending SetSelection. Look in logs for "Disaster happened". It crashed in the battle handling thread after sendind resultsApplied I guess. The connection-handling thread was probably still running for some time, before whole server died. Very strange.

(0001250) Tow (developer) 2010-07-30 13:05	2) It's not serialization issue, it must be some kind of desync between server and client. On client we have correct values of primskills. On server for some reasons that base primskill bonuses are lost. That leads both to crash and defected save file (when saving, gamestate is taken from server only). The question is, when and why that bonuses get erased from the list.

(0001252) majaczek (reporter) 2010-07-30 13:29	maybe a hero with 0 Attack or 0 Defense? if so, it makes sense that not affecting bonus was removed

(0001253) Tow (developer) 2010-07-30 13:54	Hero with 0 Attack has bonus of value 0.

(0001254) majaczek (reporter) 2010-07-30 16:48	but bonus handler could filter the bonus due to teoretical meaning nothing, because it doesn't know elsewhere is needed?

(0001361) Warmonger (administrator) 2010-10-27 09:05	Most likely fixed in r1827

(0001363) Tow (developer) 2010-10-27 13:27	This issue doesn't have anything to do with r1827 (especially since problem is from 0.81d), however since it's old and not reproducible I'll close it for now.

Relationships