0002790: String identifiers for objects are initialized too late

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002790

VCMI

Mods

public

2017-09-12 07:45

2017-09-12 09:25

Reporter

hkoehler

Assigned To

AVS

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

0.99

Target Version

Fixed in Version

1.next

Summary

0002790: String identifiers for objects are initialized too late

Description

Currently when mod data is loaded, object identifiers like "spell.fireball" become available as part of the loading process. This means e.g. when heroes are loaded, identifiers for new spells may not be available yet, so referencing them, e.g. for hero specialty, becomes impossible (one could use integers, but that's extremely fragile).

Additional Information

Suggested fix: assign identifiers during preload of mods, so that they are all known by the time they are needed for resolving references.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0007279) AVS (administrator) 2017-09-12 09:25	We have CIdentifierStorage::requestIdentifier with functor callbacks to solve such issues. Early identifier assigning (at preload state) might be better solution but it is not a bug and matter of redesign.

Issue History
Date Modified	Username	Field	Change
2017-09-12 07:45	hkoehler	New Issue
2017-09-12 09:25	AVS	Note Added: 0007279
2017-09-12 09:25	AVS	Status	new => closed
2017-09-12 09:25	AVS	Assigned To	=> AVS
2017-09-12 09:25	AVS	Resolution	open => no change required
2017-09-12 09:25	AVS	Fixed in Version	=> 1.next

Site | Forums | Wiki | Slack | GitHub