0002430: Commanders stop gain experience from the battle

(0006788)
Dydzio (developer)
2016-09-30 21:52

Can anybody tell more about commander experience mechanics? When is it granted, how much, are there any factors that can modify experience multiplier etc.?

(0006789)
AVS (administrator)
2016-10-01 02:29

For now commander should receive same exp as hero.

(0006790)
Warmonger (administrator)
2016-10-01 07:15

Castle Commander has permanent +50% experience gain bonus.

(0006797)
Dydzio (developer)
2016-10-01 15:25
edited on: 2016-10-01 16:24

EDIT: CGameHandler code "kills" commander via battle casualties procedure at end of each battle, moreover if commander really dies practically nothing changes - he still appears in battles.

(0006809)
misiokles (reporter)
2016-10-03 06:21

All about WoG's commanders (VCMI commanders are lighter version) are descripe here: http://www.celestialheavens.com/h3maparchives/wog/wogfeatures.html [^]

And please, don't forget about this bug:
http://bugs.vcmi.eu/view.php?id=2439 [^]

(0006810)
Dydzio (developer)
2016-10-03 11:03

Fixed in: https://github.com/vcmi/vcmi/pull/230 [^] and https://github.com/vcmi/vcmi/commit/723734fd04655ec456fb52154073b54e29e759d7 [^]

Extra experience for castle commander not added, as it may be better idea to implement it later via unified commander specialty system. Generally commander code needs more attention, many things are missing for example descriptions for skills or commander revival requirements. For now commander "just works".

Issue History
Date Modified	Username	Field	Change
2016-03-20 10:42	misiokles	New Issue
2016-03-20 18:07	anonymous	Status	new => feedback
2016-03-21 17:30	AVS	Status	feedback => new
2016-09-30 21:52	Dydzio	Note Added: 0006788
2016-09-30 21:52	Dydzio	Assigned To	=> Dydzio
2016-09-30 21:52	Dydzio	Status	new => assigned
2016-09-30 21:53	Dydzio	Status	assigned => feedback
2016-10-01 02:29	AVS	Note Added: 0006789
2016-10-01 07:15	Warmonger	Note Added: 0006790
2016-10-01 08:56	Dydzio	Status	feedback => assigned
2016-10-01 15:25	Dydzio	Note Added: 0006797
2016-10-01 16:12	Dydzio	Note Edited: 0006797	View Revisions
2016-10-01 16:24	Dydzio	Note Edited: 0006797	View Revisions
2016-10-03 06:21	misiokles	Note Added: 0006809
2016-10-03 11:03	Dydzio	Note Added: 0006810
2016-10-03 11:03	Dydzio	Status	assigned => resolved
2016-10-03 11:03	Dydzio	Resolution	open => fixed
2022-04-12 11:19	Povelitel	Status	resolved => closed

Notes
(0006788) Dydzio (developer) 2016-09-30 21:52	Can anybody tell more about commander experience mechanics? When is it granted, how much, are there any factors that can modify experience multiplier etc.?

(0006789) AVS (administrator) 2016-10-01 02:29	For now commander should receive same exp as hero.

(0006790) Warmonger (administrator) 2016-10-01 07:15	Castle Commander has permanent +50% experience gain bonus.

(0006797) Dydzio (developer) 2016-10-01 15:25 edited on: 2016-10-01 16:24	EDIT: CGameHandler code "kills" commander via battle casualties procedure at end of each battle, moreover if commander really dies practically nothing changes - he still appears in battles.

(0006809) misiokles (reporter) 2016-10-03 06:21	All about WoG's commanders (VCMI commanders are lighter version) are descripe here: http://www.celestialheavens.com/h3maparchives/wog/wogfeatures.html [^] And please, don't forget about this bug: http://bugs.vcmi.eu/view.php?id=2439 [^]

(0006810) Dydzio (developer) 2016-10-03 11:03	Fixed in: https://github.com/vcmi/vcmi/pull/230 [^] and https://github.com/vcmi/vcmi/commit/723734fd04655ec456fb52154073b54e29e759d7 [^] Extra experience for castle commander not added, as it may be better idea to implement it later via unified commander specialty system. Generally commander code needs more attention, many things are missing for example descriptions for skills or commander revival requirements. For now commander "just works".

Relationships