0001582: Can't open spellbook in hotseat mode

(0004101)
beegee (developer)
2013-11-02 18:48

I will try to fix this bug.

(0004102)
Ivan (developer)
2013-11-02 19:26

Right now there is a function in battle interface that:
1) should be called whenever there may be change into buttons status
2) should correctly change state of all buttons.

Probably one of these statements is not valid for spellbook button.

(0004103)
beegee (developer)
2013-11-02 19:49
edited on: 2013-11-02 19:49

The function blockUI which updates buttons of the battle interface gets spell casting information of the old player.

bool canCastSpells = curInt->cb->battleCanCastSpell(&spellcastingProblem);

The variable curInt points to the old player when the blockUI method is invoked during the stack activation phase of the new player.

Any ideas how to fix this? curInt is a public member of the battle interface :(

(0004104)
beegee (developer)
2013-11-02 20:00

setActiveStack(stackToActivate);
    stackToActivate = nullptr;
    const CStack *s = activeStack;

    myTurn = true;
    if(!!attackerInt && defenderInt) //hotseat -> need to pick which interface "takes over" as active
        curInt = attackerInt->playerID == s->owner ? attackerInt : defenderInt;

The curInt reassignment should be moved before the setActiveStack method call. I don't know if activateStack is the correct place for setting the curInt variable, but it seems to be.

(0004106)
beegee (developer)
2013-11-02 20:09

Fixed in Revision 3600.

(0004107)
Povelitel (updater)
2013-11-02 21:58

It seems, it is a similar problem. Or I am mistaken?
http://bugs.vcmi.eu/view.php?id=1571 [^]

(0004109)
beegee (developer)
2013-11-03 14:49

Yes, it belongs to the same problem. I closed mantis 1571 and marked it as a duplicate of this issue. Thanks for your information, I didn't search for any open mantis point related to that problem :(

(0004677)
Kantor (updater)
2014-06-01 18:13

This one may be closed.

Issue History
Date Modified	Username	Field	Change
2013-11-02 18:47	beegee	New Issue
2013-11-02 18:48	beegee	Note Added: 0004101
2013-11-02 19:26	Ivan	Note Added: 0004102
2013-11-02 19:49	beegee	Note Added: 0004103
2013-11-02 19:49	beegee	Note Edited: 0004103	View Revisions
2013-11-02 20:00	beegee	Note Added: 0004104
2013-11-02 20:07	beegee	Note Added: 0004105
2013-11-02 20:09	beegee	Note Added: 0004106
2013-11-02 20:09	beegee	Status	new => resolved
2013-11-02 20:09	beegee	Fixed in Version	=> 0.94b
2013-11-02 20:09	beegee	Resolution	open => fixed
2013-11-02 20:09	beegee	Assigned To	=> beegee
2013-11-02 20:09	beegee	Note Deleted: 0004105
2013-11-02 21:58	Povelitel	Note Added: 0004107
2013-11-03 14:44	beegee	Relationship added	has duplicate 0001571
2013-11-03 14:49	beegee	Note Added: 0004109
2014-06-01 18:13	Kantor	Note Added: 0004677
2014-06-02 09:07	Kantor	Status	resolved => closed

Notes
(0004101) beegee (developer) 2013-11-02 18:48	I will try to fix this bug.

(0004102) Ivan (developer) 2013-11-02 19:26	Right now there is a function in battle interface that: 1) should be called whenever there may be change into buttons status 2) should correctly change state of all buttons. Probably one of these statements is not valid for spellbook button.

(0004103) beegee (developer) 2013-11-02 19:49 edited on: 2013-11-02 19:49	The function blockUI which updates buttons of the battle interface gets spell casting information of the old player. bool canCastSpells = curInt->cb->battleCanCastSpell(&spellcastingProblem); The variable curInt points to the old player when the blockUI method is invoked during the stack activation phase of the new player. Any ideas how to fix this? curInt is a public member of the battle interface :(

(0004104) beegee (developer) 2013-11-02 20:00	setActiveStack(stackToActivate); stackToActivate = nullptr; const CStack *s = activeStack; myTurn = true; if(!!attackerInt && defenderInt) //hotseat -> need to pick which interface "takes over" as active curInt = attackerInt->playerID == s->owner ? attackerInt : defenderInt; The curInt reassignment should be moved before the setActiveStack method call. I don't know if activateStack is the correct place for setting the curInt variable, but it seems to be.

(0004106) beegee (developer) 2013-11-02 20:09	Fixed in Revision 3600.

(0004107) Povelitel (updater) 2013-11-02 21:58	It seems, it is a similar problem. Or I am mistaken? http://bugs.vcmi.eu/view.php?id=1571 [^]

(0004109) beegee (developer) 2013-11-03 14:49	Yes, it belongs to the same problem. I closed mantis 1571 and marked it as a duplicate of this issue. Thanks for your information, I didn't search for any open mantis point related to that problem :(

(0004677) Kantor (updater) 2014-06-01 18:13	This one may be closed.