0000124: When gaining more than one level at once (say in a very large battle) the game does not correctly update skills each level...

(0000065)
Warmonger (administrator)
2009-10-08 05:24
edited on: 2009-10-08 05:24

Yes, we know well this problem. It works like first game sends all packages with level-ups containing levels to client and only then he has a chance to choose skill, which does not affect this particular group of levels.
However, set of skills has to be randomized on server to prevent cheating / oracle by client.

(0000066)
anonymous (viewer)
2009-10-08 11:19

maybe do a pingpong call? I mean: lvl up - send - get skill choices - send - choose a skill - send - again lvl up - send - etc.

(0000078)
Zamolxis (viewer)
2009-10-09 01:38

As compared to what we have reported as 0000050, this also adds a new piece of information, namely that apparently we may end up gaining more than 8 secondary skills during level up. Though considering the bug behavior, it kinda makes sense since the game doesn't seem to take into account the previous level up(s) when we have more of them in one go.

(0000130)
Tow dragon (viewer)
2009-10-18 13:47

@anonymous

It's not the problem of concept - we know how it should be fixed. The problem is it's not so simple to implement.

(0000240)
Tow (developer)
2009-11-20 23:31

Not a crashbug anymore, since 0000050 is fixed (r1363).

(0001228)
Ivan (developer)
2010-07-28 22:52

rev 1702: fixed by implementing ping-pong call

(0001238)
majaczek (reporter)
2010-07-29 15:03

I'd like also to not crash hero screen if we got more than 8 hero skills for mod able to handle greater maximum amount (and in h3 hero could know up to all skills, just it couldnt discover morethan limit)

WoG already gives a rule to check to be able to learn 10 skills and 10>8

also please do a scrolling feature for skills>8types

(0001239)
majaczek (reporter)
2010-07-29 15:05

or should I post it to mantis as new request under feature?
(edit don't work here but posting new post does work, so my doublepost)

(0001243)
Ivan (developer)
2010-07-29 16:12
edited on: 2010-07-29 16:34

It will crash if have have more than 8 skills? Then it should be fixed I suppose.
Scrolling is a nice but not needed for now. Create report if you want but I think it will wait till some mod support.

Edit:
I have not tested more then 8 skills but code looks to be fine exept one minor issue that still shouldn't lead to crash:
498 //secondary skills
499 for(int g=1; g<=8; ++g) --- hardcoded 8 needs to be replaced with global variable
500 {

(0002096)
Zamolxis (viewer)
2011-10-28 19:35

Checked in 0.86 and confirmed as fixed.

@majaczek: you can indeed create another report if you want. If you do, make it a Low priority Feature, maybe also mention "WoG feature request:..." in the Subject. It will be kept aside until support for WoG scripts will be created.

Issue History
Date Modified	Username	Field	Change
2009-10-08 02:52	Steven Aus	New Issue
2009-10-08 05:24	Warmonger	Note Added: 0000065
2009-10-08 05:24	Warmonger	Note Edited: 0000065	View Revisions
2009-10-08 05:27	Warmonger	Status	new => confirmed
2009-10-08 11:19	anonymous	Note Added: 0000066
2009-10-09 01:35	Zamolxis	Relationship added	related to 0000050
2009-10-09 01:38	Zamolxis	Note Added: 0000078
2009-10-18 13:47	Tow dragon	Note Added: 0000130
2009-10-27 17:41	Warmonger	Relationship added	parent of 0000145
2009-11-20 23:31	Tow	Note Added: 0000240
2009-11-20 23:31	Tow	Assigned To	=> Tow
2009-11-20 23:31	Tow	Severity	crash => major
2009-12-04 22:46	Zamolxis	Relationship added	related to 0000297
2009-12-05 22:24	Zamolxis	Relationship replaced	has duplicate 0000297
2010-07-28 22:52	Ivan	Note Added: 0001228
2010-07-28 22:52	Ivan	Status	confirmed => resolved
2010-07-28 22:52	Ivan	Fixed in Version	=> 0.89
2010-07-28 22:52	Ivan	Resolution	open => fixed
2010-07-28 22:52	Ivan	Assigned To	Tow => Ivan
2010-07-29 15:03	majaczek	Note Added: 0001238
2010-07-29 15:05	majaczek	Note Added: 0001239
2010-07-29 16:12	Ivan	Note Added: 0001243
2010-07-29 16:34	Ivan	Note Edited: 0001243	View Revisions
2010-08-18 14:15	Warmonger	Relationship added	related to 0000574
2010-08-24 14:34	Warmonger	Relationship added	related to 0000615
2011-10-28 19:35	Zamolxis	Note Added: 0002096
2011-10-28 19:35	Zamolxis	Status	resolved => closed

Notes
(0000065) Warmonger (administrator) 2009-10-08 05:24 edited on: 2009-10-08 05:24	Yes, we know well this problem. It works like first game sends all packages with level-ups containing levels to client and only then he has a chance to choose skill, which does not affect this particular group of levels. However, set of skills has to be randomized on server to prevent cheating / oracle by client.

(0000066) anonymous (viewer) 2009-10-08 11:19	maybe do a pingpong call? I mean: lvl up - send - get skill choices - send - choose a skill - send - again lvl up - send - etc.

(0000078) Zamolxis (viewer) 2009-10-09 01:38	As compared to what we have reported as 0000050, this also adds a new piece of information, namely that apparently we may end up gaining more than 8 secondary skills during level up. Though considering the bug behavior, it kinda makes sense since the game doesn't seem to take into account the previous level up(s) when we have more of them in one go.

(0000130) Tow dragon (viewer) 2009-10-18 13:47	@anonymous It's not the problem of concept - we know how it should be fixed. The problem is it's not so simple to implement.

(0000240) Tow (developer) 2009-11-20 23:31	Not a crashbug anymore, since 0000050 is fixed (r1363).

(0001228) Ivan (developer) 2010-07-28 22:52	rev 1702: fixed by implementing ping-pong call

(0001238) majaczek (reporter) 2010-07-29 15:03	I'd like also to not crash hero screen if we got more than 8 hero skills for mod able to handle greater maximum amount (and in h3 hero could know up to all skills, just it couldnt discover morethan limit) WoG already gives a rule to check to be able to learn 10 skills and 10>8 also please do a scrolling feature for skills>8types

(0001239) majaczek (reporter) 2010-07-29 15:05	or should I post it to mantis as new request under feature? (edit don't work here but posting new post does work, so my doublepost)

(0001243) Ivan (developer) 2010-07-29 16:12 edited on: 2010-07-29 16:34	It will crash if have have more than 8 skills? Then it should be fixed I suppose. Scrolling is a nice but not needed for now. Create report if you want but I think it will wait till some mod support. Edit: I have not tested more then 8 skills but code looks to be fine exept one minor issue that still shouldn't lead to crash: 498 //secondary skills 499 for(int g=1; g<=8; ++g) --- hardcoded 8 needs to be replaced with global variable 500 {

(0002096) Zamolxis (viewer) 2011-10-28 19:35	Checked in 0.86 and confirmed as fixed. @majaczek: you can indeed create another report if you want. If you do, make it a Low priority Feature, maybe also mention "WoG feature request:..." in the Subject. It will be kept aside until support for WoG scripts will be created.