0003144: Typo in CServerHandler.cpp at line 421 in CServerHandler::sendMessage()

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003144

VCMI

Multiplayer

public

2020-10-03 05:12

2024-05-11 08:51

Reporter

jambolo

Assigned To

Ivan

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

assigned

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0003144: Typo in CServerHandler.cpp at line 421 in CServerHandler::sendMessage()

Description

The following code is probably wrong:

    void CServerHandler::sendMessage(const std::string & txt) const
    {
        ...
        else if(command == "!forcep")
        {
            ...
            if(connectedId.length(), playerColorId.length()) <---- HERE *******
            {
                ...
            }
        }
        ...
    }

Perhaps it should be:

    if(connectedId.length() < playerColorId.length())

Tags

No tags attached.

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2020-10-03 05:12	jambolo	New Issue
2022-04-03 19:06	Povelitel	Assigned To	=> SXX
2022-04-03 19:06	Povelitel	Status	new => assigned
2024-05-11 08:51	Povelitel	Assigned To	SXX => Ivan

Site | Forums | Wiki | Slack | GitHub