0003133: "allowedTerrains" command crashes custom mines.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003133

VCMI

Random Map Generator

public

2020-06-17 20:01

2023-03-26 15:54

Reporter

misiokles

Assigned To

Nordsoft

Priority

none

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Windows

OS Version

Product Version

0.99

Target Version

Fixed in Version

1.0.0

Summary

0003133: "allowedTerrains" command crashes custom mines.

Description

For example HotA made new mines graphics belong to sand terrain.
Code for adding such mines to vcmi is easy.

{
"core:mine" : {
    "types" : {
        "hotaCrystalCavern" : {
        "templates": {
            "avmcrdn0" : { "animation" : "avmcrdn0", //hota sand
                    "mask" : ["VVVV","VBBB","VBAB"],
                    "allowedTerrains":["sand"]
                    },
                }
            },

Without "allowedTerrains":["sand"] command, such crystal mine is generated in every type of terrain. But with "allowedTerrains":["sand"] - game crash during map generation.

Steps To Reproduce

n/a

Additional Information

n/a

Tags

No tags attached.

Attached Files

hj.png [^] (1,142,552 bytes) 2020-06-17 20:03

Relationships

Notes
(0007908) Andruids (reporter) 2020-06-17 21:44 edited on: 2020-06-18 03:24	Let me correct this. Defining new type within mines won't do anything, of course. misiokles meant this code: { "core:mine" : { "types" : { "crystalCavern" : { "templates": { "avmcrdn0" : { "animation" : "avmcrdn0", //hota sand "visitableFrom" : [ "---", "+++", "+++" ], "mask" : ["VVVV","VBBB","VBAB"] } } }, And including: "allowedTerrains":["sand"] causes a different type of bug - game will start and RMG will run, but it will generate an empty map. Without borders and with only 2 zones iirc.

(0008304) Nordsoft (administrator) 2022-08-21 23:51	Should work well in new-terrains feature branch

Issue History
Date Modified	Username	Field	Change
2020-06-17 20:01	misiokles	New Issue
2020-06-17 20:03	misiokles	File Added: hj.png
2020-06-17 21:44	Andruids	Note Added: 0007908
2020-06-18 03:23	Andruids	Note Edited: 0007908	View Revisions
2020-06-18 03:24	Andruids	Note Edited: 0007908	View Revisions
2022-08-21 23:51	Nordsoft	Note Added: 0008304
2022-08-22 12:53	Nordsoft	Assigned To	=> Nordsoft
2022-08-22 12:53	Nordsoft	Status	new => assigned
2023-03-26 15:54	Warmonger	Status	assigned => resolved
2023-03-26 15:54	Warmonger	Fixed in Version	=> 1.0.0
2023-03-26 15:54	Warmonger	Resolution	open => fixed

Site | Forums | Wiki | Slack | GitHub