0003060: core in CMap.cpp::getTile

(0007788)
mpech (reporter)
2019-05-16 11:15

looking a bit further:
wrong offset is pos.x == 144 (==width)

> CApplyOnGS<NewObject>::applyOnGS
wrong CApplyOnGS<NewObject> for which pos.x == 144 holds Obj ID ==8

problematic Obj ID == 8 maps to CGameHandler::buildBoat and indeed adding
```
    int3 tile2 = tile + int3(1,0,0);
    if (!gs->map->isInTheMap(tile2))
    {
        complain("ISUCK");
        return false;
    }
```

does complain

error occurs because in attached screenshot, shipyard lies on the almost border of the map.
bestLocation may (not checked) return the tile (143,0,0) which is at the utmost limit (x axis) of the map but line
> no.pos = tile + int3(1,0,0);
makes the generated boat go out of the map

code seem to be old and there must be a reason I don't understand why we add int3(1,0,0) to the bestLocation()??

(0007789)
mpech (reporter)
2019-05-16 13:04
edited on: 2019-05-16 13:04

I ended up modifying CObjectHandler.cpp so I can play

```
IBoatGenerator::EGeneratorState IBoatGenerator::shipyardStatus() const
{
    int3 tile = bestLocation();
    const TerrainTile *t = IObjectInterface::cb->getTile(tile);
    if(!t)
        return TILE_BLOCKED; //no available water
    else if (!o->cb->gameState()->map->isInTheMap(tile+int3(1,0,0))) // poor code dupe from CGameHandler.cpp
        return TILE_BLOCKED;

```
but propagating the (1,0,0)offset seem rather rather ugly

(0007792)
Dydzio (developer)
2019-05-18 17:42

Fixed in: https://github.com/vcmi/vcmi/pull/591 [^]

Issue History
Date Modified	Username	Field	Change
2019-05-16 09:02	mpech	New Issue
2019-05-16 09:02	mpech	File Added: getTile.zip
2019-05-16 11:15	mpech	Note Added: 0007788
2019-05-16 13:04	mpech	Note Added: 0007789
2019-05-16 13:04	mpech	Note Edited: 0007789	View Revisions
2019-05-16 13:04	mpech	Note Edited: 0007789	View Revisions
2019-05-18 17:36	Dydzio	Assigned To	=> Dydzio
2019-05-18 17:36	Dydzio	Status	new => assigned
2019-05-18 17:42	Dydzio	Note Added: 0007792
2019-05-21 14:45	Dydzio	Status	assigned => resolved
2019-05-21 14:45	Dydzio	Fixed in Version	=> 1.next
2019-05-21 14:45	Dydzio	Resolution	open => fixed

Notes
(0007788) mpech (reporter) 2019-05-16 11:15	looking a bit further: wrong offset is pos.x == 144 (==width) > CApplyOnGS<NewObject>::applyOnGS wrong CApplyOnGS<NewObject> for which pos.x == 144 holds Obj ID ==8 problematic Obj ID == 8 maps to CGameHandler::buildBoat and indeed adding ``` int3 tile2 = tile + int3(1,0,0); if (!gs->map->isInTheMap(tile2)) { complain("ISUCK"); return false; } ``` does complain error occurs because in attached screenshot, shipyard lies on the almost border of the map. bestLocation may (not checked) return the tile (143,0,0) which is at the utmost limit (x axis) of the map but line > no.pos = tile + int3(1,0,0); makes the generated boat go out of the map code seem to be old and there must be a reason I don't understand why we add int3(1,0,0) to the bestLocation()??

(0007789) mpech (reporter) 2019-05-16 13:04 edited on: 2019-05-16 13:04	I ended up modifying CObjectHandler.cpp so I can play ``` IBoatGenerator::EGeneratorState IBoatGenerator::shipyardStatus() const { int3 tile = bestLocation(); const TerrainTile *t = IObjectInterface::cb->getTile(tile); if(!t) return TILE_BLOCKED; //no available water else if (!o->cb->gameState()->map->isInTheMap(tile+int3(1,0,0))) // poor code dupe from CGameHandler.cpp return TILE_BLOCKED; ``` but propagating the (1,0,0)offset seem rather rather ugly

(0007792) Dydzio (developer) 2019-05-18 17:42	Fixed in: https://github.com/vcmi/vcmi/pull/591 [^]

Relationships