0002389: CComponent::getSubtitleInternal segfaults on unknown town buildings

(0006310)
vmarkovtsev (developer)
2016-01-19 07:39

https://github.com/vcmi/vcmi/pull/158 [^]

(0006311)
AVS (administrator)
2016-01-19 08:20

The question is why 27 is requested? May be the bug is in other place.

(0006312)
AVS (administrator)
2016-01-19 08:28

Looks like Barbarian town has missing entries:

"extraTownHall": { "id" : 27, "requires" : [ "townHall" ], "mode" : "auto" },
"extraCityHall": { "id" : 28, "requires" : [ "cityHall" ], "mode" : "auto" },
"extraCapitol": { "id" : 29, "requires" : [ "capitol" ], "mode" : "auto" }

Need to check all other towns too.

(0006313)
Warmonger (administrator)
2016-01-19 09:45

"Auto" buildings are just decorative and have no own function. There is also no reason to display them in a message.

(0006314)
AVS (administrator)
2016-01-19 10:06

Now I found a bug.

The problem is that when map is loading, "extra" buildings are added even if the town have no "extra" buildings.

CMapLoaderH3M::convertBuildings

...

    if(ret.find(BuildingID::CITY_HALL) != ret.end())
    {
        ret.insert(BuildingID::EXTRA_CITY_HALL);
    }
    if(ret.find(BuildingID::TOWN_HALL) != ret.end())
    {
        ret.insert(BuildingID::EXTRA_TOWN_HALL);
    }
    if(ret.find(BuildingID::CAPITOL) != ret.end())
    {
        ret.insert(BuildingID::EXTRA_CAPITOL);
    }

Issue History
Date Modified	Username	Field	Change
2016-01-19 07:14	vmarkovtsev	New Issue
2016-01-19 07:14	vmarkovtsev	File Added: The Lord of War.h3m
2016-01-19 07:15	vmarkovtsev	File Added: save.zip
2016-01-19 07:39	vmarkovtsev	Note Added: 0006310
2016-01-19 08:20	AVS	Note Added: 0006311
2016-01-19 08:28	AVS	Note Added: 0006312
2016-01-19 09:45	Warmonger	Note Added: 0006313
2016-01-19 10:06	AVS	Note Added: 0006314

Notes
(0006310) vmarkovtsev (developer) 2016-01-19 07:39	https://github.com/vcmi/vcmi/pull/158 [^]

(0006311) AVS (administrator) 2016-01-19 08:20	The question is why 27 is requested? May be the bug is in other place.

(0006312) AVS (administrator) 2016-01-19 08:28	Looks like Barbarian town has missing entries: "extraTownHall": { "id" : 27, "requires" : [ "townHall" ], "mode" : "auto" }, "extraCityHall": { "id" : 28, "requires" : [ "cityHall" ], "mode" : "auto" }, "extraCapitol": { "id" : 29, "requires" : [ "capitol" ], "mode" : "auto" } Need to check all other towns too.

(0006313) Warmonger (administrator) 2016-01-19 09:45	"Auto" buildings are just decorative and have no own function. There is also no reason to display them in a message.

(0006314) AVS (administrator) 2016-01-19 10:06	Now I found a bug. The problem is that when map is loading, "extra" buildings are added even if the town have no "extra" buildings. CMapLoaderH3M::convertBuildings ... if(ret.find(BuildingID::CITY_HALL) != ret.end()) { ret.insert(BuildingID::EXTRA_CITY_HALL); } if(ret.find(BuildingID::TOWN_HALL) != ret.end()) { ret.insert(BuildingID::EXTRA_TOWN_HALL); } if(ret.find(BuildingID::CAPITOL) != ret.end()) { ret.insert(BuildingID::EXTRA_CAPITOL); }

Relationships