0001732: Typo in AIUtility.cpp (?) - MantisBT

MantisBT

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001732

VCMI

AI - Adventure Map

public

2014-02-26 17:07

2014-06-02 10:59

Reporter

xyz

Assigned To

Warmonger

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

0.94f

Target Version

Fixed in Version

0.95

Summary

0001732: Typo in AIUtility.cpp (?)

Description

    for (int x = hpos.x - DIST_LIMIT; x <= hpos.y + DIST_LIMIT; ++x) //get only local objects instead of all possible objects on the map
    {
        for (int y = hpos.y - DIST_LIMIT; y <= hpos.y + DIST_LIMIT; ++y)

Shouldn't first line be "for (int x = hpos.x - DIST_LIMIT; x <= hpos.x + DIST_LIMIT; ++x)"?

Tags

No tags attached.

Relationships

Notes
(0004528) Warmonger (administrator) 2014-02-26 17:18	Oh yes it should, good point :)

(0004529) Warmonger (administrator) 2014-02-26 17:30 edited on: 2014-02-26 17:33	This might seem as a rule-of-thumb piece of code, but actually for y < x (south-east half of map) AI was not very interested in picking nearby objects, which resulted in poor performance. Fixed in r3776.

(0004732) Kantor (updater) 2014-06-02 10:59	This one may be closed.

Issue History
Date Modified	Username	Field	Change
2014-02-26 17:07	xyz	New Issue
2014-02-26 17:07	xyz	Status	new => assigned
2014-02-26 17:07	xyz	Assigned To	=> Tow
2014-02-26 17:18	Warmonger	Note Added: 0004528
2014-02-26 17:30	Warmonger	Note Added: 0004529
2014-02-26 17:30	Warmonger	Status	assigned => resolved
2014-02-26 17:30	Warmonger	Fixed in Version	=> 0.95
2014-02-26 17:30	Warmonger	Resolution	open => fixed
2014-02-26 17:30	Warmonger	Assigned To	Tow => Warmonger
2014-02-26 17:33	Warmonger	Note Edited: 0004529	View Revisions
2014-06-02 10:59	Kantor	Note Added: 0004732
2014-06-02 10:59	Kantor	Status	resolved => closed

Site | Forums | Wiki | Slack | GitHub

Copyright © 2000 - 2024 MantisBT Team