0001245: Client freeze when visiting hut of the magi

(0003472)
Warmonger (administrator)
2013-03-29 17:19
edited on: 2013-03-29 17:20

I couldn't reproduce freeze. Also, cv object stores focus time outside the loop, so it should remain initialized. Any details on this issue?

        CenterView cv;
        FoWChange fw;
        cv.player = fw.player = h->tempOwner;

        showInfoDialog(h,61,soundBase::LIGHTHOUSE);

        fw.mode = 1;
        BOOST_FOREACH(auto it, eyelist[subID])
        {
            const CGObjectInstance *eye = cb->getObj(it);

            cb->getTilesInRange (fw.tiles, eye->pos, 10, h->tempOwner, 1);
            cb->sendAndApply(&fw);
            cv.pos = eye->pos;
            cv.focusTime = 2000;
            cb->sendAndApply(&cv);
        }
        cv.pos = h->getPosition(false);
        cb->sendAndApply(&cv);

(0003473)
Ivan (developer)
2013-03-29 17:41

Judging from code - if there 0 eyes focusTime won't be initialized. Maybe this is where freeze comes from?

(0003475)
Ivan (developer)
2013-03-29 19:16

Should be fixed, rev 3298

(0003485)
cirdan (reporter)
2013-04-01 18:53

I agree with your analysis. I was playing Titan's winter, which doesn't have any eye of the magi.

Thanks for fixing this.

Issue History
Date Modified	Username	Field	Change
2013-03-18 12:49	cirdan	New Issue
2013-03-18 12:49	cirdan	File Added: hutofmagi.diff
2013-03-29 17:19	Warmonger	Note Added: 0003472
2013-03-29 17:20	Warmonger	Note Edited: 0003472	View Revisions
2013-03-29 17:21	Warmonger	Assigned To	=> Warmonger
2013-03-29 17:21	Warmonger	Status	new => feedback
2013-03-29 17:41	Ivan	Note Added: 0003473
2013-03-29 19:16	Ivan	Note Added: 0003475
2013-03-29 19:16	Ivan	Status	feedback => resolved
2013-03-29 19:16	Ivan	Fixed in Version	=> 0.93
2013-03-29 19:16	Ivan	Resolution	open => fixed
2013-03-29 19:16	Ivan	Assigned To	Warmonger => Ivan
2013-04-01 18:53	cirdan	Note Added: 0003485
2014-05-30 17:43	beegee	Status	resolved => closed

Notes
(0003472) Warmonger (administrator) 2013-03-29 17:19 edited on: 2013-03-29 17:20	I couldn't reproduce freeze. Also, cv object stores focus time outside the loop, so it should remain initialized. Any details on this issue? CenterView cv; FoWChange fw; cv.player = fw.player = h->tempOwner; showInfoDialog(h,61,soundBase::LIGHTHOUSE); fw.mode = 1; BOOST_FOREACH(auto it, eyelist[subID]) { const CGObjectInstance *eye = cb->getObj(it); cb->getTilesInRange (fw.tiles, eye->pos, 10, h->tempOwner, 1); cb->sendAndApply(&fw); cv.pos = eye->pos; cv.focusTime = 2000; cb->sendAndApply(&cv); } cv.pos = h->getPosition(false); cb->sendAndApply(&cv);

(0003473) Ivan (developer) 2013-03-29 17:41	Judging from code - if there 0 eyes focusTime won't be initialized. Maybe this is where freeze comes from?

(0003475) Ivan (developer) 2013-03-29 19:16	Should be fixed, rev 3298

(0003485) cirdan (reporter) 2013-04-01 18:53	I agree with your analysis. I was playing Titan's winter, which doesn't have any eye of the magi. Thanks for fixing this.

Relationships