0000516: "This an abandoned shipyard" message in case the ways are blocked

View Revisions: Issue #516		[ All Revisions ] [ Back to Issue ]
Summary	0000516: "This an abandoned shipyard" message in case the ways are blocked

Revision	2010-07-05 00:00 by Zamolxis
Description	The message that we get in case the ways to a shipyard are blocked by anything except a boat (see my note to 0000370) differs from the one in H3. VCMI: We get the message in the 2nd screenshot attached to 0000246, which is grammatically incorrect. H3 (at least my version): We get the message in the screenshot attached to this report. H3 uses the name of the selected hero. If no hero is selected when we click on the shipyard, the first hero in our list gets selected and his/her name is then used in the message. The "problem" with the H3 behavior is that the selected hero might be in the corner of a map, and the shipyard 5 days away in the other corner, while the message still says "... encounters". SUGGESTION: As linking this shipyard message to the code of the list of adventure map heroes would anyway unnecessary complicate the code, I suggest we keep the current message, but just make it grammatically correct (i.e.: "This is an abandoned shipyard"). Also - a less important detail - the word "Ways" in the second phrase should not use capital letter. Though it can be that NWC wanted it like this as a hint, so if this is harder to correct, you can just leave it as it is.

Revision	2010-07-04 23:57 by Zamolxis
Description	The message that we get in case the ways to a shipyard are blocked by anything except a boat (see my note to 0000370) differs from the one in H3. VCMI: We get the message in the 2nd screenshot attached to 0000246, which is grammatically incorrect. H3 (at least my version): We get the message in the screenshot attached to this report. H3 uses the name of the selected hero. If no hero is selected when we click on the shipyard, the first hero in our list gets selected and his/her name is then used in the message. The "problem" with the H3 behavior is that the selected hero might be in the corner of a map, and the shipyard 5 days away in the other corner, while the message still says "... encounters". SUGGESTION: As linking this shipyard message to the code of the list of adventure map heroes would anyway unnecessary complicate the code, I suggest we keep the current message, but just make it grammatically correct (i.e.: "This is an abandoned shipyard"). Also - a less important detail - the word "Ways" in the second phrase should not use capital letter. Though it can NWC wanted it like this as a hint, so if this is harder to correct, you can just leave it as it is.

Site | Forums | Wiki | Slack | GitHub