0001281: Crash when building Tavern in Castle town on a loaded game

View Revisions: Issue #1281		[ All Revisions ] [ Back to Issue ]
Summary	0001281: Crash when building Tavern in Castle town on a loaded game

Revision	2013-05-29 20:54 by Zamolxis
Description	Map is VCMI_Tests_2012, Castle town is fully built from Map Editor (Grail included), except for Tavern. We can build Tavern if we start a new game, but if it's loaded from a save, the game crashes. As per screenshots, sometimes it crashes just before, sometimes just after the Tavern appears in the town screen. Crashdump + save attached (game saved at start, no actions before). This was not there in 0.92. I cannot test if it's introduced in 0.92b, because in there we couldn't build anything in a loaded game. This is a split from a discussion started in the notes of 0001272. As posted there, Ivan found it's something with the bonus system (duplicate lighthouse bonus? - see also console message in 2nd screenshot pointing the same): Crash on server, stacktrace: 0 ?? 0x3266250 1 CBonusSystemNode::unpropagateBonus HeroBonus.cpp 817 2 CBonusSystemNode::removeBonus HeroBonus.cpp 783 3 CGTownInstance::recreateBuildingsBonuses CObjectHandler.cpp 2489 4 NewStructures::applyGs NetPacksLib.cpp 444 5 CApplyOnGS<NewStructures>::applyOnGS CGameState.cpp 72 6 CGameState::apply CGameState.cpp 1849 7 CGameHandler::sendAndApply CGameHandler.cpp 2150 8 CGameHandler::sendAndApply CGameHandler.cpp 2182 9 CGameHandler::buildStructure CGameHandler.cpp 2486 10 BuildStructure::applyGh NetPacksServer.cpp 113 11 CApplyOnGH<BuildStructure>::applyOnGH CGameHandler.cpp 87 Maybe someone familiar with the bonus system can take care of it; and maybe also check if we can expect a similar bug on other towns.

Revision	2013-05-29 20:52 by Zamolxis
Description	Map is VCMI_Tests_2012, Castle town is fully built from Map Editor (Grail included), except for Tavern. We can build Tavern if we start a new game, but if it's loaded from a save, the game crashes. As per screenshots, sometimes it crashes just before, sometimes just after the Tavern appears in the town screen. Crashdump + save attached (game saved at start, no actions before). This was not there in 0.92. I cannot test if it's since 0.92b, because there building didn't work on any loaded game. This is a split from a discussion started in the notes of 0001272. As posted there, Ivan found it's something with the bonus system (duplicate lighthouse bonus? - see also console message in on screenshot point the same): Crash on server, stacktrace: 0 ?? 0x3266250 1 CBonusSystemNode::unpropagateBonus HeroBonus.cpp 817 2 CBonusSystemNode::removeBonus HeroBonus.cpp 783 3 CGTownInstance::recreateBuildingsBonuses CObjectHandler.cpp 2489 4 NewStructures::applyGs NetPacksLib.cpp 444 5 CApplyOnGS<NewStructures>::applyOnGS CGameState.cpp 72 6 CGameState::apply CGameState.cpp 1849 7 CGameHandler::sendAndApply CGameHandler.cpp 2150 8 CGameHandler::sendAndApply CGameHandler.cpp 2182 9 CGameHandler::buildStructure CGameHandler.cpp 2486 10 BuildStructure::applyGh NetPacksServer.cpp 113 11 CApplyOnGH<BuildStructure>::applyOnGH CGameHandler.cpp 87 Maybe someone familiar with the bonus system can take care of it; and maybe also check if we can expect a similar bug on other towns.

Revision	2013-05-29 20:49 by Zamolxis
Description	Map is VCMI_Tests_2012, Castle town is fully built from Map Editor (Grail included), except for Tavern. We can build Tavern if we start a new game, but if it's loaded from a save, the game crashes. As per screenshots, sometimes it crashes just before, sometimes just after the Tavern appears in the town screen. Crashdump + save attached (game saved at start, no actions before). This was not there in 0.92. I cannot test if it's since 0.92b, because there building didn't work on any loaded game. This is a split from a discussion started in the notes of 0001272. As posted there, Ivan found in there something in bonus system (duplicate lighthouse bonus?): Crash on server, stacktrace: 0 ?? 0x3266250 1 CBonusSystemNode::unpropagateBonus HeroBonus.cpp 817 2 CBonusSystemNode::removeBonus HeroBonus.cpp 783 3 CGTownInstance::recreateBuildingsBonuses CObjectHandler.cpp 2489 4 NewStructures::applyGs NetPacksLib.cpp 444 5 CApplyOnGS<NewStructures>::applyOnGS CGameState.cpp 72 6 CGameState::apply CGameState.cpp 1849 7 CGameHandler::sendAndApply CGameHandler.cpp 2150 8 CGameHandler::sendAndApply CGameHandler.cpp 2182 9 CGameHandler::buildStructure CGameHandler.cpp 2486 10 BuildStructure::applyGh NetPacksServer.cpp 113 11 CApplyOnGH<BuildStructure>::applyOnGH CGameHandler.cpp 87 Also console gives a similar message. Maybe someone familiar with the bonus system can take care of it; and maybe also check if we can expect a similar bug on other towns.

Site | Forums | Wiki | Slack | GitHub