MantisBT - VCMI
View Issue Details
0000961VCMIMechanics - Battlespublic2012-05-18 18:122014-05-30 17:41
Ivan 
Ivan 
lowtweakalways
closedfixed 
x86_64Ubuntu Linux12.04 (precise)
0.88 
0.89 
0000961: Wrong terrain in battle
Map Arrogance, sawmill guardians near starting town.
This battle always happens on clouds with expert Air magic bonus.
I don't see any source of clouds nearby - correct terrain should be normal dirt.
No tags attached.
related to 0000866closed Ivan Graphical bugs on adventure map 
Issue History
2012-05-18 18:12IvanNew Issue
2012-05-18 22:46TowProduct Version0.dev => 0.88
2012-05-18 22:47TowRelationship addedrelated to 0000866
2012-05-18 22:58TowNote Added: 0002494
2012-05-18 22:58TowAssigned To => Tow
2012-05-18 22:58TowStatusnew => feedback
2012-05-19 08:13IvanNote Added: 0002500
2012-05-19 08:13IvanStatusfeedback => assigned
2012-05-19 08:14IvanAssigned ToTow => Ivan
2012-05-19 11:53IvanNote Added: 0002501
2012-05-19 11:53IvanStatusassigned => resolved
2012-05-19 11:53IvanFixed in Version => 0.89
2012-05-19 11:53IvanResolutionopen => fixed
2014-05-30 17:41beegeeStatusresolved => closed

Notes
(0002494)
Tow   
2012-05-18 22:58   
There are two issues here.
Object from another map level (underground) were incorrectly considered for battlefield overlays and that is fixed in r2691.

There is also another problem — terrain overlays can have various shapes, not only 8x6. The coveringAt method was used for checking if the given tile is covered by overlay. It depended on coverage maps that were disabled in r2550 as part of fix for 0000866. Coverage maps are not only GUI hint, they also affect game logic.
I'm wondering, if it would be a good idea to programatically recreate all coverage maps (it shouldn't be hard to check where def is transparent and where it is not) and put that info into some JSON config. What do you think?
(0002500)
Ivan   
2012-05-19 08:13   
I was thinking about turning all objects shapes into rectangles (as in editor) on loading using existing msk's. IIRC this will work with all overlays. I'll see what I can do without breaking 0000866
If not - then I'll move them to json one way or another.
(0002501)
Ivan   
2012-05-19 11:53   
Should be fixed in rev. 2694
Instead of blockmaps\coverage maps code uses width and height values from msk.
It should be correct for all overlays.