MantisBT - VCMI
View Issue Details
0000709VCMIMechanics - Objectspublic2011-03-07 15:342014-05-30 17:40
Zamolxis 
Warmonger 
normalminoralways
closedfixed 
0.84 
0.86 
0000709: Warrior's Tomb may give The Grail
Take Rion in the attached save game and go through the tombs.

(the high occurrence of Grails is because I edited the map to allow only a limited number of artifacts while testing for 0000638; the map is the one from 0000707)
No tags attached.
7z 2011-03-04_TombGrailArtifact.7z (81,117) 2011-03-07 15:34
https://bugs.vcmi.eu/file_download.php?file_id=696&type=bug
jpg 2011-03-04_TombGrailArtifact.jpg (71,855) 2011-03-07 15:37
https://bugs.vcmi.eu/file_download.php?file_id=697&type=bug
jpg

jpg 2011-03-04_TombGrailArtifacts.jpg (184,397) 2011-03-07 15:38
https://bugs.vcmi.eu/file_download.php?file_id=698&type=bug
jpg
Issue History
2011-03-07 15:34ZamolxisNew Issue
2011-03-07 15:34ZamolxisStatusnew => assigned
2011-03-07 15:34ZamolxisAssigned To => Tow
2011-03-07 15:34ZamolxisFile Added: 2011-03-04_TombGrailArtifact.7z
2011-03-07 15:37ZamolxisFile Added: 2011-03-04_TombGrailArtifact.jpg
2011-03-07 15:38ZamolxisFile Added: 2011-03-04_TombGrailArtifacts.jpg
2011-03-07 16:13WarmongerAssigned ToTow => Warmonger
2011-03-07 16:14WarmongerNote Added: 0001626
2011-03-07 16:16WarmongerNote Edited: 0001626bug_revision_view_page.php?bugnote_id=1626#r1273
2011-03-07 16:16WarmongerNote Edited: 0001626bug_revision_view_page.php?bugnote_id=1626#r1274
2011-03-07 16:16WarmongerNote Edited: 0001626bug_revision_view_page.php?bugnote_id=1626#r1275
2011-03-07 18:57ZamolxisNote Added: 0001627
2011-03-07 18:58ZamolxisNote Edited: 0001627bug_revision_view_page.php?bugnote_id=1627#r1279
2011-03-07 19:00WarmongerNote Added: 0001628
2011-03-07 19:54ZamolxisNote Added: 0001629
2011-03-07 19:56ZamolxisNote Edited: 0001629bug_revision_view_page.php?bugnote_id=1629#r1281
2011-03-08 07:43WarmongerStatusassigned => confirmed
2011-03-08 10:00ZamolxisNote Edited: 0001629bug_revision_view_page.php?bugnote_id=1629#r1286
2011-05-30 23:03ZamolxisNote Added: 0001766
2011-05-31 04:18WarmongerNote Added: 0001771
2011-05-31 04:22WarmongerNote Edited: 0001771bug_revision_view_page.php?bugnote_id=1771#r1332
2011-05-31 07:57ZamolxisNote Added: 0001772
2011-05-31 07:57ZamolxisStatusconfirmed => feedback
2011-05-31 08:00ZamolxisNote Edited: 0001772bug_revision_view_page.php?bugnote_id=1772#r1334
2011-05-31 08:04WarmongerNote Added: 0001773
2011-05-31 08:07WarmongerNote Edited: 0001773bug_revision_view_page.php?bugnote_id=1773#r1336
2011-05-31 08:16ZamolxisNote Added: 0001774
2011-05-31 08:16ZamolxisStatusfeedback => assigned
2011-05-31 08:20WarmongerNote Added: 0001775
2011-05-31 08:57ZamolxisNote Added: 0001776
2011-05-31 08:57ZamolxisNote Edited: 0001776bug_revision_view_page.php?bugnote_id=1776#r1338
2011-05-31 08:59ZamolxisNote Edited: 0001776bug_revision_view_page.php?bugnote_id=1776#r1339
2011-06-18 05:19WarmongerNote Added: 0001796
2011-06-18 05:57WarmongerNote Added: 0001798
2011-06-18 05:57WarmongerStatusassigned => resolved
2011-06-18 05:57WarmongerFixed in Version => 0.89
2011-06-18 05:57WarmongerResolutionopen => fixed
2014-05-30 17:40beegeeStatusresolved => closed

Notes
(0001626)
Warmonger   
2011-03-07 16:14   
(edited on: 2011-03-07 16:16)
If you banned all the relics (or artifacts of any specific rarity) on your map, it's the way it was implemented. But shouldn't happen if at least one of a kind is avaliable.

(0001627)
Zamolxis   
2011-03-07 18:57   
(edited on: 2011-03-07 18:58)
I tried the map in H3. I didn't get any grail.

(I know it's a matter of randomness... but I doubt it's just that in this case)

(0001628)
Warmonger   
2011-03-07 19:00   
What happens then?

I didn't try Warriors's Tomb, but see what happens when you place a random artifact on the map when all are banned :P
(0001629)
Zamolxis   
2011-03-07 19:54   
(edited on: 2011-03-08 10:00)
I see now what you meant, that is that in H3 if all artifacts were banned, Grail was given. And that could be at Warrior's Tomb, or any other locations/objects/events giving random artifacts. I was confused by "it's the way it was implemented", thinking you meant VCMI, but I see you meant H3...

But still, I wonder about H3, because in my MapEditor I cannot disable all artifacts. If I try to disable the last of them, the next one gets auto-selected. Perhaps you meant a combination of MapEditor settings and WoG bans?...

Anyway, that's another story... unrelated to the bug we have here.

(0001766)
Zamolxis   
2011-05-30 23:03   
In 0.84d I also found the Grail at the Crypt, but I guess it's related to the same issue.
(0001771)
Warmonger   
2011-05-31 04:18   
(edited on: 2011-05-31 04:22)
Zam, it can't be fixed better than it is.
If all artifacts of certain rairity are banned, we can either give none (which would still be considered as bug, and original game does not predict such option), or create new art just like this. All I can do is to choose another artifact(s) or force editor / settings to never allow banning artifacts.

(0001772)
Zamolxis   
2011-05-31 07:57   
(edited on: 2011-05-31 08:00)
Maybe I'm still missing something, but these are the facts as I see them after running more tests:

1. It's impossible to ban all artifacts from Map Editor. After you de-select all but one, when you try to de-select the last one left, the next one in the list gets automatically selected (and list restarts from the top, if you try to de-select the last one).

2. If you then de-select all but one artifact from Map Specifications in Editor, and then you place 100 Tombs and 100 Crypts on the map, when you play in H3O, you will get 100 times only that artifact from the Tombs, and a random number of times that artifact again from the Crypts (as sometimes they give only gold). Never the Grail.

3. The only place other than Map Editor where you can ban artifacts (to my knowledge), is the WoG Menu. If you leave only 1 artifact selected in Map Editor, but then you ban it from the WoG Menu, then the game freezes at start while applying the WoG settings.

So to me at least, it looks like NWC clearly coded The Grail with a different attribute, to make sure there's always maximum 1 at any given time to be found on the map (unless structure already built in town from Editor), and that is never as an artifact to be found in Tombs, Crypts or other locations (more than once - as it's the case now in VCMI), but only to be dug out.

(0001773)
Warmonger   
2011-05-31 08:04   
(edited on: 2011-05-31 08:07)
But it's possible to ban all artifacts of certain _rarity_ on the map. In such case, free random artifacts which should have this rarity start to become Bow of Sharpshooter, which makes even less sense than Grail.

(0001774)
Zamolxis   
2011-05-31 08:16   
Again, I still don't get it (sorry). If I ban all but Bow of Sharpshooter, then I still get 100 times Bow of Sharpshooter, never the Grail. The Grail is clearly either coded differently than other relic/combo artifacts, or else hardcoded to never show up at any map location which gives artifacts.

If I'm still missing something, give me a clear example (which artifact, which exact settings) of how can I ever reproduce what you're saying, in order to get The Grail from a Tomb in the original H3?
(0001775)
Warmonger   
2011-05-31 08:20   
Simply ban all relics and place a random relic artifact on the map.

It's easier to spot this way, as map locations may give artifacts of different rarities.
I never said that original game gives Grail. Last time I checked, it gave me Bow of Sharpshooter which neither should pop up. Both are not perfect solution, but some artifact must be given in the end.
(0001776)
Zamolxis   
2011-05-31 08:57   
(edited on: 2011-05-31 08:59)
Let's see if I got it right:
- First, to make sure we're on the same pace, by Relics you mean L4 artifacts, right?
- If the above is correct then I did the following: disabled all artifacts but Charm of Mana (non-relic), and placed an ART4 (random relic) on the map.

The result of my test was that all Tombs were giving Charms of Mana, and that ART4 became Charm of Mana as well. So how were you able to get Bow of Sharpshooter in that scenario is still not reproducible by me. If instead of Random ART4 I place the Bow of Sharpshooter on the map, then the object is placed as such in that spot, but for the rest all Tombs continue to give Charms of Mana only.

In regards to your last statement "Both are not perfect solution, but some artifact must be given in the end", if we can't implement H3 logic but would be forced to reach a compromise, then I'd go for Bows of Sharpshooter any day over Grails. The Grail is not just another artifact (relic or not) that you can get today one from a Tomb, and tomorrow the second from a Crypt. The Grail is unique. We can always have a mod which allows more (and to be found at map locations), but that's another story.

(0001796)
Warmonger   
2011-06-18 05:19   
I fixed it so now if there are no artifacts of specified rarity, the other one would be picked.
Graild still can be given if all arts are disabled, but as you say editor doesn't allow such option yet. But it's better than crash in some upredictable future.
(0001798)
Warmonger   
2011-06-18 05:57   
Fixed in r2185