MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002328VCMIMechanics - Objectspublic2015-11-13 23:442016-10-17 17:52
ReporterSXX 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version0.98e 
Target VersionFixed in Version 
Summary0002328: Favorable winds "leaking" outside out of boundaries
DescriptionWhen testing it on my own map I notice weird behaviour that Favorable winds objects cover larger areas than they should. What interesting that only happen when there is some delimiter between water tiles that have favorable winds over it and other one.

I suspect that it's implementation inside "CGameState::randomizeMapObjects" working incorrectly.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000866closed Ivan Graphical bugs on adventure map 
related to 0002557closed Ivan instead of the battlefield "Favorable winds" 
Attached Files? SXX_Favorable_winds.h3m (1,797) 2015-11-13 23:44
https://bugs.vcmi.eu/file_download.php?file_id=2394&type=bug
jpg favorable_winds.jpg (194,645) 2015-11-13 23:51
https://bugs.vcmi.eu/file_download.php?file_id=2395&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2015-11-13 23:44SXXNew Issue
2015-11-13 23:44SXXFile Added: SXX_Favorable_winds.h3m
2015-11-13 23:51SXXFile Added: favorable_winds.jpg
2015-11-13 23:53SXXNote Added: 0006083
2015-11-14 02:17SXXNote Added: 0006084
2015-11-14 02:19SXXNote Added: 0006085
2015-11-14 02:42SXXNote Added: 0006086
2015-11-14 03:33SXXNote Added: 0006087
2015-11-27 06:02SXXNote Added: 0006123
2015-11-27 06:03SXXNote Edited: 0006123bug_revision_view_page.php?bugnote_id=6123#r3043
2015-11-27 06:03SXXRelationship addedrelated to 0000866
2016-09-07 17:50SXXNote Added: 0006627
2016-10-17 17:52SXXRelationship addedrelated to 0002557

Notes
(0006083)
SXX   
2015-11-13 23:53   
Uploaded screenshot. White area on it is covered by favorable winds.
(0006084)
SXX   
2015-11-14 02:17   
Find out what exactly cause problem: size of map object is always the same regardless of what type of favorable wind map object is used. Though as I didn't digged into H3M/objects before not sure what way to fix it.
(0006085)
SXX   
2015-11-14 02:19   
Also just note: we still need to get new function lika "getvisiblePos" for object that do about same thing as "getBlockedPos" so it's easier to iterate via tiles used by object.
(0006086)
SXX   
2015-11-14 02:42   
In fact this problem also affect all other magical terrains.
(0006087)
SXX   
2015-11-14 03:33   
Just in case I'm not going to work on this one at least before I'm done with pathfinding, so if someone else know how to fix it fast please do.
(0006123)
SXX   
2015-11-27 06:02   
(edited on: 2015-11-27 06:03)
Ivan give me hint that issue related to fact that VCMI set biggest possible size for objects by default and main issue is that as result all tiles of an object set as "visible" by default.

Correct data must be available in msk files from assets, but this data is partially incorrect for some objects and caused issues in past: 0000866

So it's may be tricky to fix special terrains without breaking something.
(0006627)
SXX   
2016-09-07 17:50   
This is weird, but feels like something changed now. No idea when that happen.
Still not 100% sure it's work properly.