MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001635VCMICampaignspublic2013-12-27 12:332023-06-30 12:28
ReporterIvan 
Assigned ToIvan 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001635: Minor campaign features that are still missing
Description- Yog:
Can't use spellbook. Probably should be turned into hero property available to our modding system.

Modding interface:
Probably should be implemented as special state of spellbook entry:
"spellbook" : "banned"
(if string and string == banned -> disable spellbook, else - parse list of spells)

Internally:
Probably separate flag similar to current haveSpellbook.

- Gem:
Has her class renamed to "Sorceress".
Probably we should give her a custom class which is essentially a copy of Druid class but with different name.

Localization can be handled with mods as well so no need to do anything about it on our side.

- Anything else I missed?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
parent of 0002652resolved a.yupinov Missing feature: Yog CAN learn spells in Birth of a Barbarian campaign. 
related to 0001674closed beegee Xeron should be re-created for the last scenario of the AB campaign Armageddon's Blade 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-12-27 12:33IvanNew Issue
2013-12-28 19:06IvanNote Added: 0004220
2014-01-30 20:00IvanRelationship addedrelated to 0001674
2018-08-04 12:08a.yupinovRelationship addedparent of 0002652
2021-01-25 16:22MikeLodzPrioritynormal => low
2023-06-27 11:30IvanNote Added: 0008647
2023-06-27 11:30IvanAssigned To => Ivan
2023-06-27 11:30IvanStatusnew => confirmed
2023-06-30 12:28IvanNote Added: 0008661
2023-06-30 12:28IvanStatusconfirmed => resolved
2023-06-30 12:28IvanResolutionopen => fixed

Notes
(0004220)
Ivan   
2013-12-28 19:06   
I've looked into both of these features and they are more complex than they look like.
Both Gem and Yog are not separate campaign-only heroes like Gelu or Mutare. Instead they're normal heroes available in scenarios.

So changing these heroes one way or another will also affect main game, not only campaigns. Unless somebody finds a better idea on how to fix this problem I think we should delay it.

I have an idea on how to fix this but it can be implemented only after 0001164
(0008647)
Ivan   
2023-06-27 11:30   
Tracked on Git:
https://github.com/vcmi/vcmi/issues/2134 [^]
(0008661)
Ivan   
2023-06-30 12:28   
Fixed in 1.3