MantisBT - VCMI
View Issue Details
0000924VCMIMechanics - Otherpublic2012-04-09 16:232016-01-30 07:32
amd64Ubuntu12.04 beta2
0000924: Unnatural creatures in hero slot from tavern
Tested on r2621. See attached image:
I have 2 Castles and decided to buy new hero (Demoniac).
It has 2 creatures from Inferno and 1 from Castle.
I never seen different types of creature in tavern, so is it bug vcmi or feature?
No tags attached.
png creatures.png (920,470) 2012-04-09 16:23

7z Autosave_1.7z (163,673) 2012-04-10 03:30
png e1.png (357,186) 2012-04-10 07:00

txt HOTRAITS.TXT (8,143) 2012-04-10 11:26
Issue History
2012-04-09 16:23q4aNew Issue
2012-04-09 16:23q4aFile Added: creatures.png
2012-04-10 02:30TowNote Added: 0002349
2012-04-10 02:30TowAssigned To => Tow
2012-04-10 02:30TowStatusnew => feedback
2012-04-10 03:30q4aFile Added: Autosave_1.7z
2012-04-10 03:43q4aNote Added: 0002350
2012-04-10 03:43q4aStatusfeedback => assigned
2012-04-10 04:08TowNote Added: 0002351
2012-04-10 06:34q4aNote Added: 0002352
2012-04-10 07:00q4aFile Added: e1.png
2012-04-10 09:22IvanNote Added: 0002353
2012-04-10 11:26q4aFile Added: HOTRAITS.TXT
2012-04-10 11:28q4aNote Added: 0002354
2012-04-11 03:19TowNote Added: 0002355
2015-12-21 14:22SXXAssigned ToTow => SXX
2016-01-30 07:32vmarkovtsevNote Added: 0006384
2016-01-30 07:32vmarkovtsevStatusassigned => closed
2016-01-30 07:32vmarkovtsevResolutionopen => fixed
2016-01-30 07:32vmarkovtsevFixed in Version => 0.97c

2012-04-10 02:30   
Seems to be a bug in config files. Initial army is defined in txt config files, so you can give any hero any creature, but third creature of Marius is by default a Hell Hound.

Plese check if it is reproducible. Eg. put Marius on map with default army and check, what will appear when the game is started. You may need to start it over a few times, until Marius gets three stacks, recently introduced Ctrl+R can come handy.

In r2622 I've added additional diagnostics for this. When encountering an unknown creature in hero config it should spit out the searched creature name and available list.
2012-04-10 03:43   
I have uploaded save game, where Marius has 3rd creature = Pikeman, but I cannot find txt file, where initial army is defined.
vcmi/config/creatures.json - contain only abilities of creatures.
vcmi/config/hero.json - contain only start skill/spell.
Where is config file for initial army of hero?
2012-04-10 04:08   
It's OH3 config file: HOTRAITS.TXT in h3bitmap.lod (or Data/ subfolder).
2012-04-10 06:34   
HOTRAITS.TXT looks fine and I cannot reproduce this bug with Marius on map with default army.
I got such bug 3-4 times in a week, so it's hard to reproduce and it happened only with hero from tavern + not on the 1st game's week.
Did you load attached Autosave_1? is it helpful?
2012-04-10 09:22   
Just in case - can you upload your HOTRAITS file? It can be localization issue or some weird formatting in it.
2012-04-10 11:28   
I've uploaded HOTRAITS.TXT.
Also, you can see on attached e1.png, that Marius has 3rd creature = Hell Hound, if Marius placed on map with default army.
2012-04-11 03:19   
I've checked the save game. Apparently HOTRAITS and starting army entries are correct. The problem lies in the Reference Name => creature id mapping. I've extracted the list from the savegame: [^] It's missing many entries, AFAIR there should be more than 200 of them. Hell Hound is also missing.

The list is created by "creatures"->"name" entries in the config/creatures.json. But (assuming you haven't touched the file) I have no idea, why the list was incomplete, especially if the issue is not reproducible.
2016-01-30 07:32   
This ancient issue is no longer reproducible anyhow and was fixed.