MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000091VCMIGUI - Otherpublic2009-10-04 12:162022-04-12 11:19
ReporterTow dragon 
Assigned ToAVS 
PrioritylowSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.73 
Target VersionFixed in Version0.99 
Summary0000091: If hero has expert Air Magic, the Magic Arrow in Spell Book is shown with expert Earth Magic (UPDATED)
DescriptionIf the hero has 2 or more Magic Schools of the same highest level, VCMI picks them for the Magic Arrow icon frame in the following order:
1. Fire Magic
2. Air Magic
3. Water Magic
4. Earth Magic

In H3 the order was as follows:
1. Air Magic
2. Fire Magic
3. Earth Magic
4. Water Magic

Side bug:
Magic Arrow was also always (?) displayed 2nd after Haste in the spell book in H3. In VCMI it's 1st, while Haste is 2nd.
Steps To ReproduceSee the spell books of Septienna, Aislinn, Inteus & Sir Mullich in the map attached. Each has a different combination of 2 Expert Magic schools (however you'll first have to fix 0000482 if you want to open Septienna's spell book under VCMI ;)
Additional InformationOriginally reported as 0.73#29 here: http://forum.vcmi.eu/viewtopic.php?p=3189#3189 [^]
TagsNo tags attached.
Relationships
Attached Filesjpg 2010-11-18_MArrow083.jpg (37,215) 2010-11-17 23:29
https://bugs.vcmi.eu/file_download.php?file_id=603&type=bug
jpg

jpg 2010-11-18_MArrowH3.jpg (13,178) 2010-11-17 23:30
https://bugs.vcmi.eu/file_download.php?file_id=604&type=bug
jpg

?  VCMI_Tests_Objects.h3m (15,852) 2010-11-17 23:53
https://bugs.vcmi.eu/file_download.php?file_id=605&type=bug
Issue History
Date ModifiedUsernameFieldChange
2009-10-04 12:16Tow dragonNew Issue
2009-10-18 22:54ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=269#r269
2009-11-21 18:33ZamolxisNote Added: 0000254
2009-11-21 18:33ZamolxisStatusnew => confirmed
2010-05-29 20:57ZamolxisProduct Version => 0.73
2010-05-29 20:58ZamolxisNote Deleted: 0000254
2010-07-12 12:01ZamolxisNote Added: 0001057
2010-07-21 10:11TowNote Added: 0001146
2010-07-21 10:11TowStatusconfirmed => resolved
2010-07-21 10:11TowFixed in Version => 0.89
2010-07-21 10:11TowResolutionopen => fixed
2010-07-21 10:11TowAssigned To => Tow
2010-11-17 23:29ZamolxisFile Added: 2010-11-18_MArrow083.jpg
2010-11-17 23:30ZamolxisFile Added: 2010-11-18_MArrowH3.jpg
2010-11-17 23:43ZamolxisSummaryIf hero has expert Air Magic, the Magic Arrow in Spell Book is shown with expert Earth Magic. => If hero has expert Air Magic, the Magic Arrow in Spell Book is shown with expert Earth Magic (UPDATED)
2010-11-17 23:43ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1179#r1179
2010-11-17 23:43ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=1181#r1181
2010-11-17 23:51ZamolxisNote Added: 0001419
2010-11-17 23:51ZamolxisStatusresolved => feedback
2010-11-17 23:51ZamolxisResolutionfixed => reopened
2010-11-17 23:53ZamolxisFile Added: VCMI_Tests_Objects.h3m
2010-11-17 23:57ZamolxisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1183#r1183
2012-02-27 12:24WarmongerStatusfeedback => assigned
2012-02-27 12:24WarmongerAssigned ToTow => Warmonger
2012-06-14 15:12douggie_mNote Added: 0002674
2016-10-16 23:40AVSAssigned ToWarmonger => AVS
2016-10-17 05:08AVSNote Added: 0006843
2016-10-17 05:09AVSStatusassigned => resolved
2016-10-17 05:09AVSFixed in Version0.82 => 0.99
2016-10-17 05:09AVSResolutionreopened => fixed
2022-04-12 11:19PovelitelStatusresolved => closed

Notes
(0001057)
Zamolxis   
2010-07-12 12:01   
The screenshot attached to 0000527 can be used to confirm bug is still there in 0.81
(0001146)
Tow   
2010-07-21 10:11   
Fixed in r1679
(0001419)
Zamolxis   
2010-11-17 23:51   
Improperly fixed (or else another change altered its behavior in 083).

See updated Description above:
- now the order of magic school picked is the one in the Map Editor (which makes me think it's like this since the fix)
- the H3 order was slightly different: Air>Fire>Earth>Water (I guess based on the logic that in general Earth is above Water, Fire above Earth, Air above Fire)
- a side minor issue noticed while doing comparative analysis on this between H3 & VCMI: in H3 Haste is always first, in VCMI Magic Arrow (if not a trivial change, then I can create a separate low report for this, so that you don't have to keep this one from being closed if the icon thing is solved)
(0002674)
douggie_m   
2012-06-14 15:12   
Sorry, but this is correct. As I recall, Magic Arrow always was "universal", not air. And if your hero mastered, say, earth magic, then Magic Arrow would advance too, and it is okay for it to be displayed with sign(s) of any of four schools. It is not "air magic" specialty.

Internets are agree with me:
http://www.rpglegion.com/heroes3/spells/earth.htm [^]
http://www.rpglegion.com/heroes3/spells/water.htm [^]
http://www.rpglegion.com/heroes3/spells/fire.htm [^]
http://www.rpglegion.com/heroes3/spells/air.htm [^]

http://heroes.thelazy.net/wiki/Magic_Arrow [^]

> Magic Arrow belongs to all schools of magic. The school with the highest level will be used for calculations. If a unit has resistance or vulnerability to a certain school, they will transfer to Magic Arrow as well, regardless of the skills of the casting hero.
(0006843)
AVS   
2016-10-17 05:08   
fixed in https://github.com/vcmi/vcmi/pull/240 [^]