MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000814VCMISound, music, videospublic2011-09-20 09:022018-01-27 16:13
ReporterZamolxis 
Assigned ToSXX 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.86 
Target VersionFixed in Version1.next 
Summary0000814: Except for resources, all removable map objects are missing the pickup sound
DescriptionWhenever we remove an object from the Adventure Map, the game should play at random one of the 'pickup01.wav' to 'pickup07.wav' sounds, while the object disappears from the map (the sound may start playing while the previous sound specific for the found object is still on).

Right now in VCMI, only when picking up resources, the pickup sound plays as expected as they disappear from the map. For all the others it's missing:
- artifacts
- scrolls
- treasure chests
- Pandora's boxes
- quest/border guards
(and any other removable object I may have missed, including Spell Book and War Machines, which in WoG can be picked up as well)

Note: the sound should be heard when the objects disappear, not when the hero reaches them, so after we close the pop-up window(s) which we may get at pickup.
Steps To Reproduce
Additional InformationThe map from 0000815 can be used to test the implementation. It should have all removable objects within one day reach of one or another hero.
TagsNo tags attached.
Relationships
related to 0000816closed Fay All removable map objects should have a fade out effect when picked 
related to 0000817closed Warmonger Artifacts and Spell Scrolls should disappear from the Adventure Map after the related message window closes, not before 
related to 0001630resolved SXX some sound effects are missing 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-09-20 09:02ZamolxisNew Issue
2011-09-20 09:05ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1406#r1406
2011-09-20 09:17WarmongerStatusnew => assigned
2011-09-20 09:17WarmongerAssigned To => Warmonger
2011-09-20 09:28ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1407#r1407
2011-09-20 09:36ZamolxisIssue cloned: 0000816
2011-09-20 09:36ZamolxisRelationship addedrelated to 0000816
2011-09-20 09:38ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1408#r1408
2011-09-20 09:44ZamolxisRelationship addedrelated to 0000817
2011-09-20 09:44ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1409#r1409
2011-09-20 10:00ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=1411#r1411
2013-12-24 09:51WarmongerRelationship addedrelated to 0001630
2015-02-16 11:00SXXNote Added: 0005526
2016-09-25 18:23SXXAssigned ToWarmonger => SXX
2017-09-13 07:36SXXNote Added: 0007280
2018-01-27 16:13SXXStatusassigned => resolved
2018-01-27 16:13SXXFixed in Version => 1.next
2018-01-27 16:13SXXResolutionopen => fixed

Notes
(0005526)
SXX   
2015-02-16 11:00   
At moment pickup sounds work for everything except border/quests guards.
(0007280)
SXX   
2017-09-13 07:36   
Implemented in PR195:
https://github.com/vcmi/vcmi/pull/195 [^]