MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000809VCMIOtherpublic2011-09-10 16:212014-05-30 17:40
Reportervaderas 
Assigned Toubuntux 
PrioritylowSeveritytrivialReproducibilityalways
StatusclosedResolutionno change required 
PlatformwindowsOS7OS Version
Product Version 
Target VersionFixed in Version0.87 
Summary0000809: zvs folder misplaced
Descriptionzvs folder should be located on data folder, so the path to in CCreatureSet.cpp Line 859 should be
fileName = "Data/zvs/Lib1.res/" + fileName;
instead of
fileName = "zvs/Lib1.res/" + fileName;
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-09-10 16:21vaderasNew Issue
2011-09-13 02:34ubuntuxNote Added: 0002011
2011-09-13 02:34ubuntuxStatusnew => resolved
2011-09-13 02:34ubuntuxResolutionopen => fixed
2011-09-13 02:34ubuntuxAssigned To => ubuntux
2011-09-13 05:32WarmongerStatusresolved => new
2011-09-13 05:33WarmongerStatusnew => resolved
2011-09-13 05:33WarmongerFixed in Version => 0.89
2011-09-13 05:57WarmongerNote Added: 0002012
2011-09-13 05:57WarmongerAssigned Toubuntux =>
2011-09-13 05:57WarmongerStatusresolved => new
2011-09-13 05:57WarmongerNote Edited: 0002012bug_revision_view_page.php?bugnote_id=2012#r1398
2011-09-13 05:58WarmongerNote Edited: 0002012bug_revision_view_page.php?bugnote_id=2012#r1399
2011-09-13 05:59WarmongerNote Edited: 0002012bug_revision_view_page.php?bugnote_id=2012#r1400
2011-09-13 05:59WarmongerNote Edited: 0002012bug_revision_view_page.php?bugnote_id=2012#r1401
2011-09-13 13:07ubuntuxNote Added: 0002013
2011-09-13 13:08ubuntuxNote Edited: 0002013bug_revision_view_page.php?bugnote_id=2013#r1403
2011-09-13 13:09WarmongerNote Added: 0002014
2011-09-13 13:35vaderasNote Added: 0002015
2011-09-13 15:51IvanNote Added: 0002016
2011-09-14 06:12WarmongerNote Added: 0002017
2011-09-14 06:12WarmongerAssigned To => Ivan
2011-09-14 06:12WarmongerStatusnew => confirmed
2011-09-14 14:32vaderasNote Added: 0002019
2011-09-23 16:01IvanStatusconfirmed => resolved
2011-09-23 16:01IvanResolutionfixed => no change required
2011-09-23 16:01IvanAssigned ToIvan => ubuntux
2014-05-30 17:40beegeeStatusresolved => closed

Notes
(0002011)
ubuntux   
2011-09-13 02:34   
Fixed in r2382
(0002012)
Warmonger   
2011-09-13 05:57   
(edited on: 2011-09-13 05:59)
What the hell are you doing there?

Now I got the following:
Failed to find file Data/zvs/Lib1.res/E_SPBERS.bmp
Failed to find file Data/zvs/Lib1.res/E_SPHYPN.bmp
Failed to find file Data/zvs/Lib1.res/E_SPBLIND.bmp
Failed to find file Data/zvs/Lib1.res/E_DRAGON.bmp

Data\directory is default search folder. After your patch graphics stopped working.
(0002013)
ubuntux   
2011-09-13 13:07   
(edited on: 2011-09-13 13:08)
Well, that's exactly what I got before the patch. After patching I didn't get them anymore.
So there might be a linux/windows issue here.
(0002014)
Warmonger   
2011-09-13 13:09   
Ahh, sorry. Now that is tricky.
(0002015)
vaderas   
2011-09-13 13:35   
it's definitely a linux/windows issue, since default paths are handled differently in each system. Thus, it would be best to assign the "default" path to see the root folder, that is the folder of the executable created (and the folder containing the various dlls) and this is the trunk folder.So default should be the trunk folder and should be hardcoded explicitly in the project files for each operating system. In windows that i know, it's the path declared on the Debugging field under VC++ search paths under configuration properties for the project
(0002016)
Ivan   
2011-09-13 15:51   
>> So there might be a linux/windows issue here.
Not sure. For me only version without "Data" works. Maybe you don't have these files (they're coming from WOG)

@vaderas
you're talking about DATA_DIR define - "." on Win, something like "/usr/share/vcmi" on Linux
Image loading is a bit different due to .lod files. LodHandler checks for files in 2 locations - .lod file itself and additional directory - DATA_DIR/Data/
So "Data" directory is not missing - it will be added to path later
(0002017)
Warmonger   
2011-09-14 06:12   
Works now.
(0002019)
vaderas   
2011-09-14 14:32   
@ivan
i guess you 're right, i hadnt seen the lodhandler and the global header file, although i still find it a little confusing for a newcomer to see DATA_DIR defined as ./ and not as ./Data/! but, we can live with that too :) !