MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000720VCMIGUI - Adventure Mappublic2011-03-31 22:582011-11-01 20:38
Reporterplush 
Assigned ToZamolxis 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformAMD64OSFreeBSDOS Version8.2
Product Version0.84 
Target VersionFixed in Version0.85 
Summary0000720: [PATCH] Add support for 1920x1080 resolution
DescriptionI have created the images required for 1920x1080 resolution support. These are largely based on the 1680x1050 images with some minor tweaks inspired by the images used at lower sizes.
Steps To Reproduce
Additional InformationThe three new Data files are available at:

http://www.fabianowski.de/Data.zip [^]

A patch that adds the resolution to the configuration file is at:

http://www.fabianowski.de/patch_config_settings.txt [^]
TagsNo tags attached.
Relationships
Attached Files? AdvMap.bmp (481,878) 2011-04-02 01:31
https://bugs.vcmi.eu/file_download.php?file_id=704&type=bug
bmp
Issue History
Date ModifiedUsernameFieldChange
2011-03-31 22:58plushNew Issue
2011-04-01 17:01WarmongerSeverityminor => feature
2011-04-02 01:18ZamolxisNote Added: 0001668
2011-04-02 01:18ZamolxisAssigned To => Zamolxis
2011-04-02 01:18ZamolxisStatusnew => feedback
2011-04-02 01:19ZamolxisNote Edited: 0001668bug_revision_view_page.php?bugnote_id=1668#r1294
2011-04-02 01:20ZamolxisNote Edited: 0001668bug_revision_view_page.php?bugnote_id=1668#r1295
2011-04-02 01:28plushNote Added: 0001669
2011-04-02 01:28plushStatusfeedback => assigned
2011-04-02 01:31ZamolxisFile Added: AdvMap.bmp
2011-04-02 01:34ZamolxisNote Added: 0001670
2011-04-02 01:34ZamolxisStatusassigned => feedback
2011-04-02 01:36ZamolxisNote Edited: 0001670bug_revision_view_page.php?bugnote_id=1670#r1297
2011-04-02 01:44ZamolxisNote Edited: 0001670bug_revision_view_page.php?bugnote_id=1670#r1298
2011-04-02 01:46ZamolxisNote Edited: 0001670bug_revision_view_page.php?bugnote_id=1670#r1299
2011-04-02 01:51plushNote Added: 0001671
2011-04-02 01:51plushStatusfeedback => assigned
2011-04-02 07:13WarmongerNote Added: 0001672
2011-04-03 00:14ZamolxisNote Edited: 0001670bug_revision_view_page.php?bugnote_id=1670#r1300
2011-04-03 01:48ZamolxisNote Added: 0001675
2011-04-03 01:48ZamolxisStatusassigned => confirmed
2011-04-03 01:59ZamolxisNote Edited: 0001675bug_revision_view_page.php?bugnote_id=1675#r1302
2011-04-03 02:00ZamolxisNote Edited: 0001675bug_revision_view_page.php?bugnote_id=1675#r1303
2011-04-03 02:00ZamolxisNote Edited: 0001675bug_revision_view_page.php?bugnote_id=1675#r1304
2011-05-03 03:13TowNote Added: 0001706
2011-05-03 03:13TowStatusconfirmed => resolved
2011-05-03 03:13TowFixed in Version => 0.89
2011-05-03 03:13TowResolutionopen => fixed
2011-11-01 20:38ZamolxisNote Added: 0002123
2011-11-01 20:38ZamolxisStatusresolved => closed

Notes
(0001668)
Zamolxis   
2011-04-02 01:18   
(edited on: 2011-04-02 01:20)
Great job! Very well done.

There are only a couple of minor details which keep it away from perfection (only because they're copied from 1680x1050, which is also not perfect):
> Settings.txt: HeroList & TownList should start at y=198 i/o 201
> AdvMap1920x1080.pcx: The HeroList & TownList should move 2 pixels higher (closer to the upper scroll arrow), and the lower scroll arrow should follow (I think 3 pixels up). As a result of this, you might have a bit of extra space at the bottom. You can chose to leave it like this add a 20th hero & town to the lists.

But take the above only as suggestions, in case you have time for it. Otherwise I'll do it this summer before the 0.9 release, when I was planning to go through all resolutions and correct all these minor issues.
(0001669)
plush   
2011-04-02 01:28   
The spacing between the arrows and the first/last list entry seems to be very inconsistent. I think what you are describing is 2 pixels spacing. This is used at 1280x1024 resolution. All other resolutions use something different. I was puzzled by this difference but could not figure out which is the 100% correct spacing.

Is there some way to extract the original 800x600 image so that I can verify what the spacing should be? I can then make an updated image.
(0001670)
Zamolxis   
2011-04-02 01:34   
(edited on: 2011-04-03 00:14)
I've attached here the original 800x600 bitmap (I extracted it long time ago... forgot where from exactly).

You can see that the spacing between scroll arrows & hero/town slots is invariable: 2 pixels.

Also, I did say above that with the current .pcx, the hero/town lists should start at y=198. But if you add a 20th slot, you can see how the whole hero/town list fits better in the frame, as it could actually start as high as y=196 if you want (there are more pixels between the upper scroll arrow and the frame in 1680x1050 which you took as source, then in the original 800x600 > so you have some freedom in looking for a good alignment on the vertical).
(0001671)
plush   
2011-04-02 01:51   
Thanks for the bitmap. I corrected the spacing. As you suspected, this made enough space for another list entry. The lists start at y=197 now as this gives the most balanced alignment.

I have updated Data.zip and patch_config_settings.txt in place.
(0001672)
Warmonger   
2011-04-02 07:13   
Now I like it, though have no monitor to test such high resolution :D

Full HD appears to be overkill, yet many people voted for it in Zam's poll, so it may be worth it.
(0001675)
Zamolxis   
2011-04-03 01:48   
(edited on: 2011-04-03 02:00)
y=197 was indeed the best choice. When I looked more closely for the correct positioning today, I realized hero/town lists should ideally start on the same line with the middle buttons (i.e.: Kingdom Overview button), and that starts at pixel line 197.

I'm moving this to "Confirmed" and I posted on the forum an archive with all the necessary files (including the full Settings.txt file updated): http://forum.vcmi.eu/viewtopic.php?p=5617#5617 [^]

@Tow: if you decide to include this in the next release, I guess you can move this report further to Resolved/Fixed in 0.next.
(0001706)
Tow   
2011-05-03 03:13   
New settings.txt has been committed into SVN in r2102. The next released build package will be containing needed graphics, ATM the whole thing can be obtained from http://forum.vcmi.eu/download.php?id=380 [^] .
(0002123)
Zamolxis   
2011-11-01 20:38   
Tested in 0.86 and confirmed as working fine.