MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000583VCMIMechanics - Objectspublic2010-07-31 11:572014-05-30 17:39
ReporterZamolxis 
Assigned ToWarmonger 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAMD 5600+OSWindowsOS VersionXP SP3
Product Version0.81d 
Target VersionFixed in Version0.83 
Summary0000583: Stables' 1-week cycle starts 1 day earlier and can last for 8 days (as result we get double bonus on Day 7 for the day)
DescriptionSee attached savegame (hopefully compatible with 0.82 as well, if you don't check this today, otherwise should be easily reproducible). I first noticed something was wrong when I went with Ivor & Rion back to Stables on day 7, after they have previously been there that week, and got a bonus again. Then on day 1 of the next week I wanted to visit again, and I got the message that I've already visited it.

I've done some more tests, and the bug is as follows:
- When it comes to granting the bonus, the 1-week cycle starts on Day 7 and ends on Day 6 of the next week.
- The expiry date of that bonus though, is a Day 7, but if we got the bonus on a Day 7, it'll only expire on the next one (in 8 days)

As a result of this, we can have a double bonus on Day 7: once from the previous visit the last 7 days, and once from visiting the site again on Day 7. This double bonus expires though at the end of the day, and the next 7 days we have just the normal bonus from our last visit.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000345closed Warmonger Stables should increase movement for the first day you enter 
Attached Files7z 2010-07-31_Stables0.81d.7z (68,158) 2010-07-31 11:57
https://bugs.vcmi.eu/file_download.php?file_id=541&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-07-31 11:57ZamolxisNew Issue
2010-07-31 11:57ZamolxisStatusnew => assigned
2010-07-31 11:57ZamolxisAssigned To => Warmonger
2010-07-31 11:57ZamolxisFile Added: 2010-07-31_Stables0.81d.7z
2010-07-31 11:57ZamolxisIssue generated from: 0000345
2010-07-31 11:57ZamolxisRelationship addedrelated to 0000345
2010-07-31 11:58ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1069#r1069
2010-08-15 16:27WarmongerNote Added: 0001316
2010-08-15 16:27WarmongerStatusassigned => resolved
2010-08-15 16:27WarmongerFixed in Version => 0.89
2010-08-15 16:27WarmongerResolutionopen => fixed
2014-05-30 17:39beegeeStatusresolved => closed

Notes
(0001316)
Warmonger   
2010-08-15 16:27   
Fixed in r1744. The bug was general for all one-week bonuses.