MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000516VCMIGUI - Otherpublic2010-07-04 23:572014-05-30 17:39
ReporterZamolxis 
Assigned ToTow 
PrioritylowSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.81 
Target VersionFixed in Version0.82 
Summary0000516: "This an abandoned shipyard" message in case the ways are blocked
DescriptionThe message that we get in case the ways to a shipyard are blocked by anything except a boat (see my note to 0000370) differs from the one in H3.

VCMI: We get the message in the 2nd screenshot attached to 0000246, which is grammatically incorrect.

H3 (at least my version): We get the message in the screenshot attached to this report. H3 uses the name of the selected hero. If no hero is selected when we click on the shipyard, the first hero in our list gets selected and his/her name is then used in the message. The "problem" with the H3 behavior is that the selected hero might be in the corner of a map, and the shipyard 5 days away in the other corner, while the message still says "... encounters".

SUGGESTION: As linking this shipyard message to the code of the list of adventure map heroes would anyway unnecessary complicate the code, I suggest we keep the current message, but just make it grammatically correct (i.e.: "This is an abandoned shipyard").

Also - a less important detail - the word "Ways" in the second phrase should not use capital letter. Though it can be that NWC wanted it like this as a hint, so if this is harder to correct, you can just leave it as it is.
Steps To Reproduce
Additional InformationThe map attached to 0000370 can be used for tests/reproducing.
TagsNo tags attached.
Relationships
related to 0000246closed Warmonger Shipyard the cannot buy boat text if one boat is already bought 
parent of 0000547closed Tow Double click on the town in Adv Map cause that shipyard message appears in town 
Attached Filesjpg 2010-07-04_HeroEncountersBlockedShipyard.jpg (46,136) 2010-07-04 23:57
https://bugs.vcmi.eu/file_download.php?file_id=446&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2010-07-04 23:57ZamolxisNew Issue
2010-07-04 23:57ZamolxisFile Added: 2010-07-04_HeroEncountersBlockedShipyard.jpg
2010-07-04 23:57ZamolxisIssue generated from: 0000246
2010-07-04 23:57ZamolxisRelationship addedrelated to 0000246
2010-07-05 00:00ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=907#r907
2010-07-05 00:55ZamolxisCategoryGUI - Adventure Map => GUI - Other
2010-07-08 05:34WarmongerStatusnew => assigned
2010-07-08 05:34WarmongerAssigned To => Warmonger
2010-07-13 05:33TowNote Added: 0001061
2010-07-13 05:33TowStatusassigned => resolved
2010-07-13 05:33TowFixed in Version => 0.89
2010-07-13 05:33TowResolutionopen => fixed
2010-07-13 05:33TowAssigned ToWarmonger => Tow
2010-07-25 12:34IvanNote Added: 0001164
2010-07-25 12:34IvanStatusresolved => feedback
2010-07-25 12:34IvanResolutionfixed => reopened
2010-07-25 17:31IvanRelationship addedparent of 0000547
2010-07-26 15:40TowNote Added: 0001171
2010-07-26 15:40TowStatusfeedback => resolved
2010-07-26 15:40TowResolutionreopened => fixed
2014-05-30 17:39beegeeStatusresolved => closed

Notes
(0001061)
Tow   
2010-07-13 05:33   
Partially fixed in r1649
If shipyard has been visited then "%s encounters an abandoned..." message is used.
If shipyard has been activated by l-clicking it on adventure map, then we have "This an abandoned shipyard...".

I have not corrected the wording of second message (missing "is"). It's not an engine issue, it can be easily fixed by altering original language files.
(0001164)
Ivan   
2010-07-25 12:34   
Minor problem here - this message shows up even when opening towns (only on mouse double-click - hero visiting is fine)
This message is useless in towns - blocked harbors will be removed on map loading (h3 behavior which I've added some time ago)
(0001171)
Tow   
2010-07-26 15:40   
Fixed in r1691 / handled in 0000547