MantisBT - VCMI
View Issue Details
0000487VCMIMechanics - Adventure Mappublic2010-06-01 20:352014-05-30 17:40
Zamolxis 
Warmonger 
normalcrashrandom
closedfixed 
0.8b 
0.82 
0000487: Seer's Hut shows as visited after Load + Seer name fail + Crash after visiting the Hut (only after Load)
See 1st screenshot: it's what we get first time when we visit the Hut. Also seer's name fails (%), both in this message and in the message we get if we play from starters (no save/load). After Load, if we visit the Hut, we get a crash when we want to leave further. Crashdump attached.
Map Manifest Destiny. Save/Load. Go underground through the gate in the center of the map. The Seer Hut up-left from the gate.

EDIT: You can also reproduce in 0.81 by using the saved game attached to 0000488, go underground and visit the Hut to reproduce the bug. Remember, the crash happens when you leave the hut (hero seems to be able to move a couple of tiles before the crash).
No tags attached.
related to 0000427closed yupsi Quest Guards / Seer's Hut - messages are not implemented 
jpg 2010-06-01_08bSeer.jpg (29,504) 2010-06-01 20:35
https://bugs.vcmi.eu/file_download.php?file_id=400&type=bug
jpg

jpg 2010-06-01_08bSeerCrash.jpg (90,381) 2010-06-01 20:35
https://bugs.vcmi.eu/file_download.php?file_id=401&type=bug
jpg

7z 2010-06-01_08bSeerCrash.7z (112,730) 2010-06-01 20:35
https://bugs.vcmi.eu/file_download.php?file_id=402&type=bug
Issue History
2010-06-01 20:35ZamolxisNew Issue
2010-06-01 20:35ZamolxisFile Added: 2010-06-01_08bSeer.jpg
2010-06-01 20:35ZamolxisFile Added: 2010-06-01_08bSeerCrash.jpg
2010-06-01 20:35ZamolxisFile Added: 2010-06-01_08bSeerCrash.7z
2010-06-01 21:12ZamolxisNote Added: 0000915
2010-06-01 21:14ZamolxisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=866#r866
2010-06-01 21:14ZamolxisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=867#r867
2010-06-02 06:26WarmongerStatusnew => assigned
2010-06-02 06:26WarmongerAssigned To => Warmonger
2010-06-02 06:27WarmongerNote Added: 0000928
2010-06-02 11:00ZamolxisNote Added: 0000929
2010-06-02 11:00ZamolxisStatusassigned => feedback
2010-06-02 12:20majaczekNote Added: 0000930
2010-06-02 16:11TowNote Added: 0000931
2010-06-02 17:20WarmongerNote Added: 0000932
2010-06-02 17:20WarmongerNote Edited: 0000932bug_revision_view_page.php?bugnote_id=932#r873
2010-06-02 18:20WarmongerNote Edited: 0000932bug_revision_view_page.php?bugnote_id=932#r874
2010-06-03 06:26WarmongerRelationship addedrelated to 0000427
2010-06-06 09:53WarmongerNote Added: 0000944
2010-06-06 09:53WarmongerStatusfeedback => resolved
2010-06-06 09:53WarmongerFixed in Version => 0.89
2010-06-06 09:53WarmongerResolutionopen => fixed
2010-06-06 09:58WarmongerNote Added: 0000945
2010-06-06 09:58WarmongerStatusresolved => feedback
2010-06-06 09:58WarmongerResolutionfixed => reopened
2010-06-06 09:58WarmongerNote Deleted: 0000944
2010-06-06 09:58WarmongerNote Deleted: 0000945
2010-06-06 10:14WarmongerNote Added: 0000946
2010-06-19 19:11WarmongerRelationship addedrelated to 0000506
2010-06-20 03:34WarmongerRelationship deletedrelated to 0000506
2010-07-19 18:32WarmongerNote Added: 0001135
2010-07-19 18:32WarmongerStatusfeedback => resolved
2010-07-19 18:32WarmongerResolutionreopened => fixed
2011-10-16 19:32yupsiNote Added: 0002089
2011-10-16 19:32yupsiStatusresolved => feedback
2011-10-16 19:32yupsiResolutionfixed => reopened
2011-10-18 11:29WarmongerNote Added: 0002092
2011-10-19 07:12yupsiStatusfeedback => resolved
2011-10-19 07:12yupsiResolutionreopened => fixed
2014-05-30 17:40beegeeStatusresolved => closed

Notes
(0000915)
Zamolxis   
2010-06-01 21:12   
Reproducible in 0.81. Let me know if you need crashdump from 0.81 as well.
(0000928)
Warmonger   
2010-06-02 06:27   
Can you tell what kind of quest / reward it is?
(0000929)
Zamolxis   
2010-06-02 11:00   
There is no quest for the object (which is strange, because I think Manifest Destiny is a standard RoE map which came with the original game)

And I can say now that we have 3 bugs related to this:

1 - A first small bug would be that even before visiting it for the 1st time, if we R-click on it, it tells us the name of the Seer. Before the 1st visit, it should say only "Seer's Hut"

2 - Then we have the message when we visit the object, which fails to load the Seer's name (we get "%", while R-click before showed us the name of the Seer)

3 - And lastly we have the crash when we move further. It's a strange crash because sometimes it happens when moved only a couple of tiles, other times when we moved like 7-8 tiles.
(0000930)
majaczek   
2010-06-02 12:20   
I believe the visit to the seer make memory corrupt (something with pointers)
So if it's the case the few tiles later corrupted memory were used and done crash (was the corrupted memory a place for pointer/reference_address ?)
(0000931)
Tow   
2010-06-02 16:11   
Checked the crashdump:
crash at: ms << "\n\n" << VLC->generaltexth->quests[missionType-1][3][textOption];
Stack trace:
> VCMI_lib.dll!CGSeerHut::getHoverText() Line 3296 + 0x56 bytes C++
     VCMI_client.exe!CCallback::getObjDescriptions(int3 pos={...}) Line 273 + 0x7 bytes C++
     VCMI_client.exe!CAdvMapInt::tileHovered(const int3 & tile={...}) Line 1824 + 0x31 bytes C++
     VCMI_client.exe!CTerrainRect::mouseMoved(const SDL_MouseMotionEvent & sEvent={...}) Line 511 C++
     VCMI_client.exe!CGuiHandler::handleMoveInterested(const SDL_MouseMotionEvent & motion={...}) Line 318 + 0x8 bytes C++
     VCMI_client.exe!CGuiHandler::handleMouseMotion(SDL_Event * sEvent=0x073d9808) Line 300 C++
     VCMI_client.exe!CGuiHandler::handleEvent(SDL_Event * sEvent=0x071cbfd8) Line 180 + 0xd bytes C++
     VCMI_client.exe!CGuiHandler::handleEvents() Line 143 C++
     VCMI_client.exe!CPlayerInterface::update() Line 1286 C++
     VCMI_client.exe!CGuiHandler::run() Line 346 C++


Out of bounds vector access?
(0000932)
Warmonger   
2010-06-02 17:20   
(edited on: 2010-06-02 18:20)
I remember having problems with hover tooltip adressing nonexistent object, but thought I've fixed it completely. Let me take another look at it.

(0000946)
Warmonger   
2010-06-06 10:14   
I learned that RoE maps do not support custom messages at all, so should be all randomized. However, when I set them to not custom by default, I'm getting degug assertion fail over and over. It happened also before at random on Seer Huts maps, but now I'm certain it's caused by some odd assertion / synchronization issues.
(0001135)
Warmonger   
2010-07-19 18:32   
Fixed in r1672
(0002089)
yupsi   
2011-10-16 19:32   
I've been tinkering at the related issue (http://bugs.vcmi.eu/view.php?id=427 [^]) and at some moment noticed hover text not updating and showing seer's name from the start. Even reproduced it before resolving that issue (even a seer's hut at RoE "All for one" map near the red castle will do). Did I break something or did the issue return?
(0002092)
Warmonger   
2011-10-18 11:29   
Well, Seer's name should be displayed only after quest as activated. However, it seems I forgot to handle generic "Ser Hut' text, so feel free to fix that.

In general, feel free to fix anything, as I'd rather implement new features than fix old bugs :P