MantisBT - VCMI
View Issue Details
0000456VCMIOtherpublic2010-05-19 15:382010-05-26 22:17
majaczek 
Tow 
lowtrivialN/A
closedfixed 
 
 
0000456: rev1581 uses wrong way operator || in functions of imarket
many functions use construction
if (mode== enum_mode_value1 || enum_mode_value2 || enum_mode_value3) do_something
while these modes are raw enum, not the bitfields so its results as
if (mode==1) do_something
so please somebody to fix
fails concept on any mode!=1
so produces runtime errors on any market mode diffrent from those equal 1 (those equal1 will be used more frequently so it could have time to observe)
its issue on coder side, which may be hard to understand for players and testers which aren't c++ programers (eg. aren't coders of this project)
No tags attached.
Issue History
2010-05-19 15:38majaczekNew Issue
2010-05-26 22:17TowNote Added: 0000874
2010-05-26 22:17TowStatusnew => closed
2010-05-26 22:17TowAssigned To => Tow
2010-05-26 22:17TowResolutionopen => fixed

Notes
(0000874)
Tow   
2010-05-26 22:17   
Fixed, as discussed http://forum.vcmi.eu/viewtopic.php?p=4659#4659 [^]