MantisBT - VCMI
View Issue Details
0000401VCMIGUI - Adventure Mappublic2010-03-02 09:242022-04-12 09:17
Zamolxis 
SXX 
normalfeaturealways
closedfixed 
0.8 
0.98f 
0000401: The "(digging ok)" text should accompany all terrain type info windows
I was waiting to report this until the Grail implementation, but I realize now there's a fat chance they are not really related (technically). If I'm not mistaken, we never have in H3 the case that R-click just says "Grass" for example. It's either "Grass (digging ok)", or else just names the 'object' which is actually on that tile (can be Hole if the case, or anything else: Crater, Oak Trees etc). So I guess this should be an easy fix, as it doesn't depend on the Grail-related parts of the code.
The only detail to have perhaps in mind when implementing this, is that "(digging ok)" should be on the second line. As the info boxes don't always have the same H3 size, I'm thinking we should not end up with the text on 1 line. Or worse, to have only "ok)" on the second line: :)



"Dirt (digging

ok)"



EDIT: After writing this I saw we actually have already an issue with how this extra info is handled. See report 0000402.
No tags attached.
related to 0000402assigned  The extra info (between brackets) for any item on the map should be on a second line in the info window 
related to 0002341new  Digging status: we shouldn't expose invisible objects like placed events 
Issue History
2010-03-02 09:24ZamolxisNew Issue
2010-03-02 09:30ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=643#r643
2010-03-02 09:30ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=645#r645
2010-03-02 09:31ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=646#r646
2010-03-02 09:48ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=647#r647
2012-07-10 12:00IvanAssigned To => Ivan
2012-07-10 12:00IvanStatusnew => assigned
2015-11-29 09:42SXXNote Added: 0006135
2015-11-29 09:42SXXStatusassigned => resolved
2015-11-29 09:42SXXFixed in Version => 0.98f
2015-11-29 09:42SXXResolutionopen => fixed
2015-11-29 09:42SXXAssigned ToIvan => SXX
2015-11-29 09:43SXXNote Edited: 0006135bug_revision_view_page.php?bugnote_id=6135#r3049
2015-11-29 09:43SXXRelationship addedrelated to 0000402
2015-11-29 09:55SXXRelationship addedrelated to 0002341
2022-04-12 09:17PovelitelStatusresolved => closed

Notes
(0006135)
SXX   
2015-11-29 09:42   
(edited on: 2015-11-29 09:43)
Fixed:
https://github.com/vcmi/vcmi/commit/f55bfe41d6a2a538308d9e2656660a131377e7c9 [^]

Though digging need a bit more refactoring.