MantisBT - VCMI
View Issue Details
0000367VCMIMechanics - Otherpublic2010-02-14 03:182010-07-14 09:39
Steven Aus 
Warmonger 
normalminorsometimes
closedfixed 
0.75d 
 
0000367: Crest of Valor is giving a luck bonus instead of a morale bonus.
See the save. =)
No tags attached.
7z Crest of Valor Giving Luck Bonus.7z (123,558) 2010-02-14 03:18
https://bugs.vcmi.eu/file_download.php?file_id=244&type=bug
jpg switched artifacts.jpg (43,112) 2010-02-17 18:39
https://bugs.vcmi.eu/file_download.php?file_id=252&type=bug
jpg
Issue History
2010-02-14 03:18Steven AusNew Issue
2010-02-14 03:18Steven AusFile Added: Crest of Valor Giving Luck Bonus.7z
2010-02-14 06:15WarmongerStatusnew => assigned
2010-02-14 06:15WarmongerAssigned To => Warmonger
2010-02-17 18:39BoulieNote Added: 0000682
2010-02-17 18:39BoulieFile Added: switched artifacts.jpg
2010-02-17 20:09WarmongerNote Added: 0000683
2010-02-17 20:09WarmongerNote Edited: 0000683bug_revision_view_page.php?bugnote_id=683#r594
2010-02-17 20:37majaczekNote Added: 0000684
2010-02-18 08:14BoulieNote Added: 0000685
2010-02-26 11:30TowNote Added: 0000690
2010-02-26 11:30TowStatusassigned => resolved
2010-02-26 11:30TowResolutionopen => fixed
2010-07-14 09:39ZamolxisNote Added: 0001116
2010-07-14 09:39ZamolxisStatusresolved => closed

Notes
(0000682)
Boulie   
2010-02-17 18:39   
All artifacts which give luck and morale are switched.
Clover of Fortune, Cards of Prophecy and Ladybird of luck give morale
Badge of Courage, Crest of Valor and Glyph of Gallantry give luck.
(0000683)
Warmonger   
2010-02-17 20:09   
Now that's somewhat more specific description. Was it introduced only by development version?

(0000684)
majaczek   
2010-02-17 20:37   
in code of handling luck and morale theres some boolean parameter which is treaten reverse... when i was reading the code I thought too that somethings wrong

don't remember where but its boolean comparision
(0000685)
Boulie   
2010-02-18 08:14   
Yes, it seems to be only in development version. In 074 and 075 it is OK.
(0000690)
Tow   
2010-02-26 11:30   
Shame on me. When copy-pasting I switched MORALE with LUCK.
Fixed r1513
(0001116)
Zamolxis   
2010-07-14 09:39   
Verified in 0.81