MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000339VCMIMechanics - Objectspublic2010-01-27 02:302010-07-14 09:36
ReporterSteven Aus 
Assigned ToTow 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.75 
Target VersionFixed in Version0.8 
Summary0000339: Prison (in one map at least) defaults to certain hero (and right-click text says eg. "Orrin the Knight" rather than "Jail").
DescriptionIn the Race for Ardintinny map, the Prison from the Castle's One-Way Teleporter area says "Orrin the Knight". However when I had hired Orrin the Knight from my Castle previously, a doppelganger situation occurred, when display of troops was the same for both the original Orrin and the one from the Prison. Because both heroes had the same ID I think, even the movement points display changes were a bit weird (one from the other and so on). Check out the save to see what's happening. =) Probably a relatively easy bug to fix - I think when a Prison is set up before map start that hero Identity is blocked from all Taverns to prevent having more than one hero with the same identity/ID. Also, Prison right-click text says "Prison" rather than the name and class of the hero inside, which you only find out when freeing the Prison's hero. =)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files7z Orrin Twice.7z (112,255) 2010-01-27 02:30
https://bugs.vcmi.eu/file_download.php?file_id=218&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-01-27 02:30Steven AusNew Issue
2010-01-27 02:30Steven AusFile Added: Orrin Twice.7z
2010-02-01 02:33WarmongerNote Added: 0000602
2010-02-01 02:33WarmongerAssigned ToTow => Warmonger
2010-02-09 18:53WarmongerNote Added: 0000607
2010-02-10 21:34TowNote Added: 0000619
2010-02-10 21:34TowStatusassigned => resolved
2010-02-10 21:34TowFixed in Version => 0.89
2010-02-10 21:34TowResolutionopen => fixed
2010-02-10 21:34TowStatusresolved => assigned
2010-02-10 21:34TowAssigned ToWarmonger => Tow
2010-02-26 11:22TowStatusassigned => resolved
2010-07-14 09:36ZamolxisNote Added: 0001115
2010-07-14 09:36ZamolxisStatusresolved => closed

Notes
(0000602)
Warmonger   
2010-02-01 02:33   
It's more complicated, actually at some point all heroes are called Orrin.
(0000607)
Warmonger   
2010-02-09 18:53   
Ok, I had a look into it and discovered quite bizzare thing: Hero and prison are all instances of same class. Unless there is a good reason for that, I'm going to add new, elegant object for Prison
(0000619)
Tow   
2010-02-10 21:34   
Fixed in r1473.
There was two bugs actually
1) Hero placed in prison was not removed from pool of heroes possible to recruit in tavern
2) All prisons were reset to hold Orrin

Warmonger ->
>>Hero and prison are all instances of same class. Unless there is a good reason for that

There is reason: hero and prison are the same, only difference is picture and that the prison is not owned by any player.
(0001115)
Zamolxis   
2010-07-14 09:36   
R-click still gives the name of the hero, rather than saying "Prison", but I kinda like that behavior actually. Maybe if I know what hero is there, I can reconsider if it's worthy to fight a guard, w/o having to spend time saving & fighting, just to check if it's the hero I'm looking for. Closing.