MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003102VCMIGUI - PreGamepublic2020-01-21 08:402020-01-23 20:02
Reportertoneyisnow 
Assigned Totoneyisnow 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.99 
Target VersionFixed in Version1.next 
Summary0003102: LobbyScreen UI is showing multiple Difficulty options in toggle group when Loading map.
DescriptionScenario: In LoadGame Lobby screen, the difficulty toggle group is showing multiple choices, but actually only one valid is working.

The reason is, in the Lobby screen Initialization code will set the difficulty = 0, and each time the player changes a map in the selection, the toggle group control is not resetting the difficulty buttons to disabled state.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filesjpg 1033189811.jpg (320,489) 2020-01-21 08:40
https://bugs.vcmi.eu/file_download.php?file_id=3048&type=bug
jpg

png fixed.PNG (78,070) 2020-01-21 08:41
https://bugs.vcmi.eu/file_download.php?file_id=3049&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-01-21 08:40toneyisnowNew Issue
2020-01-21 08:40toneyisnowFile Added: 1033189811.jpg
2020-01-21 08:41toneyisnowNote Added: 0007858
2020-01-21 08:41toneyisnowNote Added: 0007859
2020-01-21 08:41toneyisnowFile Added: fixed.PNG
2020-01-23 15:48toneyisnowNote Added: 0007860
2020-01-23 20:02SXXNote Added: 0007861
2020-01-23 20:02SXXStatusnew => resolved
2020-01-23 20:02SXXFixed in Version => 1.next
2020-01-23 20:02SXXResolutionopen => fixed
2020-01-23 20:02SXXAssigned To => toneyisnow

Notes
(0007858)
toneyisnow   
2020-01-21 08:41   
Note:

During the game loading time, the client is loading the map, and send a NetPack to server: LobbySetMap, and send a NetPack to Interface: LobbyUpdateState.
In the LobbyUpdateState it sets the map difficulty.
(0007859)
toneyisnow   
2020-01-21 08:41   
How fix:
Add a new method to ToggleGroup class: setSelectedOnly, which will disable all other buttons and then set the selected button.
(0007860)
toneyisnow   
2020-01-23 15:48   
This is fixed by my pull request https://github.com/vcmi/vcmi/pull/624 [^]
(0007861)
SXX   
2020-01-23 20:02   
Thanks for the fix.