MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003001VCMIModspublic2018-08-25 20:052023-07-28 23:23
Reporterasgraf 
Assigned ToAVS 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusassignedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003001: Ability to learn new spells should be moddable
DescriptionI would like to request new bonus type ALLOW_LEARN_SPELLS that grands hero ability to learn certain spells without need of having Wisdom skill of appropriate level

This new bonus type should be allowed to be limited by:
- spell level (ability to learn spells of certain level including spells added by other mods)
- spell school (ability to learn spells of certain magic school including spells added by other mods)
- spell flags (ability to learn all spells with certain flag like summoning including spells added by other mods)
- hand-picked selection of spell id's (white-listed spells can be learn without Wisdom)

Example use case:
https://forum.vcmi.eu/t/spell-schools-modding/4679 [^]
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-08-25 20:05asgrafNew Issue
2018-08-25 20:07asgrafNote Added: 0007631
2018-08-25 20:11asgrafNote Edited: 0007631bug_revision_view_page.php?bugnote_id=7631#r3519
2018-08-25 20:13asgrafNote Edited: 0007631bug_revision_view_page.php?bugnote_id=7631#r3520
2018-08-26 18:06AVSNote Added: 0007634
2018-08-26 18:06AVSAssigned To => AVS
2018-08-26 18:06AVSStatusnew => feedback
2018-08-27 20:03asgrafNote Added: 0007635
2018-08-27 20:03asgrafStatusfeedback => assigned
2018-08-27 20:05asgrafNote Added: 0007636
2018-08-27 20:07asgrafNote Added: 0007637
2018-08-27 20:07asgrafNote Edited: 0007637bug_revision_view_page.php?rev_id=3525
2018-08-27 20:08asgrafNote Added: 0007638
2018-08-27 20:09AVSNote Added: 0007639
2018-08-27 20:57asgrafNote View State: 0007635: private
2018-08-27 20:57asgrafNote View State: 0007636: private
2018-08-27 20:57asgrafNote View State: 0007637: private
2018-08-27 20:57asgrafNote View State: 0007638: private
2018-08-27 20:58asgrafNote Added: 0007640
2018-08-27 20:58asgrafNote Edited: 0007640bug_revision_view_page.php?bugnote_id=7640#r3527
2018-08-27 20:59asgrafNote Deleted: 0007638
2018-08-27 20:59asgrafNote Deleted: 0007637
2018-08-27 20:59asgrafNote Deleted: 0007636
2018-08-27 20:59asgrafNote Deleted: 0007635
2018-08-27 21:19asgrafNote Added: 0007641
2018-08-27 21:20asgrafNote Edited: 0007641bug_revision_view_page.php?bugnote_id=7641#r3529
2018-08-27 21:26asgrafNote Added: 0007642
2023-07-28 23:23asgrafNote Added: 0008685

Notes
(0007631)
asgraf   
2018-08-25 20:07   
(edited on: 2018-08-25 20:13)
Additionally BAN_SPELLS that prevents spells from being casted (and/or learned) with similar limiters would be useful for custom artifacts
(0007634)
AVS   
2018-08-26 18:06   
Please provide examples of desired JSON configuration.
(0007639)
AVS   
2018-08-27 20:09   
As this is bonus type, it should use https://wiki.vcmi.eu/Bonus_Format, [^] or it most be an extension of it.
(0007640)
asgraf   
2018-08-27 20:58   
[
    {
        "type": "ALLOW_LEARN_SPELLS",
        "subtype": 0,//0 allow spells | 1 ban spells
        "val" : 3,//spell level
        "description" : "Unlock Hero ability to learn level 3 fire spells",
        "limiters": [
            {
                "type":"SPELL_SCHOOL_LIMITER",
                "parameters":["fire"]
            }
        ]
    },
    {
        "type": "ALLOW_LEARN_SPELLS",
        "subtype": 0,//0 allow spells | 1 ban spells
        "val" : 5,//spell level
        "description" : "Unlock Hero ability to learn all summon spells",
        "limiters": [
            {
                "type":"SPELL_EFFECT_LIMITER",
                "parameters":["summon"]
            }
        ]
    },
    {
        "type": "ALLOW_LEARN_SPELLS",
        "description" : "Unlock Hero ability to learn Summon Elemental spells",
        "limiters": [
            {
                "type":"SPELL_ID_LIMITER",
                "parameters":["airElemental","waterElemental","earthElemental","fireElemental"]
            }
        ]
    },
    {
        "type": "ALLOW_LEARN_SPELLS",
        "val" : 3,
        "description" : "Basic Wisdom Equivalent"
    },
    {
        "type": "ALLOW_LEARN_SPELLS",
        "val" : 4,
        "description" : "Advanced Wisdom Equivalent"
    },
    {
        "type": "ALLOW_LEARN_SPELLS",
        "val" : 5,
        "description" : "Expert Wisdom Equivalent"
    }
]
(0007641)
asgraf   
2018-08-27 21:19   
(edited on: 2018-08-27 21:20)
Since new bonus is extension of wisdom bonus, old wisdom effect probably should be deprecated or treated as alias of new ALLOW_LEARN_SPELLS effect.
To avoid functional duplication Wisdom skill should be changed to use this new bonus
(0007642)
asgraf   
2018-08-27 21:26   
I don't know if i restrictions should be listed as limiters or if they should be part of effect in addInfo key.
(0008685)
asgraf   
2023-07-28 23:23   
*** Shameless bump after 5 years of waiting ***
Any chances for implementation?