MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002841VCMIMechanics - Otherpublic2018-01-02 11:182023-10-10 13:48
ReporterPovelitel 
Assigned ToIvan 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.99 
Target VersionFixed in Version 
Summary0002841: Spirit of oppression - incorrect work
DescriptionДух уныния должен снимать только положительные бонусы! Если есть отрицательные, он их не ликвидирует, они остаются на герое.

То есть если у меня мораль -1, то и с духом -1. А здесь получается что при -1 морали когда надеваешь дух уныния, мораль становится нейтральной.


The spirit of oppression should only take off positive bonuses! If there are negative, they do not liquidate them, they remain on the hero.

That is, if I have a moral -1, then with a -1 spirit. And here it turns out that at -1 morality when you put on the spirit of oppression, morality becomes neutral.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001266closed hkoehler Battle-wide bonuses of upgrades do not stack with downgrades. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-02 11:18PovelitelNew Issue
2018-03-19 12:37PovelitelRelationship addedrelated to 0001266
2018-03-19 20:29hkoehlerNote Added: 0007525
2018-03-19 20:40WarmongerNote Added: 0007526
2018-03-19 23:08AVSNote Added: 0007527
2018-03-19 23:14hkoehlerNote Added: 0007528
2018-03-19 23:38AVSNote Added: 0007529
2023-04-11 11:22IvanNote Added: 0008520
2023-04-11 11:22IvanStatusnew => resolved
2023-04-11 11:22IvanResolutionopen => fixed
2023-04-11 11:22IvanAssigned To => Ivan
2023-10-10 13:48PovelitelNote Added: 0008832
2023-10-10 13:48PovelitelStatusresolved => closed

Notes
(0007525)
hkoehler   
2018-03-19 20:29   
It might simply be possible to replace the BLOCKS_MORALE bonus with a MORALE bonus of valType INDEPENDENT_MIN. In which case BLOCKS_MORALE bonus type seems redundant and should be deprecated.
(0007526)
Warmonger   
2018-03-19 20:40   
Not only that, but INDEPENDENT_MIN and INDEPENDENT_MAX set both to 0.
(0007527)
AVS   
2018-03-19 23:08   
INDEPENDENT_MIN will not work because we need to ignore all positive modifiers but not just cap total value at 0.
(0007528)
hkoehler   
2018-03-19 23:14   
That's not how it works in HMM3. There it caps the total morale at 0. E.g. +1 morale, -1 morale and spirit of oppression add up to 0 morale, just tested.
(0007529)
AVS   
2018-03-19 23:38   
OK, then INDEPENDENT_MIN should be enough
(0008520)
Ivan   
2023-04-11 11:22   
Fixed in 1.2
(0008832)
Povelitel   
2023-10-10 13:48   
no longer relevant