MantisBT - VCMI
View Issue Details
0002841VCMIMechanics - Otherpublic2018-01-02 11:182018-03-19 23:38
0002841: Spirit of oppression - incorrect work
Дух уныния должен снимать только положительные бонусы! Если есть отрицательные, он их не ликвидирует, они остаются на герое.

То есть если у меня мораль -1, то и с духом -1. А здесь получается что при -1 морали когда надеваешь дух уныния, мораль становится нейтральной.

The spirit of oppression should only take off positive bonuses! If there are negative, they do not liquidate them, they remain on the hero.

That is, if I have a moral -1, then with a -1 spirit. And here it turns out that at -1 morality when you put on the spirit of oppression, morality becomes neutral.
No tags attached.
related to 0001266closed hkoehler Battle-wide bonuses of upgrades do not stack with downgrades. 
Issue History
2018-01-02 11:18PovelitelNew Issue
2018-03-19 12:37PovelitelRelationship addedrelated to 0001266
2018-03-19 20:29hkoehlerNote Added: 0007525
2018-03-19 20:40WarmongerNote Added: 0007526
2018-03-19 23:08AVSNote Added: 0007527
2018-03-19 23:14hkoehlerNote Added: 0007528
2018-03-19 23:38AVSNote Added: 0007529

2018-03-19 20:29   
It might simply be possible to replace the BLOCKS_MORALE bonus with a MORALE bonus of valType INDEPENDENT_MIN. In which case BLOCKS_MORALE bonus type seems redundant and should be deprecated.
2018-03-19 20:40   
Not only that, but INDEPENDENT_MIN and INDEPENDENT_MAX set both to 0.
2018-03-19 23:08   
INDEPENDENT_MIN will not work because we need to ignore all positive modifiers but not just cap total value at 0.
2018-03-19 23:14   
That's not how it works in HMM3. There it caps the total morale at 0. E.g. +1 morale, -1 morale and spirit of oppression add up to 0 morale, just tested.
2018-03-19 23:38   
OK, then INDEPENDENT_MIN should be enough