MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002833VCMIGUI - Adventure Mappublic2017-12-30 02:422017-12-30 11:33
ReporterAndruids 
Assigned ToWarmonger 
PrioritynormalSeveritytrivialReproducibilityalways
StatusresolvedResolutionfixed 
PlatformPCOSWindowsOS Version8.1
Product Version0.99 
Target VersionFixed in Version1.next 
Summary0002833: Double, empty ability slot caused by Resistance skill
DescriptionWhen you open a unit window in hero with Resistance skill army, it shows another, empty slot with Resistance skill icon. It doesn't happen to Dwarves carried by a hero without Resistance skill, but happens with a hero that has it.
Steps To ReproduceOpen a unit window with a hero that has Resistance skill (many Rampart heroes have it as a starting skill).
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0002735closed Warmonger Magic Resistance granted by the hero skill is shown in the creature's tab twice. 
Attached Filesjpg vcmirestistancebug.jpg (243,927) 2017-12-30 02:42
https://bugs.vcmi.eu/file_download.php?file_id=2820&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2017-12-30 02:42AndruidsNew Issue
2017-12-30 02:42AndruidsFile Added: vcmirestistancebug.jpg
2017-12-30 11:07WarmongerNote Added: 0007336
2017-12-30 11:09WarmongerNote Edited: 0007336bug_revision_view_page.php?bugnote_id=7336#r3418
2017-12-30 11:26WarmongerNote Added: 0007337
2017-12-30 11:26WarmongerStatusnew => resolved
2017-12-30 11:26WarmongerFixed in Version => 1.next
2017-12-30 11:26WarmongerResolutionopen => fixed
2017-12-30 11:26WarmongerAssigned To => Warmonger
2017-12-30 11:33WarmongerRelationship addedhas duplicate 0002735

Notes
(0007336)
Warmonger   
2017-12-30 11:07   
(edited on: 2017-12-30 11:09)
This is known issue caused by the fact abilities are grouped by subtype. Default subtype for Magic resistance should be 0, and all Magic resistane bonuses should be unified. The problem is there are two sources of this bonus - MAGIC_RESISTANCE proper and secondary skill.

Too bad that code was changed significantly over years, difficult to point out where does this bug come from.
(0007337)
Warmonger   
2017-12-30 11:26   
Blah blah, fixed in https://github.com/vcmi/vcmi/commit/f523ae5545ae2d597858b2bce094ccf4be422da9 [^]