MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002730VCMIOtherpublic2017-07-21 07:522017-08-03 06:05
ReporterAnubis 
Assigned ToAVS 
PrioritynormalSeveritytextReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.99 
Target VersionFixed in Version1.next 
Summary0002730: The descriptions of some unit abilities are missing or incomplete, so are icons of those abilities.
DescriptionThe description for "General Damage Reduction" is misleading because it's a two-part ability with specifically Ranged or Melee damage reduction. There is no mention of that in the game currently.
"Spell Immunity" right now has no icon for it, and it's impossible to add any other via bonuses.json - it doesn't work.
There is no description for "No Morale" ability and the icon is missing too, and it has a bug connected to it which I will describe in another report.
Immunities to specific schools also have no icons despite being present in the VCMI files.
Fire Shield's icon was renamed but not updated in the bonuses.json. Same for Spell-like Attack but there's no icon in the game files.
Reduce Enemy Defense's name is too big and doesn't fit the tab on 1024*600.
Mind Immunity's description is missing.
Steps To ReproduceCheck any of the creatures that have the respective abilities, you'll see either an icon or the text missing, or any other behaviour that I've described.
Additional Information
TagsNo tags attached.
Relationships
Attached Files7z Bonuses fix.7z (2,992) 2017-07-21 08:13
https://bugs.vcmi.eu/file_download.php?file_id=2742&type=bug
zip Bonuses desc fix.zip (3,700) 2017-07-30 12:15
https://bugs.vcmi.eu/file_download.php?file_id=2753&type=bug
? bonuses.json (6,712) 2017-07-30 13:09
https://bugs.vcmi.eu/file_download.php?file_id=2754&type=bug
zip Bonuses.zip (3,742) 2017-07-30 14:24
https://bugs.vcmi.eu/file_download.php?file_id=2755&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-21 07:52AnubisNew Issue
2017-07-21 08:13AnubisFile Added: Bonuses fix.7z
2017-07-21 08:14AnubisNote Added: 0007151
2017-07-30 12:15AnubisFile Added: Bonuses desc fix.zip
2017-07-30 12:16AnubisNote Added: 0007186
2017-07-30 12:44misioklesNote Added: 0007187
2017-07-30 13:09AnubisFile Added: bonuses.json
2017-07-30 13:10AnubisNote Added: 0007188
2017-07-30 13:36misioklesNote Added: 0007189
2017-07-30 13:38misioklesNote Edited: 0007189bug_revision_view_page.php?bugnote_id=7189#r3375
2017-07-30 14:17AnubisNote Added: 0007190
2017-07-30 14:24AnubisFile Added: Bonuses.zip
2017-07-30 14:24AnubisNote Edited: 0007190bug_revision_view_page.php?bugnote_id=7190#r3377
2017-08-03 06:05AVSNote Added: 0007202
2017-08-03 06:05AVSStatusnew => resolved
2017-08-03 06:05AVSFixed in Version => 1.next
2017-08-03 06:05AVSResolutionopen => fixed
2017-08-03 06:05AVSAssigned To => AVS

Notes
(0007151)
Anubis   
2017-07-21 08:14   
Uploaded an 7z archive which contains 2 files for VCMI which partially fix these issues and improve the descriptions of creature abilities.
(0007186)
Anubis   
2017-07-30 12:16   
Updated the fix based on the latest build version.
(0007187)
misiokles   
2017-07-30 12:44   
But your fix include new icon and abilities like SOUL_STEAL, SUMMON_GUARDIANS and TRANSMUTATION?
(0007188)
Anubis   
2017-07-30 13:10   
The icons for those are already present in VCMI Essential files. Reuploaded a file which referenced those new abilities, for some reason SUMMON_GUARDIANS slipped past my eyes.
(0007189)
misiokles   
2017-07-30 13:36   
(edited on: 2017-07-30 13:38)
I propose also add for Cyclops King fixed ability

    "CATAPULT_EXTRA_SHOTS":
    {
        "graphics":
        {
            "icon": "zvs/Lib1.res/Catapult"
        }
    },

Yes, it's the same icon as Catapult, but looks nicer than no icon.
(0007190)
Anubis   
2017-07-30 14:17   
(edited on: 2017-07-30 14:24)
Ah, I've been wondering what this bonus is about. Will do later.
As of 14:24 UTC - updated.
(0007202)
AVS   
2017-08-03 06:05   
Fixed in https://github.com/vcmi/vcmi/pull/361 [^]