MantisBT - VCMI |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000268 | VCMI | Mechanics - Objects | public | 2009-12-01 08:54 | 2009-12-30 07:02 |
|
| Reporter | Steven Aus | |
| Assigned To | Warmonger | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 0.74c | |
| Target Version | | Fixed in Version | 0.75 | |
|
| Summary | 0000268: Objects such as Lean To, Wagon, Skeleton etc. use the "freebie here" response with no display when there is no freebie this time |
| Description | I think that when the Lean To, Wagon and Skeleton don't give out a result, they say on first visit they have a result but don't show anything (and when "visiting" a Skeleton in my current game nothing was given even though the dialog was the one where there was a freebie). If they don't have anything to give they need to give the dialog that there isn't a freebie on the object.
When I just tested then, a freebie of 3 Mercury was given from a Lean To, so it seems that the "freebie" response (with no further graphical display or actual bonus) is in the dialog even when the game has randomly generated an empty Lean To, Wagon, Skeleton or similar object.
The second and subsequent visit of a Lean To or similar "freebie or not"-type object gives the correct response, so that dialog needs to be used first time when there is no freebie for one of these object types. If there is a freebie it uses the response and graphical display it does now. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  LeanToTestGames.7z (156,339) 2009-12-01 10:26
https://bugs.vcmi.eu/file_download.php?file_id=126&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-12-01 08:54 | Steven Aus | New Issue | |
| 2009-12-01 09:28 | Warmonger | Assigned To | Tow => Warmonger |
| 2009-12-01 10:11 | Warmonger | Note Added: 0000334 | |
| 2009-12-01 10:25 | Steven Aus | Note Added: 0000336 | |
| 2009-12-01 10:26 | Steven Aus | File Added: LeanToTestGames.7z | |
| 2009-12-01 10:55 | Warmonger | Note Added: 0000337 | |
| 2009-12-01 10:56 | Warmonger | Status | assigned => resolved |
| 2009-12-01 10:56 | Warmonger | Fixed in Version | => SVN |
| 2009-12-01 10:56 | Warmonger | Resolution | open => fixed |
| 2009-12-01 11:40 | Warmonger | Note Added: 0000339 | |
| 2009-12-01 11:40 | Warmonger | Status | resolved => feedback |
| 2009-12-01 11:40 | Warmonger | Resolution | fixed => reopened |
| 2009-12-01 11:40 | Warmonger | Status | feedback => resolved |
| 2009-12-01 11:40 | Warmonger | Resolution | reopened => fixed |
| 2009-12-01 11:55 | Zamolxis | Note Added: 0000340 | |
| 2009-12-30 07:02 | Zamolxis | Note Added: 0000526 | |
| 2009-12-30 07:02 | Zamolxis | Status | resolved => closed |
|
Notes |
|
|
|
What I managed to reproduce:
-Lean-To always gives resource (never is empty)
-Wagon works ok
-Corpse gives wrong message from Marletto Tower and does not add info about found artifact (fixed in revision 1376).
So here it works quite fine. |
|
|
|
|
|
I think there might still be a bug - two games I played didn't seem to give any resources for Lean Tos, although it did say there were some resources (two Tale of Two Lands saves attached). |
|
|
|
|
None of these is reproductible. I may have fixed it in 0000241, as the code is simple and had a minor bug. Or it is something very strange.
Marked as fixed, please reopen if bug returns. |
|
|
|
|
|
I figured it out, once again serialization was missing so objects did not save properly. |
|
|
|
|
|
Hehe... I think serialization should be the first thing that comes to mind when a bug cannot be reproduced from now on. :) |
|
|
|
|
|
Seems to be fixed in 0.75. Please reopen if otherwise. |
|