MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002599VCMIAI - Battlespublic2016-11-11 18:152022-04-12 11:18
ReporterPovelitel 
Assigned ToDydzio 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.99 
Target VersionFixed in Version1.next 
Summary0002599: Crash when I use R click on enemy hero in battle
DescriptionВражеский герой нападает на меня, я кликаю на него правой кнопкой мыши - происходит вылет игры.
Steps To ReproduceНажать конец хода
Additional Information
TagsNo tags attached.
Relationships
Attached Files7z r-click.7z (388,477) 2016-11-11 18:15
https://bugs.vcmi.eu/file_download.php?file_id=2644&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-11-11 18:15PovelitelNew Issue
2016-11-11 18:15PovelitelStatusnew => assigned
2016-11-11 18:15PovelitelAssigned To => SXX
2016-11-11 18:15PovelitelFile Added: r-click.7z
2016-12-05 13:52DydzioNote Added: 0006930
2016-12-05 13:52DydzioStatusassigned => resolved
2016-12-05 13:52DydzioFixed in Version => 1.next
2016-12-05 13:52DydzioResolutionopen => fixed
2016-12-05 13:52DydzioAssigned ToSXX => Dydzio
2016-12-08 07:42PovelitelNote Added: 0006931
2016-12-08 10:51DydzioNote Added: 0006932
2016-12-10 10:38DydzioNote Added: 0006934
2016-12-10 10:38DydzioStatusresolved => assigned
2016-12-11 18:16SXXNote Added: 0006935
2016-12-11 18:16SXXStatusassigned => resolved
2016-12-11 21:32SXXRelationship addedrelated to 0002631
2016-12-11 21:32SXXRelationship deletedrelated to 0002631
2022-04-12 11:18PovelitelStatusresolved => closed

Notes
(0006930)
Dydzio   
2016-12-05 13:52   
Fixed in: https://github.com/vcmi/vcmi/pull/261 [^]
(0006931)
Povelitel   
2016-12-08 07:42   
ih this save still crash, it's normal?
(0006932)
Dydzio   
2016-12-08 10:51   
I'll check later
(0006934)
Dydzio   
2016-12-10 10:38   
Still crashable because of
"ERROR_RET_VAL_IF(!isVisible(h->getPosition(false)), "That hero is not visible!", false);"

when getting enemy hero info in battle while he attacks. Probably above code uses enemy hero position before making a move.
(0006935)
SXX   
2016-12-11 18:16   
So it's now fixed:
https://github.com/vcmi/vcmi/pull/262 [^]

Problem caused by fact that enemy hero attacked from teleporter entry that was within fog of war. Same would happen if you attack enemy on other side of teleporter.