MantisBT - VCMI | |||||||||||||||
| View Issue Details | |||||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||||
| 0002544 | VCMI | Multiplayer | public | 2016-10-03 19:53 | 2016-11-01 16:29 | ||||||||||
| Reporter | SXX | ||||||||||||||
| Assigned To | Ivan | ||||||||||||||
| Priority | normal | Severity | crash | Reproducibility | always | ||||||||||
| Status | resolved | Resolution | fixed | ||||||||||||
| Platform | OS | OS Version | |||||||||||||
| Product Version | 0.98g | ||||||||||||||
| Target Version | Fixed in Version | 0.99 | |||||||||||||
| Summary | 0002544: Multiplayer pregame: Too big length with different compilers | ||||||||||||||
| Description | So few weeks ago I make multiplayer kinda work again, but with really dirty hack that you can find on "CPreGame.cpp:728":sm.mapInfo->mapHeader->triggeredEvents.clear(); This made it kind a work when compiled with Clang and otherwise pregame netpacks failed to apply and caused 4GB RAM allocation and freeze As @AVS said there is some problem with serialization that can be easier to fix if we merge refactored serializer. My suggestion for fixing: we must not only rewrite this code, but completely get rid of single player server-less lobby. There is absolutely no reason why we would wanna maintain two different implementations if single player can work just fine with multiplayer code. So for single-player client must start or connect to server before you get to map selection or loading screen. Of course this mean we have to implement multiplayer loading screen too. | ||||||||||||||
| Steps To Reproduce | |||||||||||||||
| Additional Information | |||||||||||||||
| Tags | No tags attached. | ||||||||||||||
| Relationships |
| ||||||||||||||
| Attached Files | |||||||||||||||
| Issue History | |||||||||||||||
| Date Modified | Username | Field | Change | ||||||||||||
| 2016-10-03 19:53 | SXX | New Issue | |||||||||||||
| 2016-10-03 19:54 | SXX | Relationship added | related to 0002100 | ||||||||||||
| 2016-10-24 10:31 | SXX | Relationship added | related to 0002578 | ||||||||||||
| 2016-10-29 23:31 | SXX | Note Added: 0006870 | |||||||||||||
| 2016-11-01 16:29 | SXX | Note Added: 0006876 | |||||||||||||
| 2016-11-01 16:29 | SXX | Status | new => resolved | ||||||||||||
| 2016-11-01 16:29 | SXX | Fixed in Version | => 0.99 | ||||||||||||
| 2016-11-01 16:29 | SXX | Resolution | open => fixed | ||||||||||||
| 2016-11-01 16:29 | SXX | Assigned To | => Ivan | ||||||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||