MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002532VCMIMechanics - Battlespublic2016-09-29 22:092022-04-12 11:19
ReporterDydzio 
Assigned ToAVS 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoft WindowsOSWindows 7OS VersionHome Premium x64
Product Version0.98g 
Target VersionFixed in Version0.99 
Summary0002532: Dispel doesn't work on bloodlust spell
DescriptionAfter casting different spells and dispelling them in hotseat mode then bloodlust didn't get dispelled properly. Tested with expert level dispel and bloodlust spells.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? vcmispelltest.h3m (4,741) 2016-09-30 08:53
https://bugs.vcmi.eu/file_download.php?file_id=2572&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-29 22:09DydzioNew Issue
2016-09-29 23:38AVSNote Added: 0006780
2016-09-29 23:38AVSAssigned To => AVS
2016-09-29 23:38AVSStatusnew => feedback
2016-09-30 00:28AVSProduct Version0.99 => 0.98g
2016-09-30 08:53DydzioFile Added: vcmispelltest.h3m
2016-09-30 09:05DydzioNote Added: 0006781
2016-09-30 09:05DydzioStatusfeedback => assigned
2016-09-30 10:08AVSNote Added: 0006782
2016-09-30 14:15AVSNote Added: 0006784
2016-09-30 14:15AVSStatusassigned => resolved
2016-09-30 14:15AVSFixed in Version => 0.99
2016-09-30 14:15AVSResolutionopen => fixed
2022-04-12 11:19PovelitelStatusresolved => closed

Notes
(0006780)
AVS   
2016-09-29 23:38   
How to reproduce the issue?
(0006781)
Dydzio   
2016-09-30 09:05   
I just uploaded map which I used for test. Play in hotseat mode, cast some negative / positive spells that have duration - bless, curse, etc., cast bloodlust, then try to dispel it. Bloodlust will stay on units, while other spells will be gone.
(0006782)
AVS   
2016-09-30 10:08   
Bug affects all spells with bonus effect limit, not only bloodlust. Something wrong with bonus system in

void BonusList::getBonuses(BonusList & out, const CSelector &selector, const CSelector &limit)

Kind of easy to fix, but it will cause many regressions for sure
(0006784)
AVS   
2016-09-30 14:15   
Fixed in https://github.com/vcmi/vcmi/commit/2f7e10a06f152d19498ad2386e32ca2cc9006fea [^]