MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002527VCMIMechanics - Adventure Mappublic2016-09-29 16:532022-04-12 11:19
Reportermisiokles 
Assigned ToAVS 
PriorityhighSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformPCOSWindowsOS Version10
Product Version0.98g 
Target VersionFixed in Version0.99 
Summary0002527: Mistical Gardens, Sawmills etc. can be visited only once per game.
DescriptionOnce-per-week-visitable objects give rewards only for first visit. At start of the new week, objects still have flags 'visited'.
Steps To Reproduce1. Load attached saves.
2. It's day 7, end of the week.
3. Not far from Ciele, there's visited Mistical Garden.
4. Press End Turn.
5. New week begins, but Mistical Garden is still marked as visited.
Additional InformationVCMI daily build: 29-Sep-2016 14:54
TagsNo tags attached.
Relationships
related to 0002507closed AVS Windmill shows wrong message and not reset 
Attached Fileszip misticalGardenSaves.zip (874,985) 2016-09-29 16:53
https://bugs.vcmi.eu/file_download.php?file_id=2570&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-29 16:53misioklesNew Issue
2016-09-29 16:53misioklesFile Added: misticalGardenSaves.zip
2016-09-29 17:42SXXNote Added: 0006772
2016-09-29 17:56SXXRelationship addedrelated to 0002507
2016-10-09 13:04SXXAssigned To => SXX
2016-10-09 13:04SXXStatusnew => confirmed
2016-10-09 14:11SXXNote Added: 0006816
2016-10-09 14:13SXXAssigned ToSXX =>
2016-10-09 14:13SXXPrioritynormal => high
2016-10-09 14:13SXXSeverityfeature => block
2016-10-09 15:42AVSAssigned To => AVS
2016-10-09 15:42AVSStatusconfirmed => assigned
2016-10-09 16:41AVSNote Added: 0006817
2016-10-09 16:45AVSNote Added: 0006818
2016-10-11 17:04AVSNote Added: 0006822
2016-10-11 17:04AVSStatusassigned => resolved
2016-10-11 17:04AVSFixed in Version => 0.99
2016-10-11 17:04AVSResolutionopen => fixed
2022-04-12 11:19PovelitelStatusresolved => closed

Notes
(0006772)
SXX   
2016-09-29 17:42   
Yep latest hotfix for once visitable objects like corpse broken them, but Chocimier working on the fix.
(0006816)
SXX   
2016-10-09 14:11   
So I broken it when merged PR214:
https://github.com/vcmi/vcmi/pull/214 [^]

So these commits:
https://github.com/vcmi/vcmi/commit/50b271393c036fdcee7c09124b02e7b52df90110 [^]
https://github.com/vcmi/vcmi/commit/bb05db90e53183bd67524ca54d5c317e1f5aa4fb [^]

Chocimier tried to fix it there:
https://github.com/Chocimier/vcmi/commit/381882b#diff-9369aa41e728a6efe54fb472c342b61bR1089 [^]

But this is wrong solution since it's try to apply netpack inside netpack and proper redesign needed. I hoped to fix it, but temporary I simply don't have time to do that and test solution properly.

So this have to be fixed before next release.
(0006817)
AVS   
2016-10-09 16:41   
https://github.com/vcmi/vcmi/pull/236 [^]
(0006818)
AVS   
2016-10-09 16:45   
fix particular issue is resolved in pr236
(0006822)
AVS   
2016-10-11 17:04   
Fixed in https://github.com/vcmi/vcmi/pull/236 [^]