MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002372VCMIMechanics - Adventure Mappublic2016-01-13 16:092022-04-12 09:17
ReporterKantor 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.98f 
Target VersionFixed in Version0.98g 
Summary0002372: Reward from beaten creature doesn't work
DescriptionPlayer doesn't gain any reward from beating a neutral creature, which has such reward included.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? reward test.h3m (9,632) 2016-01-13 16:09
https://bugs.vcmi.eu/file_download.php?file_id=2420&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-13 16:09KantorNew Issue
2016-01-13 16:09KantorFile Added: reward test.h3m
2016-01-13 17:59SXXAssigned To => SXX
2016-01-13 17:59SXXStatusnew => assigned
2016-01-14 07:07SXXNote Added: 0006273
2016-01-14 07:08SXXNote Edited: 0006273bug_revision_view_page.php?bugnote_id=6273#r3124
2016-01-14 07:49SXXNote Added: 0006274
2016-01-14 11:54KantorNote Added: 0006275
2016-01-14 11:55KantorNote Edited: 0006275bug_revision_view_page.php?bugnote_id=6275#r3126
2016-01-14 11:57KantorNote Edited: 0006275bug_revision_view_page.php?bugnote_id=6275#r3127
2016-01-14 17:09SXXNote Added: 0006276
2016-01-14 17:13SXXNote Edited: 0006276bug_revision_view_page.php?bugnote_id=6276#r3129
2016-01-14 17:31SXXNote Edited: 0006276bug_revision_view_page.php?bugnote_id=6276#r3130
2016-01-15 01:39SXXNote Added: 0006279
2016-01-15 01:39SXXStatusassigned => resolved
2016-01-15 01:39SXXFixed in Version => 0.98g
2016-01-15 01:39SXXResolutionopen => fixed
2016-01-15 09:27KantorNote Added: 0006281
2022-04-12 09:17PovelitelStatusresolved => closed

Notes
(0006273)
SXX   
2016-01-14 07:07   
(edited on: 2016-01-14 07:08)
Good catch! End up this is not implemented yet, so I'll do that now.
(0006274)
SXX   
2016-01-14 07:49   
What funny: your map break original H3. Even if I add new object that only give artifact it's not working and give me resources.

Anyway with new map H3 behaviour is:
 - If you kill creatures or let them join you then you get one or both rewards.
 - If you let them flee then no rewards given.
(0006275)
Kantor   
2016-01-14 11:54   
(edited on: 2016-01-14 11:57)
>your map break original H3
   Hehe, so you've found a bug in a OH3 map editor.

Speaking of way, that OH3 informs player about gained resources, maybe it would be better to implement one pop-up window, which would show all gained resources at once, in one place, instead of current OH3 way (one window with wood, one with ore, and so on...).
(0006276)
SXX   
2016-01-14 17:09   
(edited on: 2016-01-14 17:31)
Yeah of course we do have code to form appropriate windows that contain all needed resources in one.
(0006279)
SXX   
2016-01-15 01:39   
Implemented:
https://github.com/vcmi/vcmi/commit/b84d7bd288552d7cde99a830397062a19263637a [^]

Though I wish we can find out way to end implementation of rewardable objects or mixins somehow. Still for now we better to have some support than none.
(0006281)
Kantor   
2016-01-15 09:27   
Well done :)