MantisBT - VCMI
View Issue Details
0002362VCMIGUI - Otherpublic2016-01-02 11:422016-02-19 10:25
Kantor 
vmarkovtsev 
normalminorhave not tried
resolvedfixed 
0.98f 
0.98g 
0002362: Spell book doesn't work correctly for garrisoned hero
When hero is in town garrison, adventure spells in his spell book like View Earth/Ait are castable.
No tags attached.
Issue History
2016-01-02 11:42KantorNew Issue
2016-01-02 23:25SXXNote Added: 0006245
2016-01-02 23:27SXXNote Edited: 0006245bug_revision_view_page.php?bugnote_id=6245#r3091
2016-01-03 09:02KantorNote Added: 0006246
2016-01-03 16:03SXXNote Added: 0006247
2016-01-31 15:21vmarkovtsevAssigned To => vmarkovtsev
2016-01-31 15:21vmarkovtsevStatusnew => assigned
2016-01-31 17:01vmarkovtsevNote Added: 0006394
2016-02-19 10:25SXXStatusassigned => resolved
2016-02-19 10:25SXXFixed in Version => 0.98g
2016-02-19 10:25SXXResolutionopen => fixed

Notes
(0006245)
SXX   
2016-01-02 23:25   
(edited on: 2016-01-02 23:27)
Is there any reason to not make them castable except may be dimension door?

Though even in case of dimension door it's looks reasonable to keep it like that as long as it's works correctly. This looks okay because in most cases switch between garrison and visit cost nothing anyway. Other question what to do if exit blocked by ally hero.

(0006246)
Kantor   
2016-01-03 09:02   
For View Air/Earth are GUI issues.
(0006247)
SXX   
2016-01-03 16:03   
Ah. Then it's need to be disabled. Though I think it's then reasonable to forbid adventure spell casting when hero garrisoned on server-side as well.
(0006394)
vmarkovtsev   
2016-01-31 17:01   
https://github.com/vcmi/vcmi/pull/187 [^]